New issue
Advanced search Search tips

Issue 863858 link

Starred by 1 user
Status: Verified
Owner:
gambard@chromium.org
Closed: Jul 16
Cc:
ios-bugs-priority@chromium.org
ios-bugs@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Find In Page not working in RTL

Project Member Reported by gambard@chromium.org, Jul 16 
In RTL

What steps will reproduce the problem?
(1) Open a WebPage
(2) Open FindInPage
(3) Type a lot in the text field

What is the expected result?
There should be a space between the counts of results and the string searched. The done button should be visible.

What happens instead?
The done button is compressed. There is not space.
Simulator Screen Shot - iPhone 8 Plus - 2018-07-16 at 14.41.49.png
227 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6aaa72dd57ef6557b7eae80b4c884c3035c3cc35

commit 6aaa72dd57ef6557b7eae80b4c884c3035c3cc35
Author: Gauthier Ambard <gambard@chromium.org>
Date: Mon Jul 16 14:59:27 2018

[iOS] Fix FindInPage UI

This CL fixes FindInPage UI to have the text field expanding before
the done button and preventing the done button from being compressed
by the text field.
It also adds a padding to the results counter.

Bug:  863858 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Iec64c02ef8ac40ad7018fb617e09f0a508cefe3c
Reviewed-on: https://chromium-review.googlesource.com/1138240
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575263}
[modify] https://crrev.com/6aaa72dd57ef6557b7eae80b4c884c3035c3cc35/ios/chrome/browser/ui/find_bar/find_bar_view.mm

Comment 2 by gambard@chromium.org, Jul 16

Status: Fixed (was: Assigned)

Comment 3 by shbarezer@chromium.org, Jul 24

Status: Verified (was: Fixed)
Verified in 70.0.3501.0 Canary, iPhone X  iOS 11.4, iPad Air  iOS11.4

Looks good.
►

Sign in to add a comment