New issue
Advanced search Search tips

Issue 863847 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 18
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

Cros: Offline gaia DCHECKs when entered non-existing username

Project Member Reported by rsorokin@chromium.org, Jul 16

Issue description

Chrome Version: TOT
OS: Chrome OS

What steps will reproduce the problem?
I did that on the linux build of Chrome OS

cat out/Default/args.gn 
# Build arguments go here. Examples:
#   is_component_build = true
#   is_debug = false
symbol_level = 0
is_component_build = true
enable_nacl = false
use_goma = true
target_os = "chromeos"
is_official_build = false
is_chrome_branded = false
is_debug = false
remove_webcore_debug_symbols = true
dcheck_always_on = true



(1) out/Default/chrome --login-manager --login-profile=user --disable-setuid-sandbox --no-sandbox --user-data-dir=<directory with passed oobe> --shill-stub=clear=1
(2) On the network screen click "sign in as an existing user"
(3) enter non-existing on the device username and try to auth

What is the expected result?
Error on the screen

What happens instead?
Crash
[174778:174778:0716/133153.531374:ERROR:base_screen_handler_utils.cc(71)] Failed to deserialize, parse as email, valid=1
[174778:174778:0716/133153.531465:FATAL:signin_screen_handler.cc(1199)] Check failed: user. 
#0 0x7f7724d3c5bc base::debug::StackTrace::StackTrace()
#1 0x7f7724c6f60b logging::LogMessage::~LogMessage()
#2 0x5580f63675be chromeos::SigninScreenHandler::HandleAuthenticateUser()
#3 0x5580f636e650 _ZN5login18DispatchToCallbackIJRK9AccountIdRKNSt3__112basic_stringIcNS4_11char_traitsIcEENS4_9allocatorIcEEEEbEJLm0ELm1ELm2EEEEvRKN4base17RepeatingCallbackIFvDpT_EEEPKNSD_9ListValueENS4_16integer_sequenceImJXspT0_EEEE
#4 0x7f77222ec3f8 content::WebUIImpl::ProcessWebUIMessage()
#5 0x7f77222eb4ec _ZN3IPC8MessageTI27FrameHostMsg_WebUISend_MetaNSt3__15tupleIJNS2_12basic_stringIcNS2_11char_traitsIcEENS2_9allocatorIcEEEEN4base9ListValueEEEEvE8DispatchIN7content9WebUIImplESG_NSF_15RenderFrameHostEMSG_FvPSH_RKS9_RKSB_EEEbPKNS_7MessageEPT_PT0_PT1_T2_
#6 0x7f77222eb42c content::WebUIImpl::OnMessageReceived()
#7 0x7f77222a71f4 content::WebContentsImpl::OnMessageReceived()
#8 0x7f7721f5b0c4 content::RenderFrameHostImpl::OnMessageReceived()
#9 0x7f772216392b content::RenderProcessHostImpl::OnMessageReceived()
#10 0x7f77233e6631 IPC::ChannelProxy::Context::OnDispatchMessage()
#11 0x7f77233e915b _ZN4base8internal7InvokerINS0_9BindStateIMN3IPC12ChannelProxy7ContextEFvRKNS3_7MessageEEJ13scoped_refptrIS5_ES6_EEEFvvEE3RunEPNS0_13BindStateBaseE
#12 0x7f7724c52865 base::debug::TaskAnnotator::RunTask()
#13 0x7f7724c7be49 base::internal::IncomingTaskQueue::RunTask()
#14 0x7f7724c7f7eb base::MessageLoop::RunTask()
#15 0x7f7724c7fb7a base::MessageLoop::DeferOrRunPendingTask()
#16 0x7f7724c7fe87 base::MessageLoop::DoWork()
#17 0x7f7724d5c619 base::MessagePumpLibevent::Run()
#18 0x7f7724c7f1d4 base::MessageLoop::Run()
#19 0x7f7724cb1209 base::RunLoop::Run()
#20 0x5580f504ba6b ChromeBrowserMainParts::MainMessageLoopRun()
#21 0x7f7721dd5307 content::BrowserMainLoop::RunMainMessageLoopParts()
#22 0x7f7721dd7e26 content::BrowserMainRunnerImpl::Run()
#23 0x7f7721dd1699 content::BrowserMain()
#24 0x7f7722824090 content::ContentMainRunnerImpl::Run()
#25 0x7f7724ff6bc5 service_manager::Main()
#26 0x7f7722822394 content::ContentMain()
#27 0x5580f44bdf93 ChromeMain
#28 0x7f77166222b1 __libc_start_main
#29 0x5580f44bde0a _start
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71fd2e939239d0fb829c4061999736ab364bdbbe

commit 71fd2e939239d0fb829c4061999736ab364bdbbe
Author: Alexander Alekseev <alemate@chromium.org>
Date: Wed Jul 18 23:40:55 2018

Chrome OS: Fix DCHECK in Offline Gaia screen.


Offline Gaia did not have dedicated API, so it crashed when trying to
sign-in as non-existing user. This CL adds a dedicated API which displays error
message to user.

Bug:  863847 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I8354a88befb7cb99a64519c3f3d07449ead8fc4d
Reviewed-on: https://chromium-review.googlesource.com/1141654
Commit-Queue: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Roman Sorokin <rsorokin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576256}
[modify] https://crrev.com/71fd2e939239d0fb829c4061999736ab364bdbbe/chrome/browser/resources/chromeos/login/screen_gaia_signin.js
[modify] https://crrev.com/71fd2e939239d0fb829c4061999736ab364bdbbe/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc
[modify] https://crrev.com/71fd2e939239d0fb829c4061999736ab364bdbbe/chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h

Status: Fixed (was: Assigned)

Sign in to add a comment