Main video stays in 'Picture-in-picture' mode even after closing the 'Picture-in-picture' window.
Reported by
avsha...@etouch.net,
Jul 16
|
||||||||
Issue descriptionChrome Version : 69.0.3493.0 (Official Build) 7066e76287893adffd8bbd8c71c369cdc995c0c3-refs/branch-heads/3493@{#1} 32/64 bit OS : Windows (7, 8, 8.1, 10), Linux (14.04 LTS) Test URL : https://www.quirksmode.org/html5/tests/video.html What steps will reproduce the problem? 1. Launch chrome, navigate to above URL and play the first video seen on the page in 'Picture-in-picture' mode. 2. Right click on 'Picture-in-picture' window and select 'Close' option from context menu. 3. Observe the main video on the page. Actual Result : Main video stays in 'Picture-in-picture' mode even after closing the 'Picture-in-picture' window through context menu option. Expected Result : Main video should come back to normal mode after closing the 'Picture-in-picture' window. This is a Non-regression issue seen from M-69 series, since the new 'Picture-in-picture' mode was introduced in build #69.0.3483.0 Note: 1. In Linux (14.04 LTS) OS, right click action is not possible in 'Picture-in-picture' window, hence used 'Alt + F4' keys to close the window in step 2. 2. Above issue is not observe in Mac(10.12.6, 10.13.1, 10.14, 10.13.6) OS.
,
Jul 23
I have a fix for this.
,
Jul 23
,
Jul 23
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c04a9a27665700d3697b59d74964bfae1aafe7f3 commit c04a9a27665700d3697b59d74964bfae1aafe7f3 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Tue Jul 24 17:22:59 2018 Picture-in-Picture: notifies the controller when window closed via system. When the internal object is destroyed, notify the controller so it can reset its internal state. It allows the user to close the window via any system/window manager UI. Bug: 863842 Change-Id: Ica84f4ffee2578658a60e0ae708a4e327d293077 Reviewed-on: https://chromium-review.googlesource.com/1147252 Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#577594} [modify] https://crrev.com/c04a9a27665700d3697b59d74964bfae1aafe7f3/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/c04a9a27665700d3697b59d74964bfae1aafe7f3/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/c04a9a27665700d3697b59d74964bfae1aafe7f3/chrome/browser/ui/views/overlay/overlay_window_views.h [modify] https://crrev.com/c04a9a27665700d3697b59d74964bfae1aafe7f3/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/c04a9a27665700d3697b59d74964bfae1aafe7f3/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h [modify] https://crrev.com/c04a9a27665700d3697b59d74964bfae1aafe7f3/content/public/browser/picture_in_picture_window_controller.h
,
Jul 24
,
Jul 25
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 25
Pls merge your change to M69 branch 3497 latest by 3:00 PM PT today, Wednesday (07/25/18). Thank you.
,
Jul 25
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05cac719625ffb9eff9df13a0d85018b56b8a2e3 commit 05cac719625ffb9eff9df13a0d85018b56b8a2e3 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Wed Jul 25 19:00:51 2018 Picture-in-Picture: notifies the controller when window closed via system. When the internal object is destroyed, notify the controller so it can reset its internal state. It allows the user to close the window via any system/window manager UI. Bug: 863842 Change-Id: Ica84f4ffee2578658a60e0ae708a4e327d293077 Reviewed-on: https://chromium-review.googlesource.com/1147252 Reviewed-by: Camille Lamy <clamy@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577594}(cherry picked from commit c04a9a27665700d3697b59d74964bfae1aafe7f3) Reviewed-on: https://chromium-review.googlesource.com/1150580 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#83} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/05cac719625ffb9eff9df13a0d85018b56b8a2e3/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/05cac719625ffb9eff9df13a0d85018b56b8a2e3/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/05cac719625ffb9eff9df13a0d85018b56b8a2e3/chrome/browser/ui/views/overlay/overlay_window_views.h [modify] https://crrev.com/05cac719625ffb9eff9df13a0d85018b56b8a2e3/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/05cac719625ffb9eff9df13a0d85018b56b8a2e3/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.h [modify] https://crrev.com/05cac719625ffb9eff9df13a0d85018b56b8a2e3/content/public/browser/picture_in_picture_window_controller.h
,
Jul 25
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by rbasuvula@chromium.org
, Jul 16