New issue
Advanced search Search tips

Issue 863840 link

Starred by 1 user

Issue metadata

Status: Verified
Owner: ----
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug-Security

Blocking:
issue 856823



Sign in to add a comment

Crash in webrtc::ForwardErrorCorrection::XorPayloads

Project Member Reported by ClusterFuzz, Jul 16

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4526464436011008

Fuzzer: libFuzzer_ulpfec_receiver_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x3b268dde9000
Crash State:
  webrtc::ForwardErrorCorrection::XorPayloads
  webrtc::ForwardErrorCorrection::RecoverPacket
  webrtc::ForwardErrorCorrection::AttemptRecovery
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=574542:574544

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4526464436011008

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 16

Cc: danilchap@webrtc.org
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Fix buffer overflow in ulpfec recovery by danilchap@webrtc.org - https://webrtc.googlesource.com/src/+/865feabca9a65cd04b5004415e7976aed50b7c2a

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Blocking: 856823
Project Member

Comment 3 by sheriffbot@chromium.org, Jul 16

Labels: M-69 Target-69
Project Member

Comment 4 by sheriffbot@chromium.org, Jul 16

Labels: ReleaseBlock-Stable
This is a serious security regression. If you are not able to fix this quickly, please revert the change that introduced it.

If this doesn't affect a release branch, or has not been properly classified for severity, please update the Security_Impact or Security_Severity labels, and remove the ReleaseBlock label. To disable this altogether, apply ReleaseBlock-NA.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 5 by sheriffbot@chromium.org, Jul 16

Labels: Pri-1
Reverted the change where it was introduced.
https://webrtc-review.googlesource.com/c/src/+/88720
Components: Blink>WebRTC
Project Member

Comment 9 by ClusterFuzz, Jul 17

ClusterFuzz has detected this issue as fixed in range 575257:575272.

Detailed report: https://clusterfuzz.com/testcase?key=4526464436011008

Fuzzer: libFuzzer_ulpfec_receiver_fuzzer
Job Type: libfuzzer_chrome_ubsan
Platform Id: linux

Crash Type: UNKNOWN WRITE
Crash Address: 0x3b268dde9000
Crash State:
  webrtc::ForwardErrorCorrection::XorPayloads
  webrtc::ForwardErrorCorrection::RecoverPacket
  webrtc::ForwardErrorCorrection::AttemptRecovery
  
Sanitizer: undefined (UBSAN)

Recommended Security Severity: High

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=574542:574544
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_ubsan&range=575257:575272

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4526464436011008

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jul 17

Labels: ClusterFuzz-Verified
Status: Verified (was: Untriaged)
ClusterFuzz testcase 4526464436011008 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.
Project Member

Comment 11 by sheriffbot@chromium.org, Jul 17

Labels: -Restrict-View-SecurityTeam Restrict-View-SecurityNotify
Labels: -ReleaseBlock-Stable
Project Member

Comment 13 by sheriffbot@chromium.org, Oct 23

Labels: -Restrict-View-SecurityNotify allpublic
This bug has been closed for more than 14 weeks. Removing security view restrictions.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment