New issue
Advanced search Search tips

Issue 863833 link

Starred by 2 users
Status: Fixed
Owner:
melandory@chromium.org
Closed: Jul 18
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 801985



Sign in to add a comment

Pipe instance_id token to the registration manager.

Project Member Reported by melandory@chromium.org, Jul 16 
Subscription for topics in Per user topic registration manager requires the instance_id token.

The Network has the information required for obtaining this token.

So once the token is ready, it should be passed to InvalidationListener and then to the registration manager in order to perform the registation.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94aed4e69bada77b599daa12afa45da693f6021a

commit 94aed4e69bada77b599daa12afa45da693f6021a
Author: Tanja Gornak <melandory@chromium.org>
Date: Wed Jul 18 08:01:58 2018

Pipe the instance_id token from network to Registation Manager.

Bug:  863833 , 801985
Change-Id: I1c008f672220cf1ff1a7cabc4ad977920fd9852d
Reviewed-on: https://chromium-review.googlesource.com/1138239
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575973}
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/fcm_sync_invalidation_listener.cc
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/fcm_sync_invalidation_listener.h
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/fcm_sync_invalidation_listener_unittest.cc
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/fcm_sync_network_channel.cc
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/fcm_sync_network_channel.h
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/invalidation_listener.h
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/per_user_topic_invalidation_client.cc
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/per_user_topic_invalidation_client.h
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/per_user_topic_invalidation_client_unittest.cc
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/per_user_topic_registration_manager.cc
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/per_user_topic_registration_manager.h
[modify] https://crrev.com/94aed4e69bada77b599daa12afa45da693f6021a/components/invalidation/impl/per_user_topic_registration_manager_unittest.cc

Comment 2 by melandory@chromium.org, Jul 18

Status: Fixed (was: Available)
►

Sign in to add a comment