New issue
Advanced search Search tips

Issue 863832 link

Starred by 2 users
Status: Fixed
Owner:
rbpotter@chromium.org
Closed: Jul 26
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: [Print Preview]Blue focus ring is not seen properly on 'More settings...' button and looks weird.

Reported by dchau...@etouch.net, Jul 16 
Chrome Version: 69.0.3493.0 (Official Build) Revision	7066e76287893adffd8bbd8c71c369cdc995c0c3-refs/branch-heads/3493@{#1} 32/64-bit.
OS: Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS

Pre-condition: Enable 'Enable new Print Preview UI' flag from chrome://flags.

What steps will reproduce the problem?
1. Launch Chrome and give print command on any webpage using "Ctrl/Command + P" key from keyboard.
2. Press 'Tab' key from keyboard such that focus reached to 'More settings...' button and observe.

Actual: Blue focus ring is not seen properly on 'More settings...' button.
Expected: Blue focus ring should seen properly on 'More settings...' button.

This is a regression issue, broken in M-68 series, below is manual regression range:

Good build: 68.0.3439.0 (Revision: 561389)
Bad build: 68.0.3440.0 (Revision: 561733)

Using the per-revision bisect providing the bisect results:

You are probably looking for a change made after 561726 (known good), but no later than 561727 (first known bad).
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.
https://chromium.googlesource.com/chromium/src/+log/bccfc8dc9f563a6e12129e729de730e0b1c42f82..20cc6356bc2a6136f3b1c4602926aad443784270

Suspecting: https://chromium.googlesource.com/chromium/src/+/20cc6356bc2a6136f3b1c4602926aad443784270

@rbpotter : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

NOTE: This issue is also reproducible on Beta #68.0.3440.59 and Dev #69.0.3486.0

Kindly review the attached screen-cast for reference.

Thank you.
Blue_Focus_Ring_Screenshot.png
4.6 KB View Download
Actual behavior.mp4
623 KB View Download
Expected behavior.mp4
597 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b

commit 8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b
Author: rbpotter <rbpotter@chromium.org>
Date: Wed Jul 25 20:55:16 2018

Print Preview Componentization: Fix more settings focus

Focus only the full more settings element, instead of just the action
link, since it looks odd. This is a better match for the behavior of
similar buttons/action links elsewhere (e.g. settings).

Bug:  863832 
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3272d89b7014ed6aaeff56900858f9c2253274ca
Reviewed-on: https://chromium-review.googlesource.com/1139223
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#578056}
[modify] https://crrev.com/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b/chrome/browser/resources/print_preview/new/BUILD.gn
[modify] https://crrev.com/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b/chrome/browser/resources/print_preview/new/app.html
[modify] https://crrev.com/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b/chrome/browser/resources/print_preview/new/app.js
[modify] https://crrev.com/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b/chrome/browser/resources/print_preview/new/more_settings.html
[modify] https://crrev.com/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b/chrome/browser/resources/print_preview/new/more_settings.js
[modify] https://crrev.com/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b/chrome/browser/resources/print_preview/new/print_preview_shared_css.html

Comment 2 by dchau...@etouch.net, Jul 26

Labels: TE-Verified-M70 TE-Verified-70.0.3503.0
Update:
Rechecked the above issue on Mac(10.12.6, 10.13.1, 10.13.6, 10.14), Windows(7,8,8.1,10) and Linux(14.04) machines using latest canary #70.0.3503.0 and issue is fixed. Hence adding TE-Verified labels.

please refer below attached screen-cast for reference.

Thank You.
Fixed_behavior.mp4
473 KB View Download

Comment 3 by rbpotter@chromium.org, Jul 26

Status: Fixed (was: Assigned)
►

Sign in to add a comment