AEC3: No special action is taken when the microphone gain is changed |
||
Issue descriptionWhen the microphone gain is changed the echo path is also changed which causes the linear filter in AEC3 to be inaccurate. Since this strongly impacts the AEC performance, and is furthermore possible to detect, a special action should be taken to handle that event properly.
,
Jul 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3a6677f0d909fbec120242df864fdb9ce185a28b commit 3a6677f0d909fbec120242df864fdb9ce185a28b Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Mon Jul 16 22:56:42 2018 Roll src/third_party/webrtc 3643aef89c78..056d811b6a04 (8 commits) https://webrtc.googlesource.com/src.git/+log/3643aef89c78..056d811b6a04 git log 3643aef89c78..056d811b6a04 --date=short --no-merges --format='%ad %ae %s' 2018-07-16 hta@webrtc.org Add counting of PCs with private IP addresses exposed 2018-07-16 shampson@webrtc.org Fix so that codec max bitrate doesn't override. 2018-07-16 emircan@webrtc.org Add color space information to webrtc::VideoFrame and extract from VP9 2018-07-16 buildbot@webrtc.org Roll chromium_revision a0e2753f75..3668886840 (575203:575305) 2018-07-16 peah@webrtc.org AEC3: Adding explicit handling of microphone gain changes 2018-07-16 mbonadei@webrtc.org Removing find_bad_constructs from system_wrappers. 2018-07-16 mbonadei@webrtc.org Removing clang:find_bad_constructs from stats/. 2018-07-16 stefan@webrtc.org Move allocation and rtp conversion logic out of payload router. Created with: gclient setdep -r src/third_party/webrtc@056d811b6a04 The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:718508,chromium:None,chromium:863826 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I5df87bef7a64c730355d76c3f111ae9250ba264b Reviewed-on: https://chromium-review.googlesource.com/1138674 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#575461} [modify] https://crrev.com/3a6677f0d909fbec120242df864fdb9ce185a28b/DEPS
,
Jul 24
Is this finished?
,
Aug 7
,
Aug 28
The following revision refers to this bug: https://webrtc.googlesource.com/src.git/+/5cd81cbff7201487dc9d7acac98e0beb7d8f6aa5 commit 5cd81cbff7201487dc9d7acac98e0beb7d8f6aa5 Author: Gustaf Ullberg <gustaf@webrtc.org> Date: Tue Aug 28 07:26:40 2018 AEC3: Disabling explicit handling of microphone gain changes Disables the faster filter adaptation in the event of microphone gain changes as it sometimes impacted transparency negatively. Bug: webrtc:9526 , chromium:863826 Change-Id: I48fb6dd45440518aaf94b6469d6bb891247ea4ab Reviewed-on: https://webrtc-review.googlesource.com/95143 Reviewed-by: Per Åhgren <peah@webrtc.org> Commit-Queue: Gustaf Ullberg <gustaf@webrtc.org> Cr-Commit-Position: refs/heads/master@{#24461} [modify] https://crrev.com/5cd81cbff7201487dc9d7acac98e0beb7d8f6aa5/modules/audio_processing/aec3/main_filter_update_gain.cc [modify] https://crrev.com/5cd81cbff7201487dc9d7acac98e0beb7d8f6aa5/modules/audio_processing/aec3/subtractor.cc
,
Aug 28
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5cd46a4bf8cb4bc92f22c4835a2c955d467a1b78 commit 5cd46a4bf8cb4bc92f22c4835a2c955d467a1b78 Author: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Date: Tue Aug 28 10:59:58 2018 Roll src/third_party/webrtc d8111e2169c9..69b03e960ed6 (3 commits) https://webrtc.googlesource.com/src.git/+log/d8111e2169c9..69b03e960ed6 git log d8111e2169c9..69b03e960ed6 --date=short --no-merges --format='%ad %ae %s' 2018-08-28 xz4215@gmail.com Fix iOS demo H264 profile display. 2018-08-28 gustaf@webrtc.org AEC3: Disabling explicit handling of microphone gain changes 2018-08-28 gustaf@webrtc.org AEC3: Removing some old kill switches Created with: gclient setdep -r src/third_party/webrtc@69b03e960ed6 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng BUG=chromium:none,chromium:863826 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I2ef7361df6b6fe2389ddd16ec75205d7e66e6278 Reviewed-on: https://chromium-review.googlesource.com/1193124 Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#586647} [modify] https://crrev.com/5cd46a4bf8cb4bc92f22c4835a2c955d467a1b78/DEPS |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jul 16