New issue
Advanced search Search tips

Issue 863822 link

Starred by 3 users
Status: Fixed
Owner: ----
Closed: Aug 31
Cc:
omrilio@chromium.org
ajha@chromium.org
sammiequon@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'Expand shelf' icon is seen even when there is more space in the shelf

Project Member Reported by kebalaji@chromium.org, Jul 16 
Chrome Version: 69.0.3491.0/10880.0.0 dev channel  Kip, Reks ,Peppy
OS: Chrome OS

What steps will reproduce the problem?
(1)Sign-in to user>> Observe 'Expand shelf' icon is seen even when there is more space in the shelf (Refer screenshots)

Actual: 'Expand shelf' icon is seen even when there is more space in the shelf 
Expected: 'Expand shelf' icon should be seen when there is no much space in the shelf to accumulated the apps

This is a Regression issue as same is working fine on 69.0.3486.0/10866.1.0 dev
ActualShelf.png
15.0 KB View Download
ExpectedShelf.png
40.6 KB View Download
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4c1b5d51eeb7cf7e62bc2ec04d155fdbfaa73996

commit 4c1b5d51eeb7cf7e62bc2ec04d155fdbfaa73996
Author: Sammie Quon <sammiequon@google.com>
Date: Mon Jul 16 18:44:41 2018

shelf: Remove accidently left behind testing code.

Used this to display the overflow bubble more easily.

R=msw@chromium.org

Test: manual
Bug:  863822 
Change-Id: Id7cb6147c5ce4b699ed5c3573ab23388cdb0b465
Reviewed-on: https://chromium-review.googlesource.com/1138404
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575365}
[modify] https://crrev.com/4c1b5d51eeb7cf7e62bc2ec04d155fdbfaa73996/ash/shelf/shelf_view.cc
[modify] https://crrev.com/4c1b5d51eeb7cf7e62bc2ec04d155fdbfaa73996/ash/shelf/shelf_view_unittest.cc

Comment 2 by newcomer@chromium.org, Jul 18

Labels: Not-Touch-Friendly-Launcher

Comment 3 by cindyb@chromium.org, Aug 31 

It appears a fix was completed for this, please retest and update the bug.

Comment 4 by sammiequon@chromium.org, Aug 31

Status: Fixed (was: Untriaged)
Project Member

Comment 5 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Aug 31

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-69; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-69 label, otherwise remove Merge-TBD label. Thanks.

Comment 6 by sammiequon@chromium.org, Aug 31

Labels: -Merge-TBD
►

Sign in to add a comment