New issue
Advanced search Search tips

Issue 863816 link

Starred by 2 users
Status: Fixed
Owner:
melandory@chromium.org
Closed: Aug 21
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 801985



Sign in to add a comment

Change the format of subscription request.

Project Member Reported by melandory@chromium.org, Jul 16 
The response of the subscription request has changed.

from private_topic_name to privateTopicName

this should be fixed in the code base.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/95bf7a9ecd882e71f1a8747675bfe165195c17a9

commit 95bf7a9ecd882e71f1a8747675bfe165195c17a9
Author: Tanja Gornak <melandory@chromium.org>
Date: Wed Jul 25 15:03:20 2018

Change in the response format from Per User Topic server.

The response format has changed. The CL implements the
change on the client.
* renaming "private_topic_name" property to "privateTopicName"

Bug:  863816 , 801985
Change-Id: I7e65b095c3764f73e928a0fa0a2fb5da461eb223
Reviewed-on: https://chromium-review.googlesource.com/1146725
Reviewed-by: Pavel Yatsuk <pavely@chromium.org>
Reviewed-by: Jan Krcal <jkrcal@chromium.org>
Commit-Queue: Tatiana Gornak <melandory@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577888}
[modify] https://crrev.com/95bf7a9ecd882e71f1a8747675bfe165195c17a9/components/invalidation/impl/per_user_topic_registration_manager_unittest.cc
[modify] https://crrev.com/95bf7a9ecd882e71f1a8747675bfe165195c17a9/components/invalidation/impl/per_user_topic_registration_request.cc
[modify] https://crrev.com/95bf7a9ecd882e71f1a8747675bfe165195c17a9/components/invalidation/impl/per_user_topic_registration_request_unittest.cc

Comment 2 by melandory@chromium.org, Aug 21

Status: Fixed (was: Started)
►

Sign in to add a comment