New issue
Advanced search Search tips

Issue 863802 link

Starred by 1 user
Status: Fixed
Owner:
l...@chromium.org
Closed: Oct 26
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : Text caret is not seen even if 'Start from key' text box is highlighted by default in 'Application' section of devtools.

Reported by rp...@etouch.net, Jul 16 
Version: 69.0.3493.0 (Official Build)Revision 7066e76287893adffd8bbd8c71c369cdc995c0c3-refs/branch-heads/3493@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.12.6,10.13.1,10.13.6)

What steps will reproduce the problem?
1. Launch chrome,navigate to NTP and again open new NTP
2. Open devtools and go to 'Application' section and double click to open 'IndexedDB' and then click on 'esp-newtab...'
3. Now click on 'items' and observe 'Start from key' text box 
 
Actual: Text caret is not seen even if 'Start from key' text box is highlighted by default
Expected: 
1. Text caret should be seen if 'Start from key' text box is highlighted.
2. Focus highlight shouldn't be seen on 'Start from key' text box by default

This is regression issue, broken in ‘M 69’ and will soon update other info :
Good build: 69.0.3479.0  (Revision: 571804).
Bad build: 69.0.3480.0 (Revision: 572081).
Actual_video.mp4
664 KB View Download
Expected_video.mp4
453 KB View Download

Comment 1 by rp...@etouch.net, Jul 16

Labels: hasbisect-per-revision
Owner: l...@chromium.org
Status: Assigned (was: Unconfirmed)
You are probably looking for a change made after 571966 (known good), but no later than 571967 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/6b46f6288b52141c87d8b68e1706f2246261b4c2..3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8

Suspect : https://chromium.googlesource.com/chromium/src/+/3078ce545f4c4ea7b39d3b3466f12ea330c6e6d8

From the CL above, assigning the issue to the concern owner 

@luoe- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : Issue is also seen on M 69 Dev Build 69.0.3486.0


Thanks!

Comment 2 by l...@chromium.org, Jul 16

Labels: -Pri-1 Pri-2
Thanks, I will take a look
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab896e2fbe248bc5402ca7a55896d2d88ab8e9eb

commit ab896e2fbe248bc5402ca7a55896d2d88ab8e9eb
Author: Erik Luo <luoe@chromium.org>
Date: Fri Oct 26 22:03:54 2018

DevTools: IndexedDB toolbar should use ToolbarInput

Inputs created by `UI.createInput()` lack toolbar-specific features
included by `new UI.ToolbarInput`.

This updates IndexedDB's key filter to use the ToolbarInput with
better focus logic, 'x' clear button, and consistency with others.

Screenshot: https://imgur.com/a/wi1NJde

Bug:  863802 
Change-Id: I3015e7dd061f32d4a6be414fdfa0928dc72667ed
Reviewed-on: https://chromium-review.googlesource.com/c/1294723
Commit-Queue: Erik Luo <luoe@chromium.org>
Reviewed-by: Joel Einbinder <einbinder@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603209}
[modify] https://crrev.com/ab896e2fbe248bc5402ca7a55896d2d88ab8e9eb/third_party/blink/renderer/devtools/front_end/resources/IndexedDBViews.js

Comment 4 by l...@chromium.org, Oct 26

Status: Fixed (was: Assigned)
►

Sign in to add a comment