ML Service: Have D-Bus start ML Service on-demand |
||
Issue descriptionInstead of starting ML Service automatically, we should only start it when first called. D-Bus has a mechanism for it.
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2c082ada82ae0442e4241dcac92bc462a82a03e6 commit 2c082ada82ae0442e4241dcac92bc462a82a03e6 Author: Andrew Moylan <amoylan@chromium.org> Date: Mon Aug 06 04:13:04 2018 ML Service D-Bus client: Don't WaitForServiceToBeAvailable ML Service is being configured to launch automatically via D-Bus service activation (crrev.com/c/1163227 and crrev.com/c/1163228), instead of launching at boot time. Therefore, we won't need to WaitForServiceToBeAvailable any more. Tested by: Test build with CrOS CLs above & a modified Chrome that calls ML Service a few times. Bug: 863781 Change-Id: I508ee505705de14332b1cdf4e5b0b29c04937c7b Reviewed-on: https://chromium-review.googlesource.com/1163229 Reviewed-by: Dan Erat <derat@chromium.org> Commit-Queue: Andrew Moylan <amoylan@chromium.org> Cr-Commit-Position: refs/heads/master@{#580800} [modify] https://crrev.com/2c082ada82ae0442e4241dcac92bc462a82a03e6/chromeos/dbus/machine_learning_client.cc
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/6d0ebf96f5e1ffdd19761e734e5fb5262deb2482 commit 6d0ebf96f5e1ffdd19761e734e5fb5262deb2482 Author: Andrew Moylan <amoylan@chromium.org> Date: Mon Aug 06 09:44:54 2018 ml: Set up D-Bus service activation * Add a D-Bus service activation config that uses upstart to launch ML Service. * Update the ML Service upstart config to not automatically launch during boot, and to wait for ML Service to register its D-Bus name before transitioning to 'started' state. BUG= chromium:863781 TEST=Ran together with locally modified Chrome that calls ML Service. Change-Id: Iab5a9140c86ad8184dec1f09a53a0edfff524729 Reviewed-on: https://chromium-review.googlesource.com/1163228 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [add] https://crrev.com/6d0ebf96f5e1ffdd19761e734e5fb5262deb2482/ml/dbus/org.chromium.MachineLearning.service [modify] https://crrev.com/6d0ebf96f5e1ffdd19761e734e5fb5262deb2482/ml/init/ml-service.conf
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/91a43703e489d1089bd1e838a92dfbcb232ea223 commit 91a43703e489d1089bd1e838a92dfbcb232ea223 Author: Andrew Moylan <amoylan@chromium.org> Date: Mon Aug 06 17:04:42 2018 chromeos-base/ml: Install D-Bus service activation config Install D-Bus service activation config file so that ML Service can be started on-demand instead of at startup time. CQ-DEPEND=CL:1163228 BUG= chromium:863781 TEST=Ran together with locally modified Chrome that calls ML Service. Change-Id: I2180cd3dc6350ca0895e80b0335cf16f7f02421e Reviewed-on: https://chromium-review.googlesource.com/1163227 Commit-Ready: Andrew Moylan <amoylan@chromium.org> Tested-by: Andrew Moylan <amoylan@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/91a43703e489d1089bd1e838a92dfbcb232ea223/chromeos-base/ml/ml-9999.ebuild
,
Aug 30
|
||
►
Sign in to add a comment |
||
Comment 1 by amoylan@chromium.org
, Jul 16