New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863780 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 16
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature

Blocked on:
issue 863781

Blocking:
issue 782499


Participants' hotlists:
ML-Service


Sign in to add a comment

ML Service: Enable ML service by default

Project Member Reported by amoylan@chromium.org, Jul 16

Issue description

Per rkc, we should get ML Service enabled by default in CrOS. We can just use a Chrome flag (later controlled via Finch) to control whether the feature actually gets used or not.

1. Make the ML Service only start on-demand (D-Bus can start it for us).
2. Set USE=ml_service by default.
 
Blockedon: 863781
Cc: r...@chromium.org
Cc: amoylan@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/c213662970942a44f5cb2f69287555601e744a2a

commit c213662970942a44f5cb2f69287555601e744a2a
Author: Michael Martis <martis@chromium.org>
Date: Mon Sep 03 09:20:49 2018

sci-libs/tensorflow: Use TF lite by default.

Update per-package USE flags to specify a minimal (i.e. TF lite
only) build of sci-libs/tensorflow by default.

This is done primarily to save disk space (TF lite is ~1MB, TF
is 10s of MBs).

BUG= chromium:863780 
TEST=emerge-chell tensorflow

Change-Id: I3c29306f21261da9d86087ce16ebee1f77763122
Reviewed-on: https://chromium-review.googlesource.com/1198803
Commit-Ready: Michael Martis <martis@chromium.org>
Tested-by: Michael Martis <martis@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c213662970942a44f5cb2f69287555601e744a2a/profiles/targets/chromeos/package.use

Project Member

Comment 5 by bugdroid1@chromium.org, Sep 26

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/eclass-overlay/+/2487b54a23e982d72e8dfcedfc72231c0c26f751

commit 2487b54a23e982d72e8dfcedfc72231c0c26f751
Author: Andrew Moylan <amoylan@chromium.org>
Date: Wed Sep 26 17:32:45 2018

eclass-overlay: Remove chronos from ml-service gid

It isn't needed.

TEST=Exercised ML Service with a locally modified Chrome.
BUG= chromium:863780 

Change-Id: I7e31b988664b077bf3fa221c068b1a34d799ab1c
Reviewed-on: https://chromium-review.googlesource.com/1239819
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/2487b54a23e982d72e8dfcedfc72231c0c26f751/profiles/base/accounts/group/ml-service

Components: UI>ML>Service
Blocking: 782499
Labels: OS-Chrome
Project Member

Comment 9 by bugdroid1@chromium.org, Nov 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/28e7c1f8f7a225aa57e96cab5cdda59474853276

commit 28e7c1f8f7a225aa57e96cab5cdda59474853276
Author: Andrew Moylan <amoylan@chromium.org>
Date: Wed Nov 07 14:34:48 2018

make.defaults: Enable USE=ml_service by default

Enable ml_service on all boards except embedded/minimal.

Startup impact:
The daemon launches on-demand, not at startup. There are no callers yet.

rootfs impact: 1.7 MB, mainly from:
0.5 MB ML Service binary
1.2 MB shared libtensorflow_lite.so

BUG= chromium:863780 
TEST=build_image on a board=coral
CQ-DEPEND=CL:1234074

Change-Id: I4941c9056338f4bb124465cda0c93cb78417e232
Reviewed-on: https://chromium-review.googlesource.com/1237774
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Andrew Moylan <amoylan@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/28e7c1f8f7a225aa57e96cab5cdda59474853276/profiles/features/minimal/make.defaults
[modify] https://crrev.com/28e7c1f8f7a225aa57e96cab5cdda59474853276/profiles/targets/chromeos/make.defaults
[modify] https://crrev.com/28e7c1f8f7a225aa57e96cab5cdda59474853276/profiles/features/embedded/make.defaults

Cc: pmalani@chromium.org alanlxl@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment