New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863768 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 713345
issue 877643



Sign in to add a comment

Create script that fetches all the timing data files & updates all sharding for all perf builders

Project Member Reported by nednguyen@chromium.org, Jul 15

Issue description

To ease the job of updating the perf sharding, we should make a a simple script that fetches all the timing data files & updates all sharding for all perf builders. e.g:

./tools/perf/update_all_perf_shardings  will automatically fetch all new timing data & update the sharding for each shard
 
Blocking: 713345
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2beca044140af06879fc3aebc42ff2daa5412d8f

commit 2beca044140af06879fc3aebc42ff2daa5412d8f
Author: nednguyen <nednguyen@google.com>
Date: Mon Jul 16 14:59:58 2018

Update retrieve_story_timing script to round the time duration and update the setup instruction

NOTRY=true
TBR=eyaich@chromium.org

Bug: 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I942eb00c9a4c5b0c4bb5b370f845b3d20cd97368
Reviewed-on: https://chromium-review.googlesource.com/1138397
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#575264}
[modify] https://crrev.com/2beca044140af06879fc3aebc42ff2daa5412d8f/tools/perf/core/retrieve_story_timing.py

Components: Speed>Benchmarks>Waterfall
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fa6907a2b9d4a5c818f6fe38c2ca9e3a47568597

commit fa6907a2b9d4a5c818f6fe38c2ca9e3a47568597
Author: Ned Nguyen <nednguyen@google.com>
Date: Sat Jul 28 20:54:30 2018

Refactor retrieve_story_timing's key query procedures into separate methods

NOTRY=true  # this script has no test
TBR=eyaich@chromium.org

Bug: 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I33eb97b5403095e2ec208f03589b49db9acef4f4
Reviewed-on: https://chromium-review.googlesource.com/1154322
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#578936}
[modify] https://crrev.com/fa6907a2b9d4a5c818f6fe38c2ca9e3a47568597/tools/perf/core/retrieve_story_timing.py

Project Member

Comment 5 by bugdroid1@chromium.org, Aug 2

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/050128c610a2d43dad58a59125bb83986489f293

commit 050128c610a2d43dad58a59125bb83986489f293
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 02 13:53:05 2018

Simplify & improve the effciency of SQL query of test timing data

This CL also rerun the query for 'android-go-perf' with:

./tools/perf/core/retrieve_story_timing.py -c 'android-go-perf'  --output-file=tools/perf/core/shard_maps/timing_data/android_go_timing.json

Bug: 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: Icfc132854aa83d35a9e27cbd5dfc42aeae5b3361
Reviewed-on: https://chromium-review.googlesource.com/1158966
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#580156}
[modify] https://crrev.com/050128c610a2d43dad58a59125bb83986489f293/tools/perf/core/retrieve_story_timing.py
[modify] https://crrev.com/050128c610a2d43dad58a59125bb83986489f293/tools/perf/core/shard_maps/timing_data/android_go_timing.json

Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8c125d449f30cb622e0f8f4b919ad45b4b05bbb9

commit 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 09 15:07:32 2018

Add perf/core/bot_platforms.py file that contain metadata about all perf builders

Bug:871746,863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8
Reviewed-on: https://chromium-review.googlesource.com/1169127
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[add] https://crrev.com/8c125d449f30cb622e0f8f4b919ad45b4b05bbb9/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/8c125d449f30cb622e0f8f4b919ad45b4b05bbb9/tools/perf/core/perf_json_config_validator.py

Project Member

Comment 7 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a55613fbaa32bcef500fedb60c8555bcf70877c9

commit a55613fbaa32bcef500fedb60c8555bcf70877c9
Author: Andrii Shyshkalov <tandrii@chromium.org>
Date: Thu Aug 09 19:14:30 2018

Revert "Add perf/core/bot_platforms.py file that contain metadata about all perf builders"

This reverts commit 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9.

Reason for revert: Due to Gerrit outage  http://crbug.com/872722 , we are reverting this CL. Please, re-land it after all clear is given. If you have questions, please ask on the bug. Sorry for the inconvenience.

Original change's description:
> Add perf/core/bot_platforms.py file that contain metadata about all perf builders
> 
> Bug:871746,863768
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8
> Reviewed-on: https://chromium-review.googlesource.com/1169127
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>

TBR=perezju@chromium.org,nednguyen@google.com

Change-Id: Ibbd2a2d28f9ba36967ce03fe2fa1c3331844cd18
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  871746 , 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Reviewed-on: https://chromium-review.googlesource.com/1169790
Reviewed-by: Andrii Shyshkalov <tandrii@chromium.org>

[delete] https://crrev.com/052af253a58d9855eb88907243e053b80951afcd/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/a55613fbaa32bcef500fedb60c8555bcf70877c9/tools/perf/core/perf_json_config_validator.py

Project Member

Comment 8 by bugdroid1@chromium.org, Aug 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa

commit d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa
Author: Ned Nguyen <nednguyen@google.com>
Date: Thu Aug 09 21:34:46 2018

Reland "Add perf/core/bot_platforms.py file that contain metadata about all perf builders"

This is a reland of 8c125d449f30cb622e0f8f4b919ad45b4b05bbb9

Original change's description:
> Add perf/core/bot_platforms.py file that contain metadata about all perf builders
>
> Bug:871746,863768
> Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
> Change-Id: If2a9f5344d4226aa56b71dabf094cc49c5006bb8
> Reviewed-on: https://chromium-review.googlesource.com/1169127
> Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
> Commit-Queue: Ned Nguyen <nednguyen@google.com>

Bug:  871746 , 863768
Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi

TBR=perezju@chromium.org

Change-Id: Id3efcff245684cc55237a2a6c4c26d51e65fa797
Reviewed-on: https://chromium-review.googlesource.com/1169882
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#581900}
[add] https://crrev.com/d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/d15f1a77ae1633f9d7f33215684dc00ebb7ec3aa/tools/perf/core/perf_json_config_validator.py

Blocking: 877643
Cc: perezju@chromium.org jbudorick@google.com
Project Member

Comment 11 by bugdroid1@chromium.org, Aug 31

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2ceac4fbce25682e575e66b113a45945fbbf155

commit c2ceac4fbce25682e575e66b113a45945fbbf155
Author: nednguyen <nednguyen@google.com>
Date: Fri Aug 31 11:12:49 2018

Refactor generate_perf_sharding to enable fetch timing data & generate shard maps for all perf builder

To generate the shard map for all perf builders using existing timing data:
./tools/perf/generate_perf_sharding

To generate the shard map for a subset of perf builders using existing timing data:
./tools/perf/generate_perf_sharding -b android-go-perf win-10-perf

To fetch the lastest timing data of all perf builders & use those to generate the shard map for all perf builders:
./tools/perf/generate_perf_sharding -r

This also getting rid of timing debugging utility of generate_perf_sharding script to make it cleaner. Adding support back is future work.

Bug: 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I8c407609052e23c55b75a20b2d40a9f97e090688
Reviewed-on: https://chromium-review.googlesource.com/1188945
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#587988}
[modify] https://crrev.com/c2ceac4fbce25682e575e66b113a45945fbbf155/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/c2ceac4fbce25682e575e66b113a45945fbbf155/tools/perf/core/retrieve_story_timing.py
[modify] https://crrev.com/c2ceac4fbce25682e575e66b113a45945fbbf155/tools/perf/generate_perf_sharding

Project Member

Comment 12 by bugdroid1@chromium.org, Sep 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f789584a0cfe9196511431a5d89030287a628346

commit f789584a0cfe9196511431a5d89030287a628346
Author: nednguyen <nednguyen@google.com>
Date: Fri Sep 07 21:51:36 2018

Update location of benchmark timing files & shard map files

Previously, the benchmark timing files & shard map files are manually named. This
CL simplifies all of them to be based on the builder names. This simplifies
the implementation of tools/perf/core/bot_platforms.py file.

This should be a pure refactoring & has no visible effect on how we schedule tests

This is a follow up of Juan's comment in https://chromium-review.googlesource.com/c/chromium/src/+/1188945/6/tools/perf/core/bot_platforms.py#85

Bug:863768

Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I7aa08e10978f54b7f2b15759d20d64a9c7bd8533
Reviewed-on: https://chromium-review.googlesource.com/1213317
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#589676}
[modify] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/testing/buildbot/chromium.perf.fyi.json
[modify] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/testing/buildbot/chromium.perf.json
[modify] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/perf_data_generator.py
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/android-go-perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/android-nexus5x-perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/android_nexus5_perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/linux-perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/android-go-perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/android-nexus5x-perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/android_nexus5_perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/android_nexus5x_webview_perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/android_nexus6_webview_perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/linux-perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/mac-10_12_laptop_low_end-perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/mac-10_13_laptop_high_end-perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/win-10-perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/win_7_nvidia_gpu_perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/timing_data/win_7_perf_timing.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/win-10-perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
[rename] https://crrev.com/f789584a0cfe9196511431a5d89030287a628346/tools/perf/core/shard_maps/win_7_perf_map.json

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2ec67f49e61fcb6d83b7744f2f957cc88181250e

commit 2ec67f49e61fcb6d83b7744f2f957cc88181250e
Author: Ned Nguyen <nednguyen@google.com>
Date: Sat Sep 08 09:02:44 2018

Reshard perf benchmarks to include startup.mobile benchmark

** PERF SHERIFF: this CL may cause perf graphs to regress but it's expected **


Note that this CL also fixes a bug in sharding algorithm which makes the sharding map generation not very deterministic
(see changes to tools/perf/core/sharding_map_generator.py).

Step to generate the json files:
remove 'startup.mobile' from UNSCHEDULED_TELEMETRY_BENCHMARKS, then run:
$ ./tools/perf/generate_perf_sharding -r
$ ./tools/perf/generate_perf_data

TBR=jbudorick@chromium.org, perezju@chromium.org

Bug:  880091 ,863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I71a2622f979d451eba53ed89f567b82d6ce549e7
Reviewed-on: https://chromium-review.googlesource.com/1214758
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#589776}
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/benchmark.csv
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/bot_platforms.py
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/android-go-perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/android-nexus5x-perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/android_nexus5_perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/linux-perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/android-go-perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/android-nexus5x-perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/android_nexus5_perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/android_nexus5x_webview_perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/android_nexus6_webview_perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/linux-perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/mac-10_12_laptop_low_end-perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/mac-10_13_laptop_high_end-perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/win-10-perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/win_7_nvidia_gpu_perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/timing_data/win_7_perf_timing.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/win-10-perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/shard_maps/win_7_perf_map.json
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/sharding_map_generator.py
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/core/undocumented_benchmarks.py
[modify] https://crrev.com/2ec67f49e61fcb6d83b7744f2f957cc88181250e/tools/perf/generate_perf_sharding

Project Member

Comment 14 by bugdroid1@chromium.org, Sep 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c68b185fd42da06b22ac8be6bad1538386adde9b

commit c68b185fd42da06b22ac8be6bad1538386adde9b
Author: Ned Nguyen <nednguyen@google.com>
Date: Sun Sep 09 13:28:10 2018

Fix a bug about ordering of stories in generate_perf_sharding

** PERF SHERIFF: this CL may cause perf graphs to regress but it's expected **


Previously, there is a big discrepancy between the predicted timing of
generate_perf_sharding's output & the actual timing. For details, see:
* Predicted timing: https://logs.chromium.org/v/?s=chrome%2Fbuildbucket%2Fcr-buildbucket.appspot.com%2F8935880309586521856%2F%2B%2FBenchmarks_Shard_Map_ca71405d-0fb3-4722-a815-af11b3f08318
* Actual timing: https://ci.chromium.org/p/chrome/builders/luci.chrome.ci/android-go-perf/182

After debugging, I found the root cause of this discrepancy is due to the order
of stories input in generate_perf_sharding isn't the same of the order of stories
which are meant to be run. This is because we mistakenly sort the list of
story names in benchmark_utils.GetBenchmarkStoryNames(..) method.

This CL fixes it by removing the sorting logic. It also add unittest to ensure
that the order of story names return by the method always matches with the
order of stories to be run.

Bug:863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I769ff867b0ee10a9afafafebbd4cb2621e0ab93f

TBR=jbudorick@chromium.org, perezju@chromium.org
NOTRY=true # content_browsertests flake

Change-Id: I769ff867b0ee10a9afafafebbd4cb2621e0ab93f
Reviewed-on: https://chromium-review.googlesource.com/1214806
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#589801}
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/benchmark_utils.py
[add] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/benchmark_utils_unittest.py
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/android-go-perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/android-nexus5x-perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/android_nexus5_perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/linux-perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/win-10-perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
[modify] https://crrev.com/c68b185fd42da06b22ac8be6bad1538386adde9b/tools/perf/core/shard_maps/win_7_perf_map.json

Project Member

Comment 15 by bugdroid1@chromium.org, Sep 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8e62b5bc9999b53377aa4f99c234c6c86e03774f

commit 8e62b5bc9999b53377aa4f99c234c6c86e03774f
Author: Ned Nguyen <nednguyen@google.com>
Date: Wed Sep 12 23:04:54 2018

Initilize non zero values for benchmark stories that don't have existing timing data

Bug: 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I9733b1f051ffe9fa8b64d14e15704674da0b363a
Reviewed-on: https://chromium-review.googlesource.com/1199602
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590848}
[modify] https://crrev.com/8e62b5bc9999b53377aa4f99c234c6c86e03774f/tools/perf/core/sharding_map_generator.py
[modify] https://crrev.com/8e62b5bc9999b53377aa4f99c234c6c86e03774f/tools/perf/core/sharding_map_generator_unittest.py

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1

commit 36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1
Author: Ned Nguyen <nednguyen@google.com>
Date: Mon Sep 24 07:47:04 2018

Include more detailed shard's timing prediction in generated shard maps

** PERF SHERIFF: this CL may cause perf graphs to regress but it's expected **


Includes shard's timing prediction help making debugging the sharding algorithm's performance easier.

This CL also regenerate the shards to include the shards' predicted timing.


Bug: 863768
Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi
Change-Id: I084891d1d0fe05a555b88f692a65966bc31b740b
No-Try: true # ios simulator flake
Reviewed-on: https://chromium-review.googlesource.com/1214805
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#593485}
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/android-go-perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/android-nexus5x-perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/android_nexus5_perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/android_nexus5x_webview_perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/android_nexus6_webview_perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/linux-perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/mac-10_12_laptop_low_end-perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/mac-10_13_laptop_high_end-perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/android-go-perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/android-nexus5x-perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/android_nexus5_perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/android_nexus5x_webview_perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/android_nexus6_webview_perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/linux-perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/mac-10_12_laptop_low_end-perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/mac-10_13_laptop_high_end-perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/win-10-perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/win_7_nvidia_gpu_perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/timing_data/win_7_perf_timing.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/win-10-perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/win_7_nvidia_gpu_perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/shard_maps/win_7_perf_map.json
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/core/sharding_map_generator.py
[modify] https://crrev.com/36a634af0ee3fd4ffa9ee7cf210dbda6bdad1bb1/tools/perf/generate_perf_sharding

Sign in to add a comment