New issue
Advanced search Search tips

Issue 863764 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jul 21
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in media::AudioRendererImpl::CurrentMediaTime

Project Member Reported by ClusterFuzz, Jul 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=5873980091924480

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000038
Crash State:
  media::AudioRendererImpl::CurrentMediaTime
  media::PipelineImpl::GetMediaTime
  media::WebMediaPlayerImpl::CurrentTime
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=551887:551903

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5873980091924480

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 15

Labels: OS-Linux
Project Member

Comment 2 by ClusterFuzz, Jul 15

Components: Internals>Media
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 3 by ClusterFuzz, Jul 15

Labels: Test-Predator-Auto-Owner
Owner: tmathmeyer@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/da82b60044d96bf76bf67f6d85bd8c993db82f8f (Replace StreamStatusChanged callback with async track switching).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Status: Started (was: Assigned)
Labels: M-69
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d5e8a2d5661df3ad82f54b455d6159e7e8fd3a7

commit 6d5e8a2d5661df3ad82f54b455d6159e7e8fd3a7
Author: Ted Meyer <tmathmeyer@chromium.org>
Date: Sat Jul 21 01:07:10 2018

Fix race condition:

There is a race condition between AudioRenderer::Reinitialize and

audio_clock_ to null. Sometimes webmediaplayerimpl can request a
timestamp from the pipeline->renderer->audio_renderer which could race
with an ongoing track switch doing a reinitialize.

AudioRenderer: :CurrentMediaTime where reinitialize was setting
Bug:  863764 
Change-Id: I6d6a32be37c42bde37d1d02353e3f43a58ab4e66
Reviewed-on: https://chromium-review.googlesource.com/1142899
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Commit-Queue: Ted Meyer <tmathmeyer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577050}
[modify] https://crrev.com/6d5e8a2d5661df3ad82f54b455d6159e7e8fd3a7/media/renderers/renderer_impl.cc
[modify] https://crrev.com/6d5e8a2d5661df3ad82f54b455d6159e7e8fd3a7/media/renderers/renderer_impl.h

Status: Fixed (was: Started)
Project Member

Comment 8 by ClusterFuzz, Jul 21

ClusterFuzz has detected this issue as fixed in range 577045:577050.

Detailed report: https://clusterfuzz.com/testcase?key=5873980091924480

Fuzzer: inferno_twister
Job Type: mac_asan_content_shell
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000038
Crash State:
  media::AudioRendererImpl::CurrentMediaTime
  media::PipelineImpl::GetMediaTime
  media::WebMediaPlayerImpl::CurrentTime
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=551887:551903
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_content_shell&range=577045:577050

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=5873980091924480

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 9 by ClusterFuzz, Jul 21

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 5873980091924480 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment