New issue
Advanced search Search tips

Issue 863762 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Rename SSL mentions to TLS.

Reported by eyreland...@gmail.com, Jul 15

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/65.0.3325.183 Safari/537.36 Vivaldi/1.96.1147.52

Steps to reproduce the problem:
vivaldi://components/

RENAME "SSL Error Assistant" to "TLS Error Assistant"

What is the expected behavior?
The SSL Standard has been superseded by TLS. 

What went wrong?
Nothing, just the UI not being truthful about the Crypo subsystem being used. 

Did this work before? N/A 

Chrome version: 65.0.3325.183  Channel: stable
OS Version: Unbutu
Flash Version: NA
 
Labels: Needs-Milestone
Cc: susan.boorgula@chromium.org
Components: Internals>Network>SSL
Labels: Triaged-ET
eyreland.mp@ Thanks for the issue.

Adding 'Internals>Network>SSL' component and request the team to look into the issue and help in further triaging.

Thanks..
Labels: Team-Security-UX
This bug is about Vivaldi, but the string exists in Chrome too. The SSL vs TLS naming confusing is an unfortunate consequence of IETF silliness way back in the day. I'll let Enamel folks decide what they want to do here. (Certificate Error Assistant would sidestep this. Such errors apply to QUIC too.) Though this particular instance seems not particularly important as it's barely a user-visible string.
davidben@ - Gentle ping...!!
Please provide any further input on the issue...!!
Thanks...!!
Comment #4 is sufficient.
Components: -UI -Internals>Network>SSL UI>Browser>Interstitials
So I no longer get mail about this bug, switching labels. This is used in the interstitial logic owned by Enamel, not the low-level TLS logic owned by the net stack. This is a UI question.
Cc: carlosil@chromium.org meacer@google.com livvielin@chromium.org cthomp@chromium.org
Status: Available (was: Unconfirmed)
Summary: Rename SSL mentions to TLS. (was: vivaldi://components/ : RENAME "SSL Error Assistant" to "TLS Error Assistant")
Explicitly adding more Enamel folks (including myself) for discussion. Seems like having a bug specifically for the string in chrome://components is not the right approach. Should we try to rename all mentions of SSL in Chrome's code to TLS? (or alternatively all mentions in user visible strings?) This doesn't seem like a high priority fix to me, but what are people's thoughts? Has this discussion happened before?
Labels: -Pri-2 Pri-3
"SSL Error Assistant" was indeed named "TLS Error Assistant" in the beginning, but we changed it back to SSL to be consistent with the rest of the codebase: https://codereview.chromium.org/2641423002

I don't mind changing the user visible text of the component to "SSL/TLS Error Assistant" or something similar, but I don't think it's a good use of time changing every mention of SSL.
Cc: -meacer@google.com mea...@chromium.org
Project Member

Comment 13 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8806a5c1dd67a5ef6e131f1ffad4cbadf3e29586

commit 8806a5c1dd67a5ef6e131f1ffad4cbadf3e29586
Author: Mustafa Emre Acer <meacer@chromium.org>
Date: Wed Aug 22 18:39:58 2018

Change the user visible string for SSL Error Assistant

It's "Certificate Error Assistant" now.

Bug:  863762 
Change-Id: I1b853703df5f2f630cd4300c2c77a417028ab7d7
Reviewed-on: https://chromium-review.googlesource.com/1180424
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Joshua Pawlicki <waffles@chromium.org>
Commit-Queue: Mustafa Emre Acer <meacer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585182}
[modify] https://crrev.com/8806a5c1dd67a5ef6e131f1ffad4cbadf3e29586/chrome/browser/component_updater/ssl_error_assistant_component_installer.cc

Status: Fixed (was: Available)
Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Verified the fix on Ubuntu 17.10 using Chrome version #70.0.3532.0 as per the comment #13.
Attaching screen shot for reference.
Observed that the name has changed to "Certificate Error Assistant"
Hence, the fix is working as expected. 
Adding the verified labels.
Note: Able to reproduce the issue on chrome version with out fix.

Thanks...!!



863762_CL Verification.png
815 KB View Download

Sign in to add a comment