New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863752 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug



Sign in to add a comment

Null-dereference READ in blink::CanvasRenderingContextHost::GetOrCreateCanvasResourceProvider

Project Member Reported by ClusterFuzz, Jul 15

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=6710872832212992

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  blink::CanvasRenderingContextHost::GetOrCreateCanvasResourceProvider
  blink::WebGLRenderingContextBase::PaintRenderingResultsToCanvas
  blink::HTMLCanvasElement::ToStaticBitmapImage
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=574610:574625

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6710872832212992

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 15

Components: Blink>Canvas Blink>WebGL
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Jul 15

Labels: Test-Predator-Auto-Owner
Owner: junov@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://chromium.googlesource.com/chromium/src/+/f8b8872f2080130c2b5bdf026f32f46aad7598da (Refactor canvas code to centralize CanvasResourceProvider ownership).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Cc: junov@chromium.org
Owner: fs...@chromium.org
Fernando, could you take this from Justin?

Cc: -junov@chromium.org fs...@chromium.org
Owner: junov@chromium.org
It's exactly what junov is working on these days. :)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b03f5cf6940eebd338f860280e77a586eee7ea47

commit b03f5cf6940eebd338f860280e77a586eee7ea47
Author: Justin Novosad <junov@chromium.org>
Date: Tue Jul 17 16:37:40 2018

Add null checks in CanvasResourceProvider::Create

Null ptr checks were missing on context_provider_wrapper, resulting
in crashes after a GPU context loss.

BUG= 863752 

Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I4b6f1fc394deb3f5567fee1da6f74b66aa7db79d
Reviewed-on: https://chromium-review.googlesource.com/1140282
Reviewed-by: Fernando Serboncini <fserb@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575674}
[modify] https://crrev.com/b03f5cf6940eebd338f860280e77a586eee7ea47/third_party/blink/renderer/platform/graphics/canvas_resource_provider.cc

Status: Fixed (was: Assigned)
Donerino!
Project Member

Comment 7 by ClusterFuzz, Jul 18

ClusterFuzz has detected this issue as fixed in range 575663:575678.

Detailed report: https://clusterfuzz.com/testcase?key=6710872832212992

Fuzzer: inferno_twister
Job Type: mac_asan_chrome
Platform Id: mac

Crash Type: Null-dereference READ
Crash Address: 0x000000000008
Crash State:
  blink::CanvasRenderingContextHost::GetOrCreateCanvasResourceProvider
  blink::WebGLRenderingContextBase::PaintRenderingResultsToCanvas
  blink::HTMLCanvasElement::ToStaticBitmapImage
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=574610:574625
Fixed: https://clusterfuzz.com/revisions?job=mac_asan_chrome&range=575663:575678

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=6710872832212992

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 8 by ClusterFuzz, Jul 18

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 6710872832212992 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment