New issue
Advanced search Search tips

Issue 863741 link

Starred by 3 users
Status: Fixed
Owner:
ericwilligers@chromium.org
Closed: Aug 6
Cc:
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

shape-rendering should serialize in lower case

Project Member Reported by ericwilligers@chromium.org, Jul 15 
https://drafts.csswg.org/cssom/#serializing-css-values

"To serialize a CSS component value depends on the component, as follows:
keyword
The keyword converted to ASCII lowercase."

http://bit.ly/2upS0OT
shows that Firefox and Safari serialize shape-rendering 'crispEdges' as 'crispedges', and Edge does not support it.

It also shows 4 other properties that Firefox serializes in lower case, but Blink and Safari serialize in mixed case.

Comment 1 by schenney@chromium.org, Jul 16

Components: -Blink>SVG Blink>CSS

Comment 2 by e...@chromium.org, Jul 23

Status: Available (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c40c29825c50bef10e613316494c4d98a6b07773

commit c40c29825c50bef10e613316494c4d98a6b07773
Author: Eric Willigers <ericwilligers@chromium.org>
Date: Mon Aug 06 04:46:34 2018

CSS: serialize shape-rendering keywords in lower case

Keywords for the following properties now serialize in lower case:
- color-rendering
- image-rendering
- shape-rendering
- text-rendering


https://drafts.csswg.org/cssom/#serializing-css-values

"To serialize a CSS component value depends on the component, as follows:
keyword
The keyword converted to ASCII lowercase."

Firefox and Edge already serialize such properties in lower case.

BUG= 863741 

Change-Id: Idca31224b0f0186d76ddca814ffb913d46c8a4f9
Reviewed-on: https://chromium-review.googlesource.com/1163047
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580802}
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/animations/svg/svg-presentation-attribute-animation.html
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/color-rendering.html
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/shape-rendering.html
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/external/wpt/css/css-typed-om/the-stylepropertymap/properties/text-rendering.html
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/accumulation-per-property-expected.txt
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/addition-per-property-expected.txt
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/external/wpt/web-animations/animation-model/animation-types/interpolation-per-property-expected.txt
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/fast/css/parsing-text-rendering-expected.txt
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/WebKit/LayoutTests/fast/css/resources/parsing-text-rendering.js
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/blink/renderer/core/css/CSSProperties.json5
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/blink/renderer/core/css/CSSValueKeywords.json5
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/blink/renderer/core/css/SVGCSSValueKeywords.json5
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/blink/renderer/core/css/css_primitive_value_mappings.h
[modify] https://crrev.com/c40c29825c50bef10e613316494c4d98a6b07773/third_party/blink/renderer/core/css/parser/css_parser_fast_paths.cc

Comment 4 by ericwilligers@chromium.org, Aug 6

Owner: ericwilligers@chromium.org
Status: Fixed (was: Available)
►

Sign in to add a comment