New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863710 link

Starred by 1 user
Status: Verified
Owner:
█ apaci...@chromium.org
no longer active
Closed: Jul 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[PIP] Window appears back in the initial default position when PiP'd multiple times

Project Member Reported by apaci...@chromium.org, Jul 14 
What steps will reproduce the problem?
(1) Go to page with two videos[1]
(2) PiP one video. Move it around the monitor screen.
(3) PiP second video. Notice it appears back in the bottom right of the monitor (initial position) rather than where the PiP window was left.

[1] https://japacible.github.io/sandbox/index.html

What is the expected result?
Video updates in-window in the same position.

What happens instead?
Window appears in bottom right.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1bbb4fbd7d53fb742474bb05a001cfa3b4ba00a1

commit 1bbb4fbd7d53fb742474bb05a001cfa3b4ba00a1
Author: Jennifer Apacible <apacible@chromium.org>
Date: Tue Jul 17 00:07:56 2018

[Picture in Picture] Track window positioning when updating bounds.

Currently, entering Picture-in-Picture multiple times from the same page
will reset the location of the window to the default location, or the
bottom right of the screen.

When the window has been moved, the user has indicated they want the
window positioned elsewhere. This change keeps the window origin, or
the top left corner coordinates, when the window bounds are updated.

Bug:  863710 
Change-Id: I0cf0a23b549ef52bf06c78e28af6753e4735f186
Reviewed-on: https://chromium-review.googlesource.com/1137837
Commit-Queue: apacible <apacible@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575489}
[modify] https://crrev.com/1bbb4fbd7d53fb742474bb05a001cfa3b4ba00a1/chrome/browser/ui/views/overlay/overlay_window_views.cc
[modify] https://crrev.com/1bbb4fbd7d53fb742474bb05a001cfa3b4ba00a1/chrome/browser/ui/views/overlay/overlay_window_views.h

Comment 2 by susan.boorgula@chromium.org, Jul 17

Labels: Needs-Feedback
Able to reproduce this issue on  Windows 10 and Mac OS 10.13.3 on the build without fix 69.0.3486.0 and the issue is fixed on the latest Canary 69.0.3494.0 as per the original comment.
Note: Unable to verify the fix on Ubuntu 14.04 on latest canary 69.0.3494.0, as didn't observed "Picture-in-picture" option to click on it.

Attached is the screen cast of Windows and Linux behaviors.

apacible@ Request you to please check and help us in verifying the fix on Linux.

Thanks...
863710_Linux.ogv
894 KB View Download
863710-Windows.mp4
1.4 MB View Download

Comment 3 by mlamouri@chromium.org, Jul 27

Status: Verified (was: Started)
Most likely the reason why it did not work on Linux is because a feature (new video compositing pipeline) is running 50/50 and required for Picture-in-Picture. It would most likely just worked if you enable chrome://flags/#enable-surfaces-for-videos

Thanks for verifying!
►

Sign in to add a comment