New issue
Advanced search Search tips

Issue 863706 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner: ----
Closed: Jul 16
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Chrome fails to detect XFCE desktop environment, therefore not using correct password store

Reported by mich...@fds-team.de, Jul 14

Issue description

Chrome Version (from the about:version page): 67.0.3396.99 
Is this the most recent version: yes (stable)
OS + version: Debian buster
CPU architecture (32-bit / 64-bit): 64-bit
Window manager: XFCE
URLs (if relevant):
Behavior in Linux Firefox:
Behavior in Windows Chrome (if you have access to it):

What steps will reproduce the problem?
(1) Start chromium with --v=1

What is the expected result?
Chromium should print the following log lines:
[5867:5867:0714/211544.354457:VERBOSE1:key_storage_util_linux.cc(53)] Password storage detected desktop environment: XFCE
[5867:5867:0714/211544.354490:VERBOSE1:password_store_factory.cc(226)] Trying libsecret for password storage.
[5867:5867:0714/211544.362965:VERBOSE1:password_store_factory.cc(229)] Using libsecret keyring for password storage.


What happens instead?
Chromium does not detect XFCE and prints instead:
[8849:8849:0714/213137.931289:VERBOSE1:key_storage_util_linux.cc(53)] Password storage detected desktop environment: (unknown)
[8849:8849:0714/213137.931333:WARNING:password_store_factory.cc(253)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.

Please provide any additional information below. Attach a screenshot
and backtrace if possible.

I have created a fix for the problem and will upload it for code review.

 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b874ce1bff85d9fdbbc938411d12254fa453058a

commit b874ce1bff85d9fdbbc938411d12254fa453058a
Author: Michael Müller <michael@fds-team.de>
Date: Sun Jul 15 02:00:53 2018

Detect XFCE desktop environment using XDG_CURRENT_DESKTOP

So far XFCE was only detected using the DESKTOP_SESSION environment variable,
which is not sufficient on all systems. The variable might contain different
values like lightdm-xsession. This change adds support to detect XFCE using the
XDG_CURRENT_DESKTOP environment variable, like it is done for Gnome, KDE and
other desktop environments.

R=thomasanderson@chromium.org

Bug:  863706 
Change-Id: I30f8471a8e8fbea1d25c6b3586c9919d27d83e09
Reviewed-on: https://chromium-review.googlesource.com/1137814
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575170}
[modify] https://crrev.com/b874ce1bff85d9fdbbc938411d12254fa453058a/AUTHORS
[modify] https://crrev.com/b874ce1bff85d9fdbbc938411d12254fa453058a/base/nix/xdg_util.cc

Cc: thomasanderson@chromium.org vamshi.kommuri@chromium.org
Status: Untriaged (was: Unconfirmed)
We were unable to reproduce the issue on Ubuntu 14.04 and currently we do not have Debian to test and confirm the fix ... hence cc'ing thomasanderson@ for further action on this. Changing the status of the bug to Untriaged as the fix has landed.

Thanks!
Status: Fixed (was: Untriaged)

Sign in to add a comment