Issue 863702 link

Starred by 1 user

Issue metadata

Status:	Fixed
Owner:	█ apaci...@chromium.org no longer active
Closed:	Jul 17
Components:	Blink>Media>PictureInPicture
EstimatedDays:	----
NextAction:	----
OS:	Linux , Windows , Chrome , Mac
Pri:	3
Type:	Bug
Needs-Feedback

[PIP] Controls icons should be black

Project Member Reported by apaci...@chromium.org, Jul 14

Issue description

They are currently grey. The icons should be black with a white background.

Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/71f28dce523177ac12388a28c3d8c93a21073ba4

commit 71f28dce523177ac12388a28c3d8c93a21073ba4
Author: Jennifer Apacible <apacible@chromium.org>
Date: Mon Jul 16 17:48:24 2018

[Picture in Picture] Make media controls icon images black.

The background is kept white.

Bug:  863702 
Change-Id: Ia8d0f2bb8f9c1a0263c527906f076a1fa78f5823
Reviewed-on: https://chromium-review.googlesource.com/1137752
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575336}
[modify] https://crrev.com/71f28dce523177ac12388a28c3d8c93a21073ba4/chrome/browser/ui/views/overlay/overlay_window_views.cc

Comment 2 by apaci...@chromium.org, Jul 17

Status: Fixed (was: Assigned)

Comment 3 by viswa.karala@chromium.org, Jul 17

Labels: Needs-Feedback

Able to verify the fix on Latest chrome# 69.0.3494.0 using Mac 10.12.6 and Windows-10 with URL: https://japacible.github.io/sandbox/index.html by enabling #enable-picture-in-picture flag in chrome://flags, able to see media control icon black with white background. Unable to verify the fix on Ubuntu 14.04 on latest chrome# 69.0.3494.0, didn't observed "Picture-in-picture" option to check it. 

@Jennifer Apacible: Please find the attached screencast for your reference and help us in verifying the fix on Linux.

Thanks!