New issue
Advanced search Search tips

Issue 863682 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jul 24
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Bug



Sign in to add a comment

Direct-leak in es2::Program::defineUniform

Project Member Reported by ClusterFuzz, Jul 14

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4763495091142656

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  es2::Program::defineUniform
  es2::Program::linkUniforms
  es2::Program::link
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=495501:495528

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4763495091142656

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Jul 14

Components: Internals>GPU>SwiftShader
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Cc: kkaluri@chromium.org
Labels: M-68 Test-Predator-Wrong
Owner: capn@chromium.org
Status: Assigned (was: Untriaged)
Since it is related to swiftshader component, assigning it to the capn@ for further triage.
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 20

The following revision refers to this bug:
  https://swiftshader.googlesource.com/SwiftShader.git/+/0d8993c667c5a98e592d969bc4cdf87fdd886f17

commit 0d8993c667c5a98e592d969bc4cdf87fdd886f17
Author: Nicolas Capens <capn@google.com>
Date: Fri Jul 20 14:34:48 2018

Fix leaking uniforms.

We were leaking memory for uniforms that were previously defined but
don't have a location, e.g. structures.

This change also verifies that such uniforms have the same type in both
shaders. Also, simplify uniform lookup.

 Bug chromium:863682 

Change-Id: I468aace4df6f5329dc7bb9f33bf9bf533a743ae1
Reviewed-on: https://swiftshader-review.googlesource.com/19928
Tested-by: Nicolas Capens <nicolascapens@google.com>
Reviewed-by: Corentin Wallez <cwallez@google.com>

[modify] https://crrev.com/0d8993c667c5a98e592d969bc4cdf87fdd886f17/src/Common/Version.h
[modify] https://crrev.com/0d8993c667c5a98e592d969bc4cdf87fdd886f17/src/Main/Config.hpp
[modify] https://crrev.com/0d8993c667c5a98e592d969bc4cdf87fdd886f17/src/OpenGL/libGLESv2/Program.cpp
[modify] https://crrev.com/0d8993c667c5a98e592d969bc4cdf87fdd886f17/src/OpenGL/libGLESv2/Program.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f474981b29fe82217f2bc96031bed05c63ba1beb

commit f474981b29fe82217f2bc96031bed05c63ba1beb
Author: Nicolas Capens <capn@chromium.org>
Date: Tue Jul 24 11:46:45 2018

Roll SwiftShader 8fb6f6a..be5fe77

https://swiftshader.googlesource.com/SwiftShader.git/+log/8fb6f6a..be5fe77

BUG= chromium:863682 

TEST=bots

TBR=kbr@chromium.org

CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_chromium_cfi_rel_ng;luci.chromium.try:android_optional_gpu_tests_rel

Change-Id: Iaaea854a33e6367f192c0c554789994d681a8f2a
Reviewed-on: https://chromium-review.googlesource.com/1145222
Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: Nicolas Capens <capn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577484}
[modify] https://crrev.com/f474981b29fe82217f2bc96031bed05c63ba1beb/DEPS

Project Member

Comment 6 by ClusterFuzz, Jul 24

ClusterFuzz has detected this issue as fixed in range 577483:577485.

Detailed report: https://clusterfuzz.com/testcase?key=4763495091142656

Fuzzer: inferno_layout_test_unmodified
Job Type: linux_lsan_chrome_mp
Platform Id: linux

Crash Type: Direct-leak
Crash Address: 
Crash State:
  es2::Program::defineUniform
  es2::Program::linkUniforms
  es2::Program::link
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=495501:495528
Fixed: https://clusterfuzz.com/revisions?job=linux_lsan_chrome_mp&range=577483:577485

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4763495091142656

See https://github.com/google/clusterfuzz-tools for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Jul 24

Labels: ClusterFuzz-Verified
Status: Verified (was: Started)
ClusterFuzz testcase 4763495091142656 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment