New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863671 link

Starred by 2 users

Issue metadata

Status: WontFix
Owner:
Closed: Sep 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug



Sign in to add a comment

M69 Theme Sync Off fails

Reported by larrylac...@yahoo.com, Jul 14

Issue description

Chrome Version       : 69.0.3489.0
OS Version: 10.0
Other browsers tested: none - NA
M69 UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/69.0.3489.0 Safari/537.36

M67 UserAgentString: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/67.0.3396.99 Safari/537.36

What steps will reproduce the problem?
1. Open profile in M69 (canary), with settings sync all
2. Turn off sync themes, sync settings, leave the settings tab open
3. Open new tab, go Web Store, load theme, e.g. Slinky Glamour
https://chrome.google.com/webstore/detail/slinky-glamour/phcgjdgneipghoeikoeenifpknfkjpil?hl=en-US
4. Theme displays OK in M69
5. Open profile in M67 67.0.3396.0 (stable), has sync all, no theme
6. M67 session updates to theme - see screenshot

What is the expected result?
M67 does not receive synced theme

What happens instead of that?
M67 theme updates 

Additional information:
Once you close the M69 settings tab, with the updated sync theme setting,
or restart the M69 profile, the theme propagation stops.

In my test environment, my main profile was always open, in both M67 and M69
and I opened/closed the test profile in M67, M69 as needed.

M67 and M69 were running on the same device: Win10 laptop.

As this is relatively short lived failure case, latency only immediately after changing the sync settings for test, general impact is probably low.  There may be other sync settings latency issues.  This is the only one I encountered.




 
M69-themes-syncBlockFail.png
256 KB View Download
Labels: Needs-Triage-M69
Components: UI>Browser>Themes Services>Sync
Cc: viswa.karala@chromium.org
Labels: Triaged-ET M-69 Target-69 FoundIn-69 OS-Linux OS-Mac
Status: Untriaged (was: Unconfirmed)
Able to reproduce the issue on chrome reported version# 69.0.3489.0 and on latest chrome# 69.0.3496.0 using Mac 10.12.6, Ubuntu 14.04 and Windows-10. As this issue is seen from M-60(60.0.3112.0), hence considering this issue as Non-Regression and marking it as Untriaged.

Owner: sabineb@chromium.org
Status: Assigned (was: Untriaged)
It's currently working as intended. Sync settings change apply only after close the settings page.
This is a feature request.
Assigning to our PM.
Does the 'apply on close' caveat apply to all settings changes or only Sync settings?

Do you have to close all settings tabs to apply the sync changes or only close the sync tab?

Note: Help pages do not mention 'close to apply', e.g.
https://support.google.com/chrome/answer/165139?hl=en
https://support.google.com/chrome/answer/114836?hl=en&co=GENIE.Platform=Desktop

Thanks: Functions as designed is close enough, but curious about the details.
One option discussed was  to introduce an apply button on that page to clarify semantics
FYI: There is also a race window.  If you logoff to block sync, so you can adjust the sync settings, you can't until you signin.  There's a race window between when the user signs in and the 10 seconds later when he is able to reach the settings> sync page to disable the sync functions.

Better: allow adjust sync settings while not signed in..
But the use case is so seldom, it's probably not worthwhile fixing..

Thanks, close enuf..
Status: WontFix (was: Assigned)
Changing the current behavior so that the settings take effect immediately has clear downsides (bandwidth costs for users playing around with the toggles, syncing up data before a user has turned on passphrase encryption, etc.) that outweigh the potential benefits. 

I'm going to bring up the idea to introduce an the pattern of an "apply" button up with the UX team, and in case we're going to pursue this idea, we're going to open up a new bug to track progress. 
Thx. TBD if applicable on mobile.  On the desktop, it's pretty common for me/users to close the tab after changing the settings - only power users/devs are likely to see the problem.  On Android, I suspect after sync settings changes, users use a 'back' action to leave the page, which does the apply.  Flipping to another app without leaving the settings page should be rare.
I filed crbug/887251 to track the feature request.
Looks like  bug 887034  is a dup (wont fix).

I couldn't find bug 887251 (yet).

Thx

Sign in to add a comment