New issue
Advanced search Search tips

Issue 863669 link

Starred by 1 user
Status: Fixed
Owner:
vapier@chromium.org
Closed: Jul 27
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Chrome
Pri: 2
Type: Feature



Sign in to add a comment

pylint: upgrade to 1.5.x

Project Member Reported by vapier@chromium.org, Jul 14 
the 1.4.x release is old.  the 1.5.x is less old.  time to update.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1

commit f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1
Author: Mike Frysinger <vapier@chromium.org>
Date: Mon Jul 16 23:31:59 2018

lint: do not use yoda boolean statements

The only real argument for yoda style is that, in C-like languages,
it prevents accidental assignments from typos.  e.g. This is a bug:
  if (x = 0) {...}

But in Python, you can't do inline assignment like that, so it's
never possible for that typo to hit.  That means the yoda style
serves no purpose.

Further, in chromite, we never use this style, so transition the
few cases where it slipped in.  This also addresses the new pylint
warning "misplaced-comparison-constant".

BUG= chromium:863669 
TEST=precq passes

Change-Id: Id8987aaf796ee94c95586727ab2212867bbbf033
Reviewed-on: https://chromium-review.googlesource.com/1137383
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1/scripts/cbuildbot.py
[modify] https://crrev.com/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1/mobmonitor/system/systeminfo.py
[modify] https://crrev.com/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1/scripts/cros_portage_upgrade.py
[modify] https://crrev.com/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1/scripts/cros_portage_upgrade_unittest.py
[modify] https://crrev.com/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1/mobmonitor/scripts/mobmoncli.py
[modify] https://crrev.com/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1/cli/cros/cros_payload.py
[modify] https://crrev.com/f904d229c57a4b71dd9c7e8150ad8dfa3e7313c1/cros_bisect/common_unittest.py
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/82b059ecb6a4964213977e0efbbeb93c0442ac83

commit 82b059ecb6a4964213977e0efbbeb93c0442ac83
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 17 16:08:10 2018

lint: fix singleton-comparison warnings

Newer pylint makes sure the "is" operator is used whenever comparing
to singletons like None, so fix all the bad "==" usage.

BUG= chromium:863669 
TEST=precq passes

Change-Id: I154a8f34dbee23ddbf2986101f53a5593e2767e3
Reviewed-on: https://chromium-review.googlesource.com/1139134
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gregory Meinke <gmeinke@chromium.org>

[modify] https://crrev.com/82b059ecb6a4964213977e0efbbeb93c0442ac83/cbuildbot/stages/test_stages_unittest.py
[modify] https://crrev.com/82b059ecb6a4964213977e0efbbeb93c0442ac83/lib/cros_event.py
[modify] https://crrev.com/82b059ecb6a4964213977e0efbbeb93c0442ac83/config/chromeos_config_unittest.py
[modify] https://crrev.com/82b059ecb6a4964213977e0efbbeb93c0442ac83/scripts/cros_gdb.py
[modify] https://crrev.com/82b059ecb6a4964213977e0efbbeb93c0442ac83/scripts/cros_portage_upgrade_unittest.py
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/a620b8e7f5f9f71851735797f7e44353b66f550c

commit a620b8e7f5f9f71851735797f7e44353b66f550c
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 17 16:08:10 2018

lint: fix no-value-for-parameter warnings

Newer pylint can detect some function calls which require arguments
but we didn't specify them (oops).  Add the missing args.

The iflatten case wasn't wrong, but was written poorly.

BUG= chromium:863669 
TEST=precq passes

Change-Id: I66896d170337ce3354f9f301ada0447717ce068b
Reviewed-on: https://chromium-review.googlesource.com/1139138
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gregory Meinke <gmeinke@chromium.org>

[modify] https://crrev.com/a620b8e7f5f9f71851735797f7e44353b66f550c/scripts/cros_sysroot_utils.py
[modify] https://crrev.com/a620b8e7f5f9f71851735797f7e44353b66f550c/lib/cros_build_lib_unittest.py
[modify] https://crrev.com/a620b8e7f5f9f71851735797f7e44353b66f550c/scripts/cros_install_debug_syms.py
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/764a58f972be81c5a0eb16f2928e1453347e7bfa

commit 764a58f972be81c5a0eb16f2928e1453347e7bfa
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 18 04:53:32 2018

cbuildbot: drop uncommon pathjoin/abspath short names

We don't use this style anywhere else (and even not entirely in this
module), so switch to the full os.path.xxx form.

BUG= chromium:863669 
TEST=unittest still passes

Change-Id: I631463f7d06126bd9979db07c7bbaa433e4913ed
Reviewed-on: https://chromium-review.googlesource.com/1138811
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/764a58f972be81c5a0eb16f2928e1453347e7bfa/cbuildbot/commands_unittest.py
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/266e4ffa12aebaa2de8f5a718284e23579fd2d0b

commit 266e4ffa12aebaa2de8f5a718284e23579fd2d0b
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 18 04:53:16 2018

lint: fix unneeded-not warnings

Newer pylint will warn when "not" is used at the start of an expression
when it would be clearer to merge it with the operator in the middle.
e.g. "not foo == bar" is turned into "foo != bar".

BUG= chromium:863669 
TEST=precq passes

Change-Id: I4e86e6b3b04f4600e016c9069ae037a0b7d281e8
Reviewed-on: https://chromium-review.googlesource.com/1138812
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[modify] https://crrev.com/266e4ffa12aebaa2de8f5a718284e23579fd2d0b/scripts/chrome_chromeos_lkgm.py
[modify] https://crrev.com/266e4ffa12aebaa2de8f5a718284e23579fd2d0b/scripts/gconv_strip.py
[modify] https://crrev.com/266e4ffa12aebaa2de8f5a718284e23579fd2d0b/scripts/cros_gdb.py
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/144dce0cbbbaed5c14927e754663ccaf06f394f3

commit 144dce0cbbbaed5c14927e754663ccaf06f394f3
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 18 04:53:11 2018

lint: fix ungrouped-imports warnings

Newer pylint will warn when modules aren't grouped properly.
Since we do this in pretty much every chromite module, fix the
two minor deviations.

BUG= chromium:863669 
TEST=precq passes

Change-Id: I1d7d71177a96c8189c4eae0141f30b9775d5a757
Reviewed-on: https://chromium-review.googlesource.com/1139133
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[modify] https://crrev.com/144dce0cbbbaed5c14927e754663ccaf06f394f3/scripts/sysmon/mainlib.py
[modify] https://crrev.com/144dce0cbbbaed5c14927e754663ccaf06f394f3/lib/parallel.py
Project Member

Comment 7 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/15642dbf2dd8b48162098ebc3463a2199b7cae46

commit 15642dbf2dd8b48162098ebc3463a2199b7cae46
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 18 04:53:04 2018

lint: fix not-context-manager warnings

Newer pylint can detect objects used as context managers which aren't
actually such, like mock.MagicMock.  This "worked" because that mock
automatically stubs out all methods, so when python tried to use the
__enter__/__exit__ calls, they returned automatically.  However, the
GetTrackerFilenames helper wasn't actually restored to its non-mocked
value.  Not that the unittests here noticed or cared.

BUG= chromium:863669 
TEST=precq passes

Change-Id: I09ee3d80cea050902bfeedaeaff95a0a11b5f607
Reviewed-on: https://chromium-review.googlesource.com/1139139
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/15642dbf2dd8b48162098ebc3463a2199b7cae46/lib/gs_unittest.py
Project Member

Comment 8 by bugdroid1@chromium.org, Jul 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/bd0af609138667a98ad2fa8b19dc664596861d72

commit bd0af609138667a98ad2fa8b19dc664596861d72
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 18 04:53:13 2018

lint: update warning disable list

BUG= chromium:863669 
TEST=precq passes

Change-Id: Ib15f4e4ba3f2a324c27a5d1a2046226d138aa323
Reviewed-on: https://chromium-review.googlesource.com/1139141
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/bd0af609138667a98ad2fa8b19dc664596861d72/pylintrc
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/3899f1bcce7bb87be6af32aec08f8a373e5ae417

commit 3899f1bcce7bb87be6af32aec08f8a373e5ae417
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jul 20 03:32:18 2018

pylint: upgrade to 1.5.6

We disable new warnings that are triggered in depot_tools to pylintrc.
So the lint output before & after this CL are mostly unchanged.  The
repos checked: depot_tools, src, and build.

Also update astroid to 1.4.9 and drop logilab.common as needed.

Bug:  863669 
Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044
Reviewed-on: https://chromium-review.googlesource.com/1137382
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/graph.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/cli.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/similar.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/xmlrpcutils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/__pkginfo__.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/arguments.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/date.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/variables.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/raw_metrics.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/deprecation.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/context.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/table.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/README.chromium
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/ureports/text_writer.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/modutils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/utils.py
[rename] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_mechanize.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/lint.py
[rename] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_gi.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/strings.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/exceptions.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/exceptions.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/nodes.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/cache.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/umessage.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/__pkginfo__.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/extensions/__init__.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/optparser.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/html.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/proc.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/protocols.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/configuration.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/base.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/utils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/README.chromium
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/inference.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/raw_building.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/fileutils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/utils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/main.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/imports.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/testutils.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_stdlib.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/modutils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/test_utils.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/visitor.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/interface.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/ureports/__init__.py
[rename] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_nose.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/astroid/utils.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/compat.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/dbf.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/sphinxutils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/classes.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_dateutil.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/textutils.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/astroid/brain/py2pytest.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/misc.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/__init__.py
[rename] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_builtin_inference.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/interfaces.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/guireporter.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/bases.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/manager.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/corbautils.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/debugger.py
[rename] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/ureports/nodes.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/__init__.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_numpy.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/util.py
[rename] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_six.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/epylint.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/README.chromium
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/astroid/brain/py2stdlib.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/logging_ext.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/extensions/check_elif.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/astroid/brain/py2qt4.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/pyro_ext.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/python3.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/ureports/html_writer.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/json.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_pytest.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/async.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/shellutils.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/design_analysis.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/clcommands.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/extensions/check_docs.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/ureports/docbook_writer.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/stdlib.py
[rename] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/vcgutils.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/tasksqueue.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/format.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/decorators.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/astroid/inspector.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/node_classes.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/tree.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/contexts.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/typecheck.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/logging.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_ssl.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/changelog.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/pylintrc
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/transforms.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_qt.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/ureports/__init__.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/builder.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/__init__.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/ureports/text_writer.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/writer.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/rebuilder.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/objects.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/diagrams.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/mixins.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/pytest.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/__pkginfo__.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/__init__.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/diadefslib.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/text.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/spelling.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/as_string.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/newstyle.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/decorators.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/registry.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/scoped_nodes.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/LICENSE.txt
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/graph.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/gui.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/optik_ext.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/urllib2ext.py
[add] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/inspector.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/daemon.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/ureports/html_writer.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/xmlutils.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/testlib.py
[delete] https://crrev.com/20c1311957dd95732ba224f0f071f286f31cd047/third_party/logilab/common/sphinx_ext.py
[modify] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/config.py
Project Member

Comment 10 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7f0f622b98176c4f7d82cdeabcd547adb60e496

commit e7f0f622b98176c4f7d82cdeabcd547adb60e496
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 20 04:42:08 2018

Roll src/third_party/depot_tools 20c1311957dd..3899f1bcce7b (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/20c1311957dd..3899f1bcce7b


git log 20c1311957dd..3899f1bcce7b --date=short --no-merges --format='%ad %ae %s'
2018-07-20 vapier@chromium.org pylint: upgrade to 1.5.6


Created with:
  gclient setdep -r src/third_party/depot_tools@3899f1bcce7b

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:863669 
TBR=agable@chromium.org

Change-Id: I367e9aa371d3240965079c92b6b1598a24b60f7f
Reviewed-on: https://chromium-review.googlesource.com/1144681
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576781}
[modify] https://crrev.com/e7f0f622b98176c4f7d82cdeabcd547adb60e496/DEPS
Project Member

Comment 11 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/807abf149a5d70e80b2ed1fee11dcec2a7d255bc

commit 807abf149a5d70e80b2ed1fee11dcec2a7d255bc
Author: Ned Nguyen <nednguyen@google.com>
Date: Fri Jul 20 11:33:10 2018

Revert "pylint: upgrade to 1.5.6"

This reverts commit 3899f1bcce7bb87be6af32aec08f8a373e5ae417.

Reason for revert: causing PRESUBMIT error on catapult repo 

BUG: chromium:865897 

Original change's description:
> pylint: upgrade to 1.5.6
> 
> We disable new warnings that are triggered in depot_tools to pylintrc.
> So the lint output before & after this CL are mostly unchanged.  The
> repos checked: depot_tools, src, and build.
> 
> Also update astroid to 1.4.9 and drop logilab.common as needed.
> 
> Bug:  863669 
> Change-Id: Ib602560c1bcad5a9e8b6ca731d9465f43220f044
> Reviewed-on: https://chromium-review.googlesource.com/1137382
> Reviewed-by: John Budorick <jbudorick@chromium.org>
> Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
> Commit-Queue: Mike Frysinger <vapier@chromium.org>

TBR=vapier@chromium.org,iannucci@chromium.org,jbudorick@chromium.org

Change-Id: I8ea087123db4e52fdf7ebff8b1ed356fd60a6059
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  863669 
Reviewed-on: https://chromium-review.googlesource.com/1145160
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ned Nguyen <nednguyen@google.com>

[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/graph.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/cli.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/similar.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/xmlrpcutils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/__pkginfo__.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/arguments.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/date.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/variables.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/raw_metrics.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/deprecation.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/context.py
[rename] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/pysix_moves.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/table.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/README.chromium
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/ureports/text_writer.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/modutils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/utils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/lint.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/strings.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/exceptions.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/exceptions.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/nodes.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/cache.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/umessage.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/__pkginfo__.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/extensions/__init__.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/optparser.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/reporters/html.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/proc.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/protocols.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/configuration.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/base.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/utils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/README.chromium
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/inference.py
[rename] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/py2gi.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/raw_building.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/fileutils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/pyreverse/utils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/pyreverse/main.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/imports.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/testutils.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_stdlib.py
[rename] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/ureports/nodes.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/modutils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/test_utils.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/visitor.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/interface.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/ureports/__init__.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/utils.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/compat.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/dbf.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/sphinxutils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/classes.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_dateutil.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/textutils.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/py2pytest.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/misc.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/reporters/__init__.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/interfaces.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/reporters/guireporter.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/bases.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/manager.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/corbautils.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/debugger.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/__init__.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_numpy.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/util.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/epylint.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/README.chromium
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/py2stdlib.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/scoped_nodes.py
[rename] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/vcgutils.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/extensions/check_elif.py
[rename] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/pynose.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/py2qt4.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/pyro_ext.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/python3.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/ureports/html_writer.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/reporters/json.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_pytest.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/checkers/async.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/shellutils.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/design_analysis.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/clcommands.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/extensions/check_docs.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/ureports/docbook_writer.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/stdlib.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/tasksqueue.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/format.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/decorators.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/inspector.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/node_classes.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/tree.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/contexts.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/typecheck.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/logging.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_ssl.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/changelog.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/pylintrc
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/transforms.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/brain/brain_qt.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/ureports/__init__.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/builder.py
[rename] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/builtin_inference.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/__init__.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/reporters/ureports/text_writer.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/pyreverse/writer.py
[rename] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/brain/py2mechanize.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/rebuilder.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/logilab/astroid/objects.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/pyreverse/diagrams.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/mixins.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/pytest.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/__pkginfo__.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/__init__.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/pyreverse/diadefslib.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/reporters/text.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/spelling.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/astroid/as_string.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/checkers/newstyle.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/decorators.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/registry.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/logging_ext.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/LICENSE.txt
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/graph.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/gui.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/optik_ext.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/urllib2ext.py
[delete] https://crrev.com/3899f1bcce7bb87be6af32aec08f8a373e5ae417/third_party/pylint/pyreverse/inspector.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/daemon.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/ureports/html_writer.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/xmlutils.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/testlib.py
[add] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/logilab/common/sphinx_ext.py
[modify] https://crrev.com/807abf149a5d70e80b2ed1fee11dcec2a7d255bc/third_party/pylint/config.py
Project Member

Comment 12 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4dd0b4d082650efb63955ae65a1e6255d2c03d5

commit c4dd0b4d082650efb63955ae65a1e6255d2c03d5
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 20 12:31:58 2018

Roll src/third_party/depot_tools 3899f1bcce7b..807abf149a5d (1 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3899f1bcce7b..807abf149a5d


git log 3899f1bcce7b..807abf149a5d --date=short --no-merges --format='%ad %ae %s'
2018-07-20 nednguyen@google.com Revert "pylint: upgrade to 1.5.6"


Created with:
  gclient setdep -r src/third_party/depot_tools@807abf149a5d

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:863669 
TBR=agable@chromium.org

Change-Id: I225b59a9cfe191d61a449a422e0760b351774727
Reviewed-on: https://chromium-review.googlesource.com/1145200
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#576837}
[modify] https://crrev.com/c4dd0b4d082650efb63955ae65a1e6255d2c03d5/DEPS
Project Member

Comment 13 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/862370c608726a4ea271f3bf51b246f8afbff077

commit 862370c608726a4ea271f3bf51b246f8afbff077
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jul 20 20:02:39 2018

pylint: reland upgrade to 1.5.6

** WARNING: please do not revert this CL without checking with vapier@ first ***

We disable new warnings that are triggered in depot_tools to pylintrc.
So the lint output before & after this CL are mostly unchanged.  The
repos checked: depot_tools, src, and build.

Also update its deps along the way:
- Update astroid to 1.4.9.
- Drop now unused logilab.common.
- Import lazy_object_proxy 1.3.1.
- Import wrapt 1.10.11.

This should address the issue where some Chromium bots don't have the
lazy_object_proxy/wrapt python modules installed.  These have optional
C modules that we don't compile either as they have Python fallbacks.

Bug:  863669 
Change-Id: Iade0e6d89598e2c836ed647996f43db356c43cd0
Reviewed-on: https://chromium-review.googlesource.com/1145485
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Robbie Iannucci <iannucci@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>

[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/graph.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/decorators.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/cli.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/similar.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/xmlrpcutils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/__pkginfo__.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/raw_metrics.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/arguments.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/date.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/variables.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/_wrappers.c
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/arguments.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/deprecation.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/context.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/slots.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/table.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/README.chromium
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/ureports/text_writer.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/modutils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/utils.py
[rename] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_mechanize.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/lint.py
[rename] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_gi.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/strings.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/wrappers.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/exceptions.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/exceptions.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/nodes.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/cache.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/umessage.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/__pkginfo__.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/extensions/__init__.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/optparser.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/html.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/simple.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/proc.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/protocols.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/configuration.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/base.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/utils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/README.chromium
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/inference.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/raw_building.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/fileutils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/pyreverse/utils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/pyreverse/main.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/LICENSE
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/imports.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/testutils.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_stdlib.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/compat.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/modutils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/test_utils.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/visitor.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/interface.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/ureports/__init__.py
[rename] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_nose.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/astroid/utils.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/compat.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/dbf.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/sphinxutils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/classes.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_dateutil.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/textutils.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/astroid/brain/py2pytest.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/misc.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/__init__.py
[rename] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_builtin_inference.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/interfaces.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/guireporter.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/bases.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/manager.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/corbautils.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/debugger.py
[rename] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/ureports/nodes.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/__init__.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_numpy.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/util.py
[rename] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_six.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/epylint.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/README.chromium
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/README.chromium
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/README.chromium
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/astroid/brain/py2stdlib.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/logging_ext.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/extensions/check_elif.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/LICENSE
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/astroid/brain/py2qt4.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/pyro_ext.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/python3.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/ureports/html_writer.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/json.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_pytest.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/async.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/shellutils.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/design_analysis.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/clcommands.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/__init__.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/extensions/check_docs.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/ureports/docbook_writer.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/stdlib.py
[rename] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/pyreverse/vcgutils.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/tasksqueue.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/importer.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/format.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/decorators.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/astroid/inspector.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/node_classes.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/tree.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/contexts.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/typecheck.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/cext.c
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/logging.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_ssl.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/changelog.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/pylintrc
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/utils.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/transforms.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/brain/brain_qt.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/ureports/__init__.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/builder.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/__init__.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/ureports/text_writer.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/pyreverse/writer.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/wrapt/__init__.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/lazy_object_proxy/README.chromium
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/rebuilder.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/objects.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/pyreverse/diagrams.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/mixins.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/pytest.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/__pkginfo__.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/__init__.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/pyreverse/diadefslib.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/reporters/text.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/spelling.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/as_string.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/checkers/newstyle.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/decorators.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/registry.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/logilab/astroid/scoped_nodes.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/LICENSE.txt
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/graph.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/gui.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/optik_ext.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/urllib2ext.py
[add] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/pyreverse/inspector.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/daemon.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/ureports/html_writer.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/xmlutils.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/testlib.py
[delete] https://crrev.com/40764b07d0583624a4f22edb40ecb928f7f9ef0d/third_party/logilab/common/sphinx_ext.py
[modify] https://crrev.com/862370c608726a4ea271f3bf51b246f8afbff077/third_party/pylint/config.py
Project Member

Comment 14 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/depot_tools/+/60b9b6fb9147c8cd512c886bf3969ea114358a56

commit 60b9b6fb9147c8cd512c886bf3969ea114358a56
Author: Edward Lemur <ehmaldonado@chromium.org>
Date: Fri Jul 20 20:42:49 2018

git_hyper_blame_test: Fix pylint issue.

TBR=agable@chromium.org
Bug:  863669 
Change-Id: Id641269f023acc1a89e83e9e5951e933eae93d40
Reviewed-on: https://chromium-review.googlesource.com/1145720
Reviewed-by: Edward Lesmes <ehmaldonado@chromium.org>
Commit-Queue: Edward Lesmes <ehmaldonado@chromium.org>

[modify] https://crrev.com/60b9b6fb9147c8cd512c886bf3969ea114358a56/tests/git_hyper_blame_test.py
Project Member

Comment 15 by bugdroid1@chromium.org, Jul 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d530f680ed84564fa6ebe7237c329b15df75f9cb

commit d530f680ed84564fa6ebe7237c329b15df75f9cb
Author: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 20 21:59:36 2018

Roll src/third_party/depot_tools 807abf149a5d..60b9b6fb9147 (3 commits)

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/807abf149a5d..60b9b6fb9147


git log 807abf149a5d..60b9b6fb9147 --date=short --no-merges --format='%ad %ae %s'
2018-07-20 ehmaldonado@chromium.org git_hyper_blame_test: Fix pylint issue.
2018-07-20 vapier@chromium.org pylint: reland upgrade to 1.5.6
2018-07-20 ehmaldonado@chromium.org gclient: Report project url if it's a known project.


Created with:
  gclient setdep -r src/third_party/depot_tools@60b9b6fb9147

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:863669 , chromium:863669 , chromium:832386 
TBR=agable@chromium.org

Change-Id: I822581246815ddb4c1c4a6a8edd0b93a97dac033
Reviewed-on: https://chromium-review.googlesource.com/1145407
Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#577002}
[modify] https://crrev.com/d530f680ed84564fa6ebe7237c329b15df75f9cb/DEPS
Project Member

Comment 16 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/manifest-internal/+/bb80f5e4657cf37c68874a31312c8d6b4fb39e41

commit bb80f5e4657cf37c68874a31312c8d6b4fb39e41
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 04:04:46 2018
Project Member

Comment 17 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/manifest/+/76f115bad72d9b4e8c81c3305fb8b416d37b2a2f

commit 76f115bad72d9b4e8c81c3305fb8b416d37b2a2f
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 04:05:03 2018

depot_tools: roll for newer pylint 1.5.x

BUG= chromium:863669 
TEST=`cros lint` in chromite

Change-Id: I75f9fe941773c1cf9c8ebd012eddda515032f48d
Reviewed-on: https://chromium-review.googlesource.com/1146054
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/76f115bad72d9b4e8c81c3305fb8b416d37b2a2f/full.xml
Project Member

Comment 18 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7

commit 6d55b03e4ba4d1be861d5fb8403518a3ceef74d7
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 04:58:09 2018

chromite/api: rev depot_tools

Had to run:
./scripts/slave/.recipe_deps/recipe_engine/recipes.py \
	--package ./infra/config/recipes.cfg test train

Bug:  863669 
Change-Id: Ib5429d7c536bc75edf49156762f962f7fd30de54
Recipe-Nontrivial-Roll: build_limited_scripts_slave
Reviewed-on: https://chromium-review.googlesource.com/1146055
Reviewed-by: Don Garrett <dgarrett@chromium.org>
Commit-Queue: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/swarming_builder.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipe_modules/chromite/api.py
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/tryjob_simple.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/swarming_builder.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/master_builder.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_goma_canary.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_paladin_buildbucket.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/pre_cq_buildbucket_config.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/release.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/external.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/release_branch_two_params.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/tryjob_complex.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/complex_slave_builder.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/basic_compressed.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/empty_string_args.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_chromium_builder.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/tuple_args.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_coverage_variant.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_paladin_manifest_failure.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/pre_git_cache_release.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/swarming.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/unknown_config.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_paladin.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot.expected/chromiumos_coverage.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/release_branch_one_param.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/ndk/ndk_buildbot.expected/basic.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/swarming.expected/goma_canary.json
[modify] https://crrev.com/6d55b03e4ba4d1be861d5fb8403518a3ceef74d7/scripts/slave/recipes/cros/cbuildbot_tryjob.expected/internal.json

Comment 19 by kcwu@chromium.org, Jul 24 

Hi, Mike
'cros lint' is broken for me both inside and outside chroot.
Do you have idea what's wrong?

I got following error when run 'cros lint *.py'.

Traceback (most recent call last):
  File "/mnt/host/source/chromium/tools/depot_tools/third_party/pylint.py", line 37, in <module>
    lint.Run(args)
  File "/mnt/host/source/chromium/tools/depot_tools/third_party/pylint/lint.py", line 1281, in __init__
    linter.load_plugin_modules(plugins)
  File "/mnt/host/source/chromium/tools/depot_tools/third_party/pylint/lint.py", line 487, in load_plugin_modules
    module = modutils.load_module_from_name(modname)
  File "/mnt/host/source/chromium/tools/depot_tools/third_party/logilab/astroid/modutils.py", line 186, in load_module_from_name
    return load_module_from_modpath(dotted_name.split('.'), path, use_sys)
  File "/mnt/host/source/chromium/tools/depot_tools/third_party/logilab/astroid/modutils.py", line 229, in load_module_from_modpath
    module = imp.load_module(curname, mp_file, mp_filename, mp_desc)
  File "/mnt/host/source/chromite/cli/cros/lint.py", line 28, in <module>
    from logilab.common.configuration import Configuration
ImportError: No module named common.configuration
Project Member

Comment 20 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/8960f7c7b0bbceda9736e210dfe1e4f4f70e2515

commit 8960f7c7b0bbceda9736e210dfe1e4f4f70e2515
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 11:11:27 2018

lint: fix consider-using-enumerate warnings

Newer pylint can detect cases where enumerate() probably makes more
sense.  Fix the places where it warns.

BUG= chromium:863669 
TEST=precq passes

Change-Id: I8dd4663c3002f1ac96735e7620bbd664178617df
Reviewed-on: https://chromium-review.googlesource.com/1139135
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/8960f7c7b0bbceda9736e210dfe1e4f4f70e2515/lib/config_lib_unittest.py
[modify] https://crrev.com/8960f7c7b0bbceda9736e210dfe1e4f4f70e2515/scripts/gconv_strip.py
[modify] https://crrev.com/8960f7c7b0bbceda9736e210dfe1e4f4f70e2515/lib/auto_update_util_unittest.py
Project Member

Comment 21 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9e8edc1ddb6b13570a2379388f157dfa96e30633

commit 9e8edc1ddb6b13570a2379388f157dfa96e30633
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 11:11:26 2018

lint: fix unsubscriptable-object warnings

Newer pylint can detect some situations where a variable is used with
indices but its type is wrong (e.g. trying to do None['foo']).

BUG= chromium:863669 
TEST=precq passes

Change-Id: Ic475bf4819d085d1e055c6c6e5fb971aab110dd0
Reviewed-on: https://chromium-review.googlesource.com/1139137
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[modify] https://crrev.com/9e8edc1ddb6b13570a2379388f157dfa96e30633/lib/parseelf.py
[modify] https://crrev.com/9e8edc1ddb6b13570a2379388f157dfa96e30633/scripts/som_alerts_dispatcher.py
Project Member

Comment 22 by bugdroid1@chromium.org, Jul 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/69c79e9bca3bce734c77fbf0cc30d7e0242f9729

commit 69c79e9bca3bce734c77fbf0cc30d7e0242f9729
Author: Mike Frysinger <vapier@chromium.org>
Date: Tue Jul 24 11:11:28 2018

lint: fix not-an-iterable warnings

Newer pylint has logic to detect non-iterable usage, but in two cases
in our code it throws false positives due to how we've structured our
classes and the default None value.  Suppress the warnings.

BUG= chromium:863669 
TEST=precq passes

Change-Id: Ib2c7b1f786de402a32f72fe4009c4b674412020e
Reviewed-on: https://chromium-review.googlesource.com/1139140
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Gregory Meinke <gmeinke@chromium.org>

[modify] https://crrev.com/69c79e9bca3bce734c77fbf0cc30d7e0242f9729/lib/partial_mock.py
Project Member

Comment 23 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/portage-stable/+/f86b483c80464517e28a1f7f4b665c1a2f18c1c7

commit f86b483c80464517e28a1f7f4b665c1a2f18c1c7
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 25 07:14:54 2018

eclass: update vcs eclasses

Needed by newer pylint packages.

BUG= chromium:863669 
TEST=precq passes

Change-Id: I4232fed9b43ac0c7c4d56d76778cc580f70e66bb
Reviewed-on: https://chromium-review.googlesource.com/1148781
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[add] https://crrev.com/f86b483c80464517e28a1f7f4b665c1a2f18c1c7/eclass/vcs-clean.eclass
[modify] https://crrev.com/f86b483c80464517e28a1f7f4b665c1a2f18c1c7/eclass/vcs-snapshot.eclass
Project Member

Comment 25 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/387316b164f648bd1dc628197e9872d0810536eb

commit 387316b164f648bd1dc628197e9872d0810536eb
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 25 07:14:52 2018

package.keywords: drop old entries

Scrub package/versions that no longer exist in the tree.

BUG= chromium:863669 
TEST=precq passes

Change-Id: I60df5d9236fc4dc8436d7de4ea0351a77bea0788
Reviewed-on: https://chromium-review.googlesource.com/1148780
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/387316b164f648bd1dc628197e9872d0810536eb/profiles/targets/chromeos/package.keywords
[modify] https://crrev.com/387316b164f648bd1dc628197e9872d0810536eb/profiles/default/linux/package.keywords
Project Member

Comment 26 by bugdroid1@chromium.org, Jul 25 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform2/+/e7bebfaa976e4e269e5f5420b2d525d1acedcf6f

commit e7bebfaa976e4e269e5f5420b2d525d1acedcf6f
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Jul 25 07:14:45 2018

common-mk: fix wrong-import-order lint error

Newer pylint is able to enforce PEP8 module ordering.  Respect it.

BUG= chromium:863669 
TEST=`cros lint` is clean

Change-Id: Ia8ac5063816050e0526dc60e58177aad213d105d
Reviewed-on: https://chromium-review.googlesource.com/1149107
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Ben Chan <benchan@chromium.org>

[modify] https://crrev.com/e7bebfaa976e4e269e5f5420b2d525d1acedcf6f/common-mk/platform2_test.py
Project Member

Comment 27 by bugdroid1@chromium.org, Jul 26 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/c0d016ac12acb259cddd9603db7ea8f7cb6e0f54

commit c0d016ac12acb259cddd9603db7ea8f7cb6e0f54
Author: Mike Frysinger <vapier@chromium.org>
Date: Thu Jul 26 22:52:00 2018

cros lint: update to work w/pylint-1.5

Since pylint-1.5 no longer needed logilab.common, it was dropped.
We were using it for pylintrc reading though, so we broke too.
Rework this logic to use the newer pylint-1.5 config file methods.

BUG= chromium:863669 
TEST=`cros lint` works w/out logilab.common
CQ-DEPEND=CL:1148788

Change-Id: I4d1a498306f994b6f184417558d27247b3bbe51b
Reviewed-on: https://chromium-review.googlesource.com/1148477
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>

[modify] https://crrev.com/c0d016ac12acb259cddd9603db7ea8f7cb6e0f54/cli/cros/lint_autotest.py
[modify] https://crrev.com/c0d016ac12acb259cddd9603db7ea8f7cb6e0f54/cli/cros/tests/lint_messages/func_common_import.txt
[modify] https://crrev.com/c0d016ac12acb259cddd9603db7ea8f7cb6e0f54/cli/cros/tests/lint_input/func_common_import.py
[modify] https://crrev.com/c0d016ac12acb259cddd9603db7ea8f7cb6e0f54/cli/cros/lint_unittest.py
[modify] https://crrev.com/c0d016ac12acb259cddd9603db7ea8f7cb6e0f54/cli/cros/lint.py
Project Member

Comment 29 by bugdroid1@chromium.org, Jul 27 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/498e62205d6e0ae5d6f93ac1af36dc754b7fe6b8

commit 498e62205d6e0ae5d6f93ac1af36dc754b7fe6b8
Author: Mike Frysinger <vapier@chromium.org>
Date: Fri Jul 27 03:45:03 2018

lint: fix using-constant-test warning

Our use of None-vs-generator return value confuses pylint.
Add an explicit None test to quiet it down.

BUG= chromium:863669 
TEST=`cros lint` doesn't show anymore

Change-Id: I711d0a6b303c876fdb0229e7361f03d7565b3ddf
Reviewed-on: https://chromium-review.googlesource.com/1149109
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Alex Klein <saklein@chromium.org>

[modify] https://crrev.com/498e62205d6e0ae5d6f93ac1af36dc754b7fe6b8/lib/chroot_util.py

Comment 31 by vapier@chromium.org, Jul 27

Status: Fixed (was: Started)
Project Member

Comment 32 by bugdroid1@chromium.org, Jul 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/3b438311bbf388975e1364de66d33ea85f878553

commit 3b438311bbf388975e1364de66d33ea85f878553
Author: Mike Frysinger <vapier@chromium.org>
Date: Sat Jul 28 20:32:23 2018

lint_autotest: remove hack to make unittests pass

The logilab.common module no longer exists, so we can't patch it.
The test passes w/out it, so drop it and wait to see if we need to
add it back in.

BUG= chromium:863669 
TEST=unittest passes w/out logilab.common installed

Change-Id: I6a95bfc097a4114fc98cdbc43c4a9197bfccd1b8
Reviewed-on: https://chromium-review.googlesource.com/1154349
Reviewed-by: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/3b438311bbf388975e1364de66d33ea85f878553/cli/cros/lint_autotest.py
Project Member

Comment 33 by bugdroid1@chromium.org, Aug 1 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/d35d563a73b0cfbb26b3b3b4e21a735a29ed3d5c

commit d35d563a73b0cfbb26b3b3b4e21a735a29ed3d5c
Author: Ryo Hashimoto <hashimoto@google.com>
Date: Wed Aug 01 21:52:27 2018

utils: Fix run_pylint.py

run_pylint.py is broken because of pylint upgrade in depot_tools
(CL:1145485)

BUG= chromium:863669 
TEST=Create an autotest CL and repo upload

Change-Id: I7a0407a862f0b2bcc41b50d2857c4c6184c3d540
Reviewed-on: https://chromium-review.googlesource.com/1158101
Commit-Ready: Ryo Hashimoto <hashimoto@chromium.org>
Tested-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/d35d563a73b0cfbb26b3b3b4e21a735a29ed3d5c/utils/run_pylint.py
Project Member

Comment 34 by bugdroid1@chromium.org, Sep 10 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/533566a7e2c3d7921202ab63a9c55571348dfd28

commit 533566a7e2c3d7921202ab63a9c55571348dfd28
Author: Peter Shih <pihsun@chromium.org>
Date: Mon Sep 10 08:13:25 2018

Fix lint errors for pylint 1.5.6.

Chroot had pylint updated to 1.5.6 after CL:1148788, fix or suppress all
lint errors.

The redefined-variable-type (R0204) produced too many false-positive to
be useful, so it's disabled. The lint is moved to an extension and
disabled by default in later version of pylint.

BUG= chromium:863669 
TEST=make lint
TEST=make test

Change-Id: I29cac1b1e2bf18933793b215d40b58aa1632df9f
Reviewed-on: https://chromium-review.googlesource.com/1206552
Commit-Ready: Pi-Hsun Shih <pihsun@chromium.org>
Tested-by: Pi-Hsun Shih <pihsun@chromium.org>
Reviewed-by: Wei-Han Chen <stimim@chromium.org>

[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/utils/config_utils.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/test/fixture/whale/servo_config.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/test/test_ui.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/utils/schema.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/device/status.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/hwid/service/appengine/hwid_api.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/tools/netboot_firmware_settings.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/tools/make_par.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/probe/lib/action_function_unittest.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/devtools/mk/pylint.rc
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/goofy/goofy.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/goofy/plugins/system_log_manager_unittest.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/utils/pygpt.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/utils/sync_utils.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/test/utils/connection_manager.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/test/fixture/whale/host/interrupt_handler.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/utils/type_utils_unittest.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/test/pytests/fingerprint_mcu.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/utils/arg_utils.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/device/info.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/tools/factory.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/tools/ovl.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/gooftool/core.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/gooftool/bmpblk.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/probe/lib/cached_probe_function_unittest.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/probe/lib/probe_function_unittest.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/devtools/mk/pylint.blacklist
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/utils/platform_utils.py
[modify] https://crrev.com/533566a7e2c3d7921202ab63a9c55571348dfd28/py/device/ambient_light_sensor.py
►

Sign in to add a comment