New issue
Advanced search Search tips

Issue 863651 link

Starred by 2 users
Status: Fixed
Owner:
ctzsm@chromium.org
Closed: Jul 19
Cc:
xiaoche...@chromium.org
yosin@chromium.org
editing-dev@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

DCHECK violation in TextControlElement#CacheSelection()

Project Member Reported by ctzsm@chromium.org, Jul 14 
The call of TextControlElement#CacheSelection() in TextControlElement::SelectionChanged() violated a DCHECK with layout test search-cancel-button-mouseup.html.

DCHECK in |CacheSelection()| expects selection start <= selection end. But the test made a selection from cancel button to inner editor with start = 3 and end = 0 with the fix crrev/c/1102157.

Marking this test as Crash for now and work on the fix separately.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f7fefaed0bf15948b7007aaa341fea2c74ce993b

commit f7fefaed0bf15948b7007aaa341fea2c74ce993b
Author: Shimi Zhang <ctzsm@chromium.org>
Date: Thu Jul 19 02:00:14 2018

[Search form] Don't allow selection on cancel button

With the new algorithm in http://crrev/c/1102157, we won't be able to
select cross editing boundary anymore, so layout test
search-cancel-button-mouseup.html will violate a DCHECK in
|TextControlElement::CacheSelection()|.

In fact, we shouldn't allow selection starts with cancel button at all,
this CL adds |user-select: none;| to |SearchFieldCancelButtonElement|.

Bug:  863651 
Change-Id: Id23b50503caaf814b0a8a14ea1b7c243b3c51c68
Reviewed-on: https://chromium-review.googlesource.com/1141350
Reviewed-by: Kent Tamura <tkent@chromium.org>
Commit-Queue: Shimi Zhang <ctzsm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576321}
[modify] https://crrev.com/f7fefaed0bf15948b7007aaa341fea2c74ce993b/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/f7fefaed0bf15948b7007aaa341fea2c74ce993b/third_party/blink/renderer/core/css/html.css

Comment 2 by ctzsm@chromium.org, Jul 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment