New issue
Advanced search Search tips

Issue 863626 link

Starred by 2 users
Status: Available
Owner: ----
Cc:
hiroh@chromium.org
bpastene@chromium.org
posciak@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Resolve cras-related crashes of AudioManagerTests in media_unittests on ChromeOS

Project Member Reported by bpastene@chromium.org, Jul 13 
I'm looking into enabling media_unittests on cros VMs on the CQ. Currently, a few AudioManagerTest tests fail due to audio handler init errors:
FATAL:cras_audio_handler.cc(131)] Check failed: g_cras_audio_handler.
from
https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8941080716176056288/+/steps/media_unittests__with_patch_/0/logs/AudioManagerTest.DefaultCommunicationsLabelsContainRealLabels/0
in
https://ci.chromium.org/p/chromium/builders/luci.chromium.try/chromeos-amd64-generic-rel/45626

I'll add those tests to the bot's filter for now, but we probably want to be running them?

Comment 1 by bpastene@chromium.org, Jul 13

Cc: hiroh@chromium.org posciak@chromium.org
Hmm, it seems that this test was running in the chromeos-chrome ebuild until recently:
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1118925

It's a little unclear if running this suite on chrome's CrOS CQ would be useful. I'll work on adding it unless someone tells me otherwise.

Comment 2 by hiroh@chromium.org, Jul 14

Cc: bpastene@chromium.org
Hi, we haven't run this test on ChromeOS for a long time.
The CL just removed the non-used binary.
Please see my comment on the CL.
https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1118925#message-98b28f31c25c8dcb7a8d94972b32094bc4468efe

I think this is software test not depending on hardware resource, then technically can run on cros VMs.
From my perspective, running this test on chrome trybot is useful, since some other things, for example, parsers are used by Chrome OS HW video decoders.

Comment 3 by bpastene@chromium.org, Jul 16 

Ok, thanks for clearing that up. I'll work on adding it to the CQ (https://chromium-review.googlesource.com/c/chromium/src/+/1136884)

Comment 4 by dougman@chromium.org, Jul 23

Owner: bpastene@chromium.org
Status: Assigned (was: Untriaged)

Comment 5 by bpastene@chromium.org, Jul 23

Owner: ----
Status: Available (was: Assigned)
The suite's running in cros VMs, but is skipping the following tests due to the crash I filed this bug for:
https://chromium.googlesource.com/chromium/src/+/master/testing/buildbot/filters/chromeos.media_unittests.filter

Someone else will have to resolve that if we want them enabled.
►

Sign in to add a comment