New issue
Advanced search Search tips

Issue 863625 link

Starred by 2 users
Status: Fixed
Owner:
robliao@chromium.org
Closed: Jul 18
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Dragging a Tab Out the Tabstrip Triggers the New Window Animation

Project Member Reported by robliao@chromium.org, Jul 13 
1) Drag a tab out of the tabstrip so that it has to create a new window

EXPECTED:
New window just appears

ACTUAL:
New window animates

Comment 1 by robliao@chromium.org, Jul 13 

The equivalent version of 
https://cs.chromium.org/chromium/src/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm?l=319&rcl=29f92361cbf018cc8af847ac3cc4d52224d5a2d5

Need to be set up in the views codepath to accomplish the same thing.
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/55388b6fbd2b571230a861cc6e73e8ce21664186

commit 55388b6fbd2b571230a861cc6e73e8ce21664186
Author: Robert Liao <robliao@chromium.org>
Date: Tue Jul 17 15:43:08 2018

Forward Animate Property from BridgedNativeWidget to NSWindow

Scenarios like dragging a window out of the tabstrip disable animations.
This change forwards that request to NSWindow so the animation disable
request is respected.

BUG= 863625 

Change-Id: Ie25def791d30d35d7df804c4348fbad6cd0ae5ff
Reviewed-on: https://chromium-review.googlesource.com/1138814
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Robert Liao <robliao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575652}
[modify] https://crrev.com/55388b6fbd2b571230a861cc6e73e8ce21664186/ui/views/cocoa/bridged_native_widget.h
[modify] https://crrev.com/55388b6fbd2b571230a861cc6e73e8ce21664186/ui/views/cocoa/bridged_native_widget.mm
[modify] https://crrev.com/55388b6fbd2b571230a861cc6e73e8ce21664186/ui/views/widget/native_widget_mac.mm

Comment 3 by robliao@chromium.org, Jul 18

Status: Fixed (was: Assigned)
►

Sign in to add a comment