make merged private CLs public |
||||
Issue descriptiontalking to the GoB team, it looks like all CLs people had marked as draft were converted to Private during the gerrit->GoB migration. so we had a lot of CLs in the past that people had marked as draft and were merged which should have been marked as public/ready. the attached script should walk through all chrome-internal CLs/repos (which i think is fine since it's the internal GoB), and then walk through the CrOS related repos on the public chromium GoB. i prefiltered the CrOS project list to not bother searching repos that don't have any merged/private CLs already. it relies on the `gerrit` tool found in chromite, but that's part of every chromium & chromiumos checkout. if you want to clear out non-CrOS repos, you can easily update the projects array in the script with the ones you want to merge. the walk_gob script will slice queries on a year-by-year basis, but if it turns out that one year for a particular repo had too many results and causes query timeouts, you can re-enable the `for month` loop.
,
Aug 14
yes, i'd like someone with sufficient access to the two GoB instances to run the script. i have the ability to see the private CLs, but not to make them public.
,
Aug 14
Script looks sane to me. I guess I have to run from root of chromium checkout. Let's see...
,
Aug 14
chromium_gclient$ ./clear-private.sh Making CLs public on https://chrome-internal-review.googlesource.com/ Looking for CLs before:2012-01-01 ... found 0 Looking for CLs before:2013-01-01 ... found 0 Looking for CLs before:2014-01-01 ... found 0 Looking for CLs before:2015-01-01 ... found 0 Looking for CLs before:2016-01-01 ... found 0 Looking for CLs before:2017-01-01 ... found 4 Making *249918 public Making *262575 public Making *263967 public Making *311159 public Looking for CLs before:2018-01-01 ... found 5 Making *313249 public Making *328487 public Making *329446 public Making *383785 public Making *392408 public Looking for CLs before:2019-01-01 ... found 0 Chromium-review is next.
,
Aug 14
well, it's currently undoing private on CL 460029, so quite a few more to go...
,
Aug 14
odd, i can see a lot more chrome-internal CLs still marked private. are you able to see these CLs: https://chrome-internal-review.googlesource.com/c/chromeos/ap/wireless/+/407788 https://chrome-internal-review.googlesource.com/c/chromeos/platform/experimental-touch-fw/+/429484 https://chrome-internal-review.googlesource.com/c/chromeos/chromeos-admin/+/425252
,
Aug 14
Indeed, I can't see https://chrome-internal-review.googlesource.com/c/chromeos/ap/wireless/+/407788. Your script doesn't see them though. At least not under my credentials. I don't intend to work on this, so assigning to you. If you want to fix the script and ask me to re-run it, go ahead. We may also temporarily make you git admin, to make it easier for you.
,
Aug 14
i don't think the bug is in the script. it works if your account is authorized which it doesn't seem to be. similarly, my account isn't authorized, so i can't run it. if you want to elevate me temporarily on chrome-internal so i can run things directly, that'd be fine. i checked the list of CLs in the public chromium instance and it looks like you've cleared all of those successfully. thanks!
,
Aug 15
I can't easily make you admin of only chrome-internal, but I think you can be trusted to not interfere with other hosts.
,
Aug 15
two other git admins agreed with the above, so https://ganpati.corp.google.com/#MembershipProposal_Info?id=130144577 It should give you ~2 weeks to accomplish your goal.
,
Aug 15
thanks for all your help. i've cleared the private/merged backlog for all CrOS repos.
,
Aug 15
|
||||
►
Sign in to add a comment |
||||
Comment 1 by tandrii@chromium.org
, Aug 13