New issue
Advanced search Search tips

Issue 863607 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Sep 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug

Blocked on:
issue 863397
issue 882635
issue 887559

Blocking:
issue 884152



Sign in to add a comment

Migrate V8 bots to hermetic XCode toolchain

Project Member Reported by jbudorick@chromium.org, Jul 13

Issue description

https://chromium-swarm.appspot.com/bot?id=build106-m9 and https://chromium-swarm.appspot.com/bot?id=build205-m9 both appear to be missing their xcode installations. This is causing builds to fail, e.g. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20ASAN/18694

I'm pulling the two of them from the pool for now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/591275e8ffdf792bdae3d87174f04af88942facf

commit 591275e8ffdf792bdae3d87174f04af88942facf
Author: John Budorick <jbudorick@google.com>
Date: Fri Jul 13 22:44:18 2018

Blockedon: 863397
Owner: serg...@chromium.org
Status: Assigned (was: Untriaged)
This was likely only noticed now due to issue 863397, where these bots were re-imaged to 10.12.6. Looks like the image that was used didn't have XCode installed.
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 14

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/cb76dd9a681a4367362c098d4bb68c8c82db75c2

commit cb76dd9a681a4367362c098d4bb68c8c82db75c2
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Sat Jul 14 14:20:18 2018

Project Member

Comment 4 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/bd621c22f8a7fdeffdb218e5610432ee4331417e

commit bd621c22f8a7fdeffdb218e5610432ee4331417e
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Mon Jul 16 13:21:55 2018

Cc: -serg...@chromium.org jbudorick@chromium.org
XCode was installed on these bots as part of https://crbug.com/863397, however, Bev has pointed out that most chromium-swarm bots do not require XCode to be installed anymore. John, do you happen to know if it's possible to just download it during build from some GS bucket if missing?
Project Member

Comment 6 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/4d58364e109bcf3509a3a234af9d23dcfb155396

commit 4d58364e109bcf3509a3a234af9d23dcfb155396
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Mon Jul 16 13:36:33 2018

Project Member

Comment 7 by bugdroid1@chromium.org, Jul 16

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/160f1e567e3061aeefb2035bc70ab48c4b3c02ff

commit 160f1e567e3061aeefb2035bc70ab48c4b3c02ff
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Mon Jul 16 13:51:25 2018

Summary: Migrate V8 bots to hermetic XCode toolchain (was: 2 luci.v8.ci mac bots missing xcode)
Bryce has pointed me at  hermetic XCode toolchain at https://cs.chromium.org/chromium/src/build/mac_toolchain.py. I'll work on migrating our bots to this toolchain instead of requiring to have one installed manually on our bots.
Project Member

Comment 10 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/684d0856400d302c05d86106785e73eafe0db30d

commit 684d0856400d302c05d86106785e73eafe0db30d
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Wed Aug 08 19:48:40 2018

Checkout mac_toolchain on Mac V8 builders

R=machenbach@chromium.org

Bug:  chromium:863607 
Change-Id: I999770d1dafbafe8bbe60b575a940f6feb90fae0
Reviewed-on: https://chromium-review.googlesource.com/1165551
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#54990}
[modify] https://crrev.com/684d0856400d302c05d86106785e73eafe0db30d/DEPS

Blockedon: 882635
Status: Fixed (was: Assigned)
Filed issue 882635 to have one of the bots re-imaged without XCode. Once this is done and if nothing breaks, this issue can be marked as Verfiied.
Project Member

Comment 13 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/a636fa546b9b663cc0d60eefebb84621a4dfa011

commit a636fa546b9b663cc0d60eefebb84621a4dfa011
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Thu Sep 20 06:21:55 2018

Blocking: 884152
Project Member

Comment 15 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/bd31d0e0946594d6b89d28c553b5e3dc9503d43a

commit bd31d0e0946594d6b89d28c553b5e3dc9503d43a
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Thu Sep 20 15:48:13 2018

[V8] Download Mac toolchain on Mac bots

R=machenbach@chromium.org

Bug:  863607 
Change-Id: I719acfe63a9526f0f29822b2a710468eac8e1e17
Reviewed-on: https://chromium-review.googlesource.com/1235633
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_GC_Stress.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg_ng.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8/archive.expected/full_client_v8_official_V8_Official_Mac64_Debug.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_gc_stress_dbg.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/README.recipes.md
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_integration.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_baseline.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8/archive.expected/full_client_v8_official_V8_Official_Mac64.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___debug_builder.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel_ng.json
[modify] https://crrev.com/bd31d0e0946594d6b89d28c553b5e3dc9503d43a/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___release_builder.json

Project Member

Comment 16 by bugdroid1@chromium.org, Sep 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4

commit 3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Thu Sep 20 16:02:17 2018

Revert "[V8] Download Mac toolchain on Mac bots"

This reverts commit bd31d0e0946594d6b89d28c553b5e3dc9503d43a.

Reason for revert: bots lack needed credentials as they seem to be deployed to buildbot bots only, therefore I am starting to doubt that's the right way to download hermetic XCode on LUCI and will reach out to ChOps team before trying again

Original change's description:
> [V8] Download Mac toolchain on Mac bots
> 
> R=​machenbach@chromium.org
> 
> Bug:  863607 
> Change-Id: I719acfe63a9526f0f29822b2a710468eac8e1e17
> Reviewed-on: https://chromium-review.googlesource.com/1235633
> Reviewed-by: Michael Achenbach <machenbach@chromium.org>
> Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

TBR=machenbach@chromium.org,sergiyb@chromium.org

Change-Id: I650148d38fccedc117d513ed13cee9c3000adf75
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  863607 
Reviewed-on: https://chromium-review.googlesource.com/1236336
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_GC_Stress.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg_ng.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8/archive.expected/full_client_v8_official_V8_Official_Mac64_Debug.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_gc_stress_dbg.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/README.recipes.md
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_integration.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_baseline.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8/archive.expected/full_client_v8_official_V8_Official_Mac64.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___debug_builder.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel_ng.json
[modify] https://crrev.com/3ef3b9cd6b67cc1ffb7446dbbd9bec5eaa9779e4/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___release_builder.json

Status: Started (was: Assigned)
Blockedon: 887559
I'll work on issue 887559 (blocking this issue) to make this easier to setup.

FWIW, https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64%20-%20debug/20267 installed Xcode on build106-m9 and apparently accepted the license:

chrome-bot@build106-m9:(Mac 10.12.6):~$ cat /Library/Preferences/com.apple.dt.Xcode.plist
<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
	<key>IDELastGMLicenseAgreedTo</key>
	<string>EA1421</string>
	<key>IDEXcodeVersionForAgreedToGMLicense</key>
	<string>8.3.2</string>
</dict>
</plist>

However, the failed step is still attempting to search for a system Xcode:

ERROR at //build/config/mac/mac_sdk.gni:68:5: Script returned non-zero exit code.
    exec_script("//build/mac/find_sdk.py", find_sdk_args, "list lines")

This script should no longer be used. I believe, it will be avoided if the recipe sets DEVELOPER_DIR to the installed Xcode, or runs `xcode-select -s /path/to/Xcode.app`. In other words, the hermetic installation worked, but the subsequent steps didn't know where to look for the installed Xcode.
> This script should no longer be used.
This script is invoked by GN [1], so it must be used also on Chromium builders. Since we use the same scripts, it would be need to be removed on the Chromium side, not V8. In the meanwhile, we need to understand how it works with chromium recipes and make sure we do the same in V8 recipes.

> I believe, it will be avoided if the recipe sets DEVELOPER_DIR to the installed Xcode, or runs `xcode-select -s /path/to/Xcode.app`. In other words, the hermetic installation worked, but the subsequent steps didn't know where to look for the installed Xcode.

Looks like both osx_sdk [2] and chromium [3] recipe modules use xcode-select. Given that I've had issues using install_toolchains from chromium recipe module, I'll give a try to the osx_sdk.


[1]: https://cs.chromium.org/chromium/src/build/config/mac/mac_sdk.gni?l=68&rcl=eb0dd07017538e2bcbb0b649c6e407816b3bd69a
[2]: https://cs.chromium.org/chromium/tools/depot_tools/recipes/recipe_modules/osx_sdk/api.py?l=81&rcl=9cba9ffdfdc64127ee47561c0bd6a339778599f5
[3]: https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/api.py?l=842&rcl=d31d6bee383a13155c0323b4866e6feddb89e23b
CL: https://crrev.com/c/1238492

This should switch V8 bots from using system XCode to hermetic XCode and thus making those builds work on machines that do not have XCode pre-installed.
Project Member

Comment 22 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/d293e46f3dca19c00f56e4c6380e9e64d127047e

commit d293e46f3dca19c00f56e4c6380e9e64d127047e
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Mon Sep 24 14:04:01 2018

[V8] Ensure hermetic XCode is installed/used when running GN

Sample run: https://ci.chromium.org/swarming/task/4024a1f065e88210

TBR=machenbach@chromium.org

Bug:  863607 
Change-Id: I9b3c8445852635f4e0915ea0956e1ecb1e7e323e
Reviewed-on: https://chromium-review.googlesource.com/1238492
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_GC_Stress.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipe_modules/v8/api.py
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipe_modules/v8/__init__.py
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg_ng.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_gc_stress_dbg.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/README.recipes.md
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___debug_builder.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel_ng.json
[modify] https://crrev.com/d293e46f3dca19c00f56e4c6380e9e64d127047e/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___release_builder.json

Project Member

Comment 23 by bugdroid1@chromium.org, Sep 24

The following revision refers to this bug:
  https://chromium.googlesource.com/v8/v8.git/+/b308fc58337ff6a16c5add1a588003eb3c0319f9

commit b308fc58337ff6a16c5add1a588003eb3c0319f9
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Mon Sep 24 14:48:25 2018

Remove mac_toolchain hook as XCode is now installed via recipe

TBR=machenbach@chromium.org

Bug:  chromium:863607 
Change-Id: I1352bc236e7e236d70130db7fcc4333821fdec70
Reviewed-on: https://chromium-review.googlesource.com/1238924
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>
Reviewed-by: Sergiy Byelozyorov <sergiyb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#56178}
[modify] https://crrev.com/b308fc58337ff6a16c5add1a588003eb3c0319f9/DEPS

Project Member

Comment 24 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build/+/8c3842ea861df29f815df3d6e0bdfa626e4a893e

commit 8c3842ea861df29f815df3d6e0bdfa626e4a893e
Author: Sergiy Byelozyorov <sergiyb@chromium.org>
Date: Tue Sep 25 09:43:28 2018

[V8] Disable recipe logic that was required for mac_toolchain DEPS hook

R=machenbach@chromium.org

Bug:  863607 
Change-Id: I5916686312b8344f74ea805226d5e0feb2706516
Reviewed-on: https://chromium-review.googlesource.com/1238585
Reviewed-by: Michael Achenbach <machenbach@chromium.org>
Commit-Queue: Sergiy Byelozyorov <sergiyb@chromium.org>

[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_GC_Stress.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_dbg_ng.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_gc_stress_dbg.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64___debug.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___release_builder.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_client_v8_V8_Mac64_ASAN.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_asan_rel.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipe_modules/v8/chromium_config.py
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_baseline.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_client_v8_clusterfuzz_V8_Clusterfuzz_Mac64_ASAN___debug_builder.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_mac64_rel_ng.json
[modify] https://crrev.com/8c3842ea861df29f815df3d6e0bdfa626e4a893e/scripts/slave/recipes/v8/node_integration.expected/full_client_v8_fyi_V8_Mac64___node_js_integration.json

Project Member

Comment 25 by bugdroid1@chromium.org, Sep 25

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/infradata/config/+/4356a920a8a0ad4859b5e122d61b40789502e42b

commit 4356a920a8a0ad4859b5e122d61b40789502e42b
Author: Sergiy Byelozyorov <sergiyb@google.com>
Date: Tue Sep 25 16:42:12 2018

Status: Verified (was: Started)
This now working as intended. https://ci.chromium.org/p/v8/builders/luci.v8.ci/V8%20Mac64/24473 is an example of a successful build running on a bot imaged without system XCode.
Could you file a new bug for migrating all our mac bots to 10.13 without xcode? So that the one bot that was changed is not a one-off?
Filed issue 889408.

Sign in to add a comment