[PIP] PiP window sizes to be smaller than expected on mouseover |
||||||
Issue descriptionChrome Version: 69.0.3489.0 OS: Mac http://mounirlamouri.github.io/sandbox/media/dynamic-controls.html What steps will reproduce the problem? (1) Enter Picture-in-Picture (2) Resize window to be a bit bigger (sometimes too small doesn't trigger it) (3) Mouseover / Focus / Blur on Picture-in-Picture window. What is the expected result? No resizing happens unless explicitly dragging window edges. What happens instead? Part of window (and thus, video) is 'truncated'. It appears back in the expected size when interacting with the window.
,
Jul 14
sdy: Can you take a look? We haven't been able to repro on non-Mac platforms.
,
Jul 16
,
Jul 16
friendly ping :)
,
Jul 17
FYI: https://chromium-review.googlesource.com/c/chromium/src/+/1140923
,
Jul 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f3779f93a1cd3e8b8238f33753c1996af1e20c8 commit 1f3779f93a1cd3e8b8238f33753c1996af1e20c8 Author: Sidney San Martín <sdy@chromium.org> Date: Wed Jul 18 20:20:00 2018 Fix the PiP window jumping around on Mac. The PiP window has a simple layer tree and triggers the FSLP code path. But, this path didn't previously consider the video layer part of the area that needs a backdrop, so the backdrop layer (the root layer) was made too small. It would be better if this code just had access to the size of the page instead of having to guess by looking at the layer tree, but I don't think it does right now. Bug: 863580 Change-Id: Ib2e9ae24e98932b77b365a985dc956aa08287eb7 Reviewed-on: https://chromium-review.googlesource.com/1140923 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#576182} [modify] https://crrev.com/1f3779f93a1cd3e8b8238f33753c1996af1e20c8/ui/accelerated_widget_mac/ca_renderer_layer_tree.mm
,
Jul 19
Verified the fix on Mac 10.13.1 using Chrome version #69.0.3496.0 as per the comment #0. Attaching screen cast for reference. Observed that the video played well without getting resized. Hence, the fix is working as expected. Adding the verified labels. Note: Able to reproduce the issue on chrome version 69.0.3489.0 Thanks...!!
,
Jul 19
|
||||||
►
Sign in to add a comment |
||||||
Comment 1 by apaci...@chromium.org
, Jul 13