Static forwarding for common ports |
|||||||
Issue descriptionAllow developers to use localhost for common development server ports. Common ports: 5000, 8000, 8080, 8888 A couple others we could include: 3000 - express.js tutorial 9005 - Firebase login
,
Jul 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/tremplin/+/83d2ca771e9291de4ad904058a199f203f972c6b commit 83d2ca771e9291de4ad904058a199f203f972c6b Author: Stephen Barber <smbarber@chromium.org> Date: Fri Jul 20 03:12:56 2018 tremplin: trim whitespace on GetContainerUsername RPC BUG= chromium:863578 TEST=GetContainerUsername returns no LF character Change-Id: Iab91580df93293d651343b0696d37a3cf3bb9482 Reviewed-on: https://chromium-review.googlesource.com/1143021 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/83d2ca771e9291de4ad904058a199f203f972c6b/src/chromiumos/tremplin/tremplin.go
,
Jul 20
,
Jul 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/3865b4c144fdba47e14ace9a2d3b3803ee8282ef commit 3865b4c144fdba47e14ace9a2d3b3803ee8282ef Author: Stephen Barber <smbarber@chromium.org> Date: Sat Jul 21 20:18:59 2018 vm_tools: fix SSH key setup under tremplin Concierge needs to supply the correct SSH keys to set up a container, in addition to the keys needed to connect to the container. Adjust tremplin's startup RPC to use the correct keys. Also refactor the D-Bus call to request SSH keys, which will be shared with the SSH forwarding setup code in a follow-on CL. BUG= chromium:863578 TEST=files app works with tremplin CQ-DEPEND=CL:1142736,CL:1143022 Change-Id: Ie9142028a583007a7b853e98bcc2359998a1beb9 Reviewed-on: https://chromium-review.googlesource.com/1143023 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/3865b4c144fdba47e14ace9a2d3b3803ee8282ef/vm_tools/proto/tremplin.proto [modify] https://crrev.com/3865b4c144fdba47e14ace9a2d3b3803ee8282ef/vm_tools/cicerone/service.cc [modify] https://crrev.com/3865b4c144fdba47e14ace9a2d3b3803ee8282ef/vm_tools/concierge/service.cc [modify] https://crrev.com/3865b4c144fdba47e14ace9a2d3b3803ee8282ef/vm_tools/cicerone/service.h [modify] https://crrev.com/3865b4c144fdba47e14ace9a2d3b3803ee8282ef/vm_tools/cicerone/virtual_machine.h [modify] https://crrev.com/3865b4c144fdba47e14ace9a2d3b3803ee8282ef/vm_tools/cicerone/virtual_machine.cc
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/1c141e879626612e8fcc34245223ed15537b1aa6 commit 1c141e879626612e8fcc34245223ed15537b1aa6 Author: Stephen Barber <smbarber@chromium.org> Date: Tue Jul 24 04:04:52 2018 termina: allow TCP forwarding over SSH BUG= chromium:863578 TEST=manual ssh testing Change-Id: I5fba38f2a0cfed538d13bbd78883f5eaf01ff939 Reviewed-on: https://chromium-review.googlesource.com/1142470 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [rename] https://crrev.com/1c141e879626612e8fcc34245223ed15537b1aa6/project-termina/chromeos-base/termina-lxd-scripts/termina-lxd-scripts-0.0.1-r25.ebuild [modify] https://crrev.com/1c141e879626612e8fcc34245223ed15537b1aa6/project-termina/chromeos-base/termina-lxd-scripts/files/container_sshd_config
,
Jul 27
,
Jul 29
Please consider including 8085 so 'gcloud init' can work. The auth flow requires moving from the CLI within penguin to a browser tab. The end of the auth flow has to connect back to penguin and it tries localhost:8085 which is unfortunate. Due to the lack of 8085 forwarding in termina even if the user gets the IP right, it won't work.
,
Jul 30
Is this bug fixed and verified? If so, please submit merge request for M69.
,
Jul 30
Currently in the CQ, I'll verify and request a merge when ready. https://chromium-review.googlesource.com/c/chromiumos/platform2/+/1143124
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/24750a61211799ff0137ac16308b53347a68c78e commit 24750a61211799ff0137ac16308b53347a68c78e Author: Stephen Barber <smbarber@chromium.org> Date: Tue Jul 31 23:37:28 2018 vm_tools: cicerone: add support for SSH port forwards Add initial support for SSH forwarding of a few known ports. Port forwarding at this time only forwards to localhost on CrOS, not to other hosts on the same LAN. BUG= chromium:863578 TEST=install angular, curl localhost:4200 from CrOS host Change-Id: I321470cae4e0fcb1c58c99c5aecba4f7649d19cc Reviewed-on: https://chromium-review.googlesource.com/1143124 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/24750a61211799ff0137ac16308b53347a68c78e/vm_tools/cicerone/service.cc [modify] https://crrev.com/24750a61211799ff0137ac16308b53347a68c78e/vm_tools/init/vm_cicerone.conf [modify] https://crrev.com/24750a61211799ff0137ac16308b53347a68c78e/vm_tools/init/vm_cicerone-seccomp-arm.policy [modify] https://crrev.com/24750a61211799ff0137ac16308b53347a68c78e/vm_tools/cicerone/service.h [modify] https://crrev.com/24750a61211799ff0137ac16308b53347a68c78e/vm_tools/init/vm_cicerone-seccomp-amd64.policy
,
Aug 1
Verified on CrOS 10927.0.0/cros-termina 10927.0.0. Requesting merge to M69.
,
Aug 2
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/a7402fa5680763e1cc07b07dabdd71abdd7747c2 commit a7402fa5680763e1cc07b07dabdd71abdd7747c2 Author: Stephen Barber <smbarber@chromium.org> Date: Thu Aug 02 20:53:40 2018 vm_tools: cicerone: forward 8085 for gcloud init BUG= chromium:863578 TEST=gcloud init Change-Id: I2ef5766eeeadae470137a1c9182ee9da8ec8ed97 Reviewed-on: https://chromium-review.googlesource.com/1157663 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> [modify] https://crrev.com/a7402fa5680763e1cc07b07dabdd71abdd7747c2/vm_tools/cicerone/service.cc
,
Aug 6
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/board-overlays/+/e4c8eea228000bf283b5b0d4ee24d10f95f85a0e commit e4c8eea228000bf283b5b0d4ee24d10f95f85a0e Author: Stephen Barber <smbarber@chromium.org> Date: Mon Aug 06 18:38:01 2018 termina: allow TCP forwarding over SSH BUG= chromium:863578 TEST=manual ssh testing Change-Id: I5fba38f2a0cfed538d13bbd78883f5eaf01ff939 Reviewed-on: https://chromium-review.googlesource.com/1142470 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> (cherry picked from commit 1c141e879626612e8fcc34245223ed15537b1aa6) Reviewed-on: https://chromium-review.googlesource.com/1163963 Reviewed-by: Stephen Barber <smbarber@chromium.org> Commit-Queue: Stephen Barber <smbarber@chromium.org> [rename] https://crrev.com/e4c8eea228000bf283b5b0d4ee24d10f95f85a0e/project-termina/chromeos-base/termina-lxd-scripts/termina-lxd-scripts-0.0.1-r25.ebuild [modify] https://crrev.com/e4c8eea228000bf283b5b0d4ee24d10f95f85a0e/project-termina/chromeos-base/termina-lxd-scripts/files/container_sshd_config
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/bd5fc693476d4843bace89970f2a0838a43f0cd6 commit bd5fc693476d4843bace89970f2a0838a43f0cd6 Author: Stephen Barber <smbarber@chromium.org> Date: Mon Aug 06 19:00:04 2018 vm_tools: fix SSH key setup under tremplin Concierge needs to supply the correct SSH keys to set up a container, in addition to the keys needed to connect to the container. Adjust tremplin's startup RPC to use the correct keys. Also refactor the D-Bus call to request SSH keys, which will be shared with the SSH forwarding setup code in a follow-on CL. BUG= chromium:863578 TEST=files app works with tremplin CQ-DEPEND=CL:1142736,CL:1143022 Change-Id: Ie9142028a583007a7b853e98bcc2359998a1beb9 Reviewed-on: https://chromium-review.googlesource.com/1143023 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> (cherry picked from commit 3865b4c144fdba47e14ace9a2d3b3803ee8282ef) Reviewed-on: https://chromium-review.googlesource.com/1164082 Commit-Queue: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/bd5fc693476d4843bace89970f2a0838a43f0cd6/vm_tools/proto/tremplin.proto [modify] https://crrev.com/bd5fc693476d4843bace89970f2a0838a43f0cd6/vm_tools/cicerone/service.cc [modify] https://crrev.com/bd5fc693476d4843bace89970f2a0838a43f0cd6/vm_tools/concierge/service.cc [modify] https://crrev.com/bd5fc693476d4843bace89970f2a0838a43f0cd6/vm_tools/cicerone/service.h [modify] https://crrev.com/bd5fc693476d4843bace89970f2a0838a43f0cd6/vm_tools/cicerone/virtual_machine.h [modify] https://crrev.com/bd5fc693476d4843bace89970f2a0838a43f0cd6/vm_tools/cicerone/virtual_machine.cc
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/28ec1a27942d61e853911c5322e19dafd8a99265 commit 28ec1a27942d61e853911c5322e19dafd8a99265 Author: Stephen Barber <smbarber@chromium.org> Date: Mon Aug 06 19:19:18 2018 vm_tools: cicerone: add support for SSH port forwards Add initial support for SSH forwarding of a few known ports. Port forwarding at this time only forwards to localhost on CrOS, not to other hosts on the same LAN. BUG= chromium:863578 TEST=install angular, curl localhost:4200 from CrOS host Change-Id: I321470cae4e0fcb1c58c99c5aecba4f7649d19cc Reviewed-on: https://chromium-review.googlesource.com/1143124 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Stephen Barber <smbarber@chromium.org> (cherry picked from commit 24750a61211799ff0137ac16308b53347a68c78e) Reviewed-on: https://chromium-review.googlesource.com/1164086 Commit-Queue: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/28ec1a27942d61e853911c5322e19dafd8a99265/vm_tools/cicerone/service.cc [modify] https://crrev.com/28ec1a27942d61e853911c5322e19dafd8a99265/vm_tools/init/vm_cicerone.conf [modify] https://crrev.com/28ec1a27942d61e853911c5322e19dafd8a99265/vm_tools/init/vm_cicerone-seccomp-arm.policy [modify] https://crrev.com/28ec1a27942d61e853911c5322e19dafd8a99265/vm_tools/cicerone/service.h [modify] https://crrev.com/28ec1a27942d61e853911c5322e19dafd8a99265/vm_tools/init/vm_cicerone-seccomp-amd64.policy
,
Aug 6
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/cac33f7573140a536a7c5e5c48cfe27284c85336 commit cac33f7573140a536a7c5e5c48cfe27284c85336 Author: Stephen Barber <smbarber@chromium.org> Date: Mon Aug 06 19:19:53 2018 vm_tools: cicerone: forward 8085 for gcloud init BUG= chromium:863578 TEST=gcloud init Change-Id: I2ef5766eeeadae470137a1c9182ee9da8ec8ed97 Reviewed-on: https://chromium-review.googlesource.com/1157663 Commit-Ready: Stephen Barber <smbarber@chromium.org> Tested-by: Stephen Barber <smbarber@chromium.org> Reviewed-by: Chirantan Ekbote <chirantan@chromium.org> (cherry picked from commit a7402fa5680763e1cc07b07dabdd71abdd7747c2) Reviewed-on: https://chromium-review.googlesource.com/1164087 Reviewed-by: Stephen Barber <smbarber@chromium.org> Commit-Queue: Stephen Barber <smbarber@chromium.org> [modify] https://crrev.com/cac33f7573140a536a7c5e5c48cfe27284c85336/vm_tools/cicerone/service.cc
,
Aug 6
Verified with component version 10895.16.0
,
Aug 23
Is there any way to get port 4200 added? This is the most common port used by Angular developers.
,
Aug 23
Port 4200 is already on the list :) https://chromium.googlesource.com/chromiumos/platform2/+/4ee65cf0f6e22136659fa786ef844a384b1d8e1e/vm_tools/cicerone/service.cc#75
,
Sep 14
Is there a way we can add Sonos ports to this? https://support.sonos.com/s/article/688?language=en_US&utm_medium=firewall&utm_source=cr-care&utm_content=english-cr-care-firewall It's quite a lot but given that the Android app does not work, it would be useful to have crostini save the day.
,
Sep 14
This bug is for tracking port forwarding from Chrome OS (localhost) to the Linux container. It won't help for sonos unfortunately.
,
Sep 15
Thanks got it, In that case can we add the port used by RStudio Server - 8787? It's a very popular Data Science IDE focused on R; the equivalent of Jupyter in the Python world. |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by tbuck...@chromium.org
, Jul 13