New issue
Advanced search Search tips

Issue 863566 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Remove RequestPathAccess from Chrome OS permission_broker

Project Member Reported by reillyg@chromium.org, Jul 13

Issue description

This method is no longer used by any clients as it has been replaced by the OpenPath method which does not require changing the permission on any device nodes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/system_api/+/054c50d2fb2c1c2fb42957459e0b275e376d2776

commit 054c50d2fb2c1c2fb42957459e0b275e376d2776
Author: Reilly Grant <reillyg@chromium.org>
Date: Thu Jul 19 19:14:05 2018

system_api: Remove permission_broker RequestPathAccess method

This method has been removed from the permission_broker's DBus API.

BUG=chromium:863566
TEST=cros_workon_make system_api --test

Change-Id: I4005a605006eb29597e9b065e7848e0fdeeadb85
Reviewed-on: https://chromium-review.googlesource.com/1137057
Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com>
Tested-by: Reilly Grant <reillyg@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>

[modify] https://crrev.com/054c50d2fb2c1c2fb42957459e0b275e376d2776/dbus/permission_broker/dbus-constants.h

Cc: ejcaruso@chromium.org
I have a pile of unlanded patches to do this but I was having a lot of trouble getting them reviewed and checked in in the right order so I put it on the back burner. I can put links here if you would like to pick it up.
Project Member

Comment 4 by bugdroid1@chromium.org, Nov 28

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/docs/+/c1851ddfa692973defd72c3c4d2299e45d2d586f

commit c1851ddfa692973defd72c3c4d2299e45d2d586f
Author: Eric Caruso <ejcaruso@chromium.org>
Date: Wed Nov 28 00:29:20 2018

permission_broker: Remove references to devbroker-access group

This is now unused and deprecated.

BUG=chromium:863566
TEST=None

Change-Id: I3e089cca30822a1a224b72fcee0d4dcd2681ef42
Reviewed-on: https://chromium-review.googlesource.com/1351556
Commit-Ready: Eric Caruso <ejcaruso@chromium.org>
Tested-by: Eric Caruso <ejcaruso@chromium.org>
Reviewed-by: Mike Frysinger <vapier@chromium.org>

[modify] https://crrev.com/c1851ddfa692973defd72c3c4d2299e45d2d586f/sandboxing.md

Project Member

Comment 5 by bugdroid1@chromium.org, Nov 30

Status: Fixed (was: Assigned)
Cc: -ejcaruso@chromium.org reillyg@chromium.org
Owner: ejcaruso@chromium.org
Status: Assigned (was: Fixed)
There are three more patches needed to remove the devbroker-access group:

 * https://chromium-review.googlesource.com/c/chromiumos/overlays/eclass-overlay/+/1136497
 * https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1137104
 * https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1137065
Sure, I didn't know if this was in scope for this bug or not.

Sign in to add a comment