Remove RequestPathAccess from Chrome OS permission_broker |
||||
Issue descriptionThis method is no longer used by any clients as it has been replaced by the OpenPath method which does not require changing the permission on any device nodes.
,
Nov 20
,
Nov 20
I have a pile of unlanded patches to do this but I was having a lot of trouble getting them reviewed and checked in in the right order so I put it on the back burner. I can put links here if you would like to pick it up.
,
Nov 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/docs/+/c1851ddfa692973defd72c3c4d2299e45d2d586f commit c1851ddfa692973defd72c3c4d2299e45d2d586f Author: Eric Caruso <ejcaruso@chromium.org> Date: Wed Nov 28 00:29:20 2018 permission_broker: Remove references to devbroker-access group This is now unused and deprecated. BUG=chromium:863566 TEST=None Change-Id: I3e089cca30822a1a224b72fcee0d4dcd2681ef42 Reviewed-on: https://chromium-review.googlesource.com/1351556 Commit-Ready: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Mike Frysinger <vapier@chromium.org> [modify] https://crrev.com/c1851ddfa692973defd72c3c4d2299e45d2d586f/sandboxing.md
,
Nov 30
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa commit e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa Author: Reilly Grant <reillyg@chromium.org> Date: Fri Nov 30 03:31:18 2018 permission_broker: Remove unused RequestPathAccess method This method has been deprecated in favor of OpenPath but has not been removed. Removing this method allows us to also remove the devbroker-access group. BUG=chromium:863566 TEST=Compiled and ran unit tests. Change-Id: I0c5735652a7bde6f451699cede8638a2f3388d72 Reviewed-on: https://chromium-review.googlesource.com/1136469 Commit-Ready: Eric Caruso <ejcaruso@chromium.org> Tested-by: Eric Caruso <ejcaruso@chromium.org> Reviewed-by: Dan Erat <derat@chromium.org> [modify] https://crrev.com/e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa/permission_broker/dbus_bindings/org.chromium.PermissionBroker.xml [modify] https://crrev.com/e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa/permission_broker/permission_broker.conf [modify] https://crrev.com/e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa/permission_broker/permission_broker_main.cc [modify] https://crrev.com/e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa/permission_broker/permission_broker.cc [modify] https://crrev.com/e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa/permission_broker/dbus/org.chromium.PermissionBroker.conf [modify] https://crrev.com/e40c56215fc88d9c00d4bc359d9bbe16ec94f8fa/permission_broker/permission_broker.h
,
Nov 30
,
Dec 4
There are three more patches needed to remove the devbroker-access group: * https://chromium-review.googlesource.com/c/chromiumos/overlays/eclass-overlay/+/1136497 * https://chromium-review.googlesource.com/c/chromiumos/chromite/+/1137104 * https://chromium-review.googlesource.com/c/chromiumos/overlays/chromiumos-overlay/+/1137065
,
Dec 4
Sure, I didn't know if this was in scope for this bug or not. |
||||
►
Sign in to add a comment |
||||
Comment 1 by bugdroid1@chromium.org
, Jul 19