New issue
Advanced search Search tips

Issue 863551 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Nov 1
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 2
Type: Bug


Show other hotlists

Hotlists containing this issue:
Modern-Media-Controls


Sign in to add a comment

[Media Controls] Overflow truncates Picture-in-Picture text.

Project Member Reported by apaci...@chromium.org, Jul 13

Issue description

On tip of tree:

1. Navigate to video and enter Picture-in-Picture.
2. On the video, click on the overflow menu and notice "Exit Picture-in-Picture" is truncated.

Example: https://w3.org/2010/05/video/mediaevents.html

We should make sure the overflow menu is wide enough for the menu items.
 
Screenshot from 2018-07-13 13-12-05.png
26.2 KB View Download
Cc: steimel@chromium.org
Owner: amyroberts@chromium.org
Status: Assigned (was: Untriaged)
Assigning to amyroberts@ for input. Do we want to increase the width of the overflow menu in order to increase the chances of the text showing up or should we look into reducing the text length?

My concerns with increasing the width of the menu is that it will look fairly empty when not in Picture-in-Picture and the strings are language dependant so we may be optimising for English. We could try to be smart about the width of the menu and have it flexible but it may create an inconsistent experience.
mlamouri: adding you to email thread
Project Member

Comment 3 by bugdroid1@chromium.org, Oct 30

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e981d4eaffaf23c9766dc2ac4687e1616571f260

commit e981d4eaffaf23c9766dc2ac4687e1616571f260
Author: Jazz Xu <jazzhsu@chromium.org>
Date: Tue Oct 30 01:06:10 2018

[Media Controls] Enlarge overflow menu

Adjust overflow menu and track list width
to 260px so it won't truncate exit PiP text.

Bug:  863551 
Change-Id: Ie12c79eb15a06554a63fbb082d82e1ab523869a2
Reviewed-on: https://chromium-review.googlesource.com/c/1302574
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Jazz Xu <jazzhsu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603713}
[modify] https://crrev.com/e981d4eaffaf23c9766dc2ac4687e1616571f260/third_party/blink/renderer/modules/media_controls/resources/modernMediaControls.css

Labels: TE-Verified-M72 TE-Verified-72.0.3598.0
Able to reproduce this issue on Windows 10, Mac OS 10.13.3 and Ubuntu 17.10 on the build without fix 70.0.3538.77 and the issue is fixed on the latest M-72 build 72.0.3598.0.

1. Launched Chrome and navigated to https://w3.org/2010/05/video/mediaevents.html
2. Played the video and clicked on the 3-dot menu.
3. Clicked on Picture-in-Picture option and entered into picture-in-picture mode.
3. Clicked on the 3 dot menu again and can observe that the text is not truncated.
Attached is the screen shot for reference. 

Hence adding TE verified labels as the fix is working as intended.

Thanks..
863551-M72.png
288 KB View Download
Labels: -TE-Verified-M72 -TE-Verified-72.0.3598.0
Status: Fixed (was: Assigned)

Sign in to add a comment