New issue
Advanced search Search tips

Issue 863549 link

Starred by 2 users
Status: Fixed
Owner:
thakis@chromium.org
Closed: Nov 26
Cc:
a...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocked on:
issue 768586


Sign in to add a comment

git cl format: weird formatting for ternary in ObjC message send

Project Member Reported by a...@chromium.org, Jul 13 
In https://chromium-review.googlesource.com/c/chromium/src/+/1135718 there is the line:

  [(newCursor ? newCursor : [NSCursor arrowCursor]) set];

git cl format wants to make it:

  [(newCursor ? newCursor : [NSCursor arrowCursor])set];

which is... weird.

Assigning to you, Nico; dunno who else is in this area. Reassign as necessary.

Comment 1 by thakis@chromium.org, Jul 13

Labels: clang-format
It's clang-format's way of letting you know that your code is too clever :-)

Comment 2 by thakis@chromium.org, Nov 21

Blockedon: 768586
Summary: git cl format: weird formatting for ternary in ObjC message send (was: git cl format: weird formatting)
Looks like this got fixed in yesterday's clang-format roll.

Comment 3 by thakis@chromium.org, Nov 26

Status: Fixed (was: Assigned)
A clang-format with the fix got deployed on Nov 21 2018.
►

Sign in to add a comment