New issue
Advanced search Search tips

Issue 863533 link

Starred by 2 users
Status: Fixed
Owner:
mthiesse@chromium.org
Closed: Jul 14
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

VR Intent launches getting double-counted

Project Member Reported by mthiesse@chromium.org, Jul 13 
VrShellDelegate#onVrIntent() calls nativeRecordVrStartAction(mNativeVrShellDelegate, VrStartAction.INTENT_LAUNCH); twice.

This is clearly wrong, and we're double-counting our VR intent entrys into Chrome.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/98a181f29a83390caefa3f1a8d9150663c585b8d

commit 98a181f29a83390caefa3f1a8d9150663c585b8d
Author: Michael Thiessen <mthiesse@chromium.org>
Date: Fri Jul 13 20:24:53 2018

VR: Avoid double-counting VR intent entry metric.

Bug:  863533 
Change-Id: If0579797b75f45308c50ddbf55ac19f007b7e12f
Reviewed-on: https://chromium-review.googlesource.com/1136907
Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org>
Commit-Queue: Michael Thiessen <mthiesse@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575052}
[modify] https://crrev.com/98a181f29a83390caefa3f1a8d9150663c585b8d/chrome/android/java/src/org/chromium/chrome/browser/vr/VrShellDelegate.java

Comment 2 by mthiesse@chromium.org, Jul 14

Status: Fixed (was: Started)
►

Sign in to add a comment