New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863527 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 13
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Dashboard - Failures in /add_histograms_queue with keyerror

Project Member Reported by simonhatch@chromium.org, Jul 13

Issue description

Pretty sure that ReplaceSharedDiagnostic optimization I did broke something, investigating.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/be45355b46d9b45aa9581f0d439bffcfe929ef20

commit be45355b46d9b45aa9581f0d439bffcfe929ef20
Author: Simon <simonhatch@chromium.org>
Date: Fri Jul 13 19:59:13 2018

Dashboard - Fix fast path in ReplaceSharedDiagnostic

Dashboard feeds a single histogram with no diagnostics into a histogram
set, and uses ReplaceSharedDiagnostics with refs in
/add_histograms_queue, so we can't expect the old diagnostic to exist
in the histogramset.

Bug:  chromium:863527 
Change-Id: Ib1db8a57baf82521ff75fca7890f07fc1352121e
Reviewed-on: https://chromium-review.googlesource.com/1136463
Reviewed-by: Ethan Kuefner <eakuefner@chromium.org>
Commit-Queue: Simon Hatch <simonhatch@chromium.org>

[modify] https://crrev.com/be45355b46d9b45aa9581f0d439bffcfe929ef20/tracing/tracing/value/histogram_set.py

Owner: simonhatch@chromium.org
Status: Fixed (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8f9c8577cf71fca7c7134d1c80c7728deed023db

commit 8f9c8577cf71fca7c7134d1c80c7728deed023db
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Jul 13 22:09:23 2018

Roll src/third_party/catapult a738c2067f78..be45355b46d9 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/a738c2067f78..be45355b46d9


git log a738c2067f78..be45355b46d9 --date=short --no-merges --format='%ad %ae %s'
2018-07-13 simonhatch@chromium.org Dashboard - Fix fast path in ReplaceSharedDiagnostic
2018-07-13 dtu@chromium.org [pinpoint] Pass in `--non-telemetry true` for non-Telemetry tests.


Created with:
  gclient setdep -r src/third_party/catapult@be45355b46d9

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:863527 
TBR=sullivan@chromium.org

Change-Id: I34a564feca7d7fbd65d88ffca3f9d238da94e70a
Reviewed-on: https://chromium-review.googlesource.com/1136951
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#575089}
[modify] https://crrev.com/8f9c8577cf71fca7c7134d1c80c7728deed023db/DEPS

Sign in to add a comment