Issue metadata
Sign in to add a comment
|
"FATAL:client_image_registry.cc(22): Check failed: false." causing mash_browser_tests failures on linux-chromeos-rel |
||||||||||||||||||||||
Issue descriptionExample failures: SupervisedUserBlockModeTest.Unblock/0 https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/42709 ExtensionWebstorePrivateApiTestChild.InstallBlocked https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux-chromeos-rel/46902 https://chromium-swarm.appspot.com/task?id=3e994be97f506e10&refresh=10&show_raw=1 https://chromium-swarm.appspot.com/task?id=3eada6a720dd1d10&refresh=10&show_raw=1 Same failure mode in both cases. Stack trace: [1:8:0709/122637.127333:ERROR:layer_tree_host_impl.cc(2991)] Forcing zero-copy tile initialization as worker context is missing [30478:30478:0709/122637.150837:ERROR:render_widget_host_view_aura.cc(1229)] Not implemented reached in virtual base::i18n::TextDirection content::RenderWidgetHostViewAura::GetTextDirection() const [30565:30565:0709/122636.778956:FATAL:client_image_registry.cc(22)] Check failed: false. #0 0x000004a9fa6c base::debug::StackTrace::StackTrace() #1 0x000004a08b6b logging::LogMessage::~LogMessage() #2 0x000007723984 ash::ClientImageRegistry::GetImage() #3 0x00000762c99d ash::(anonymous namespace)::WindowPropertyAppearanceProvider::GetFrameHeaderImage() #4 0x00000774bf4d ash::CustomFrameHeader::PaintFrameImages() #5 0x00000774bec4 ash::CustomFrameHeader::DoPaintHeader() #6 0x0000056fcb06 views::View::Paint() #7 0x0000056fed03 views::View::RecursivePaintHelper() #8 0x0000056feb34 views::View::PaintChildren() #9 0x0000056fcb34 views::View::Paint() #10 0x0000056ffe9b views::View::OnPaintLayer() #11 0x000006840a08 ui::Layer::PaintContentsToDisplayList() #12 0x000006840b72 ui::Layer::PaintContentsToDisplayList() #13 0x0000065d3a0e cc::PictureLayer::Update() #14 0x00000662cbca cc::LayerTreeHost::PaintContent() #15 0x00000662c135 cc::LayerTreeHost::DoUpdateLayers() #16 0x00000662b297 cc::LayerTreeHost::UpdateLayers() #17 0x00000663b4b2 cc::SingleThreadProxy::BeginMainFrame() #18 0x000001adc700 _ZN4base8internal7InvokerINS0_9BindStateIMN8chromeos36KioskExternalUpdateValidatorDelegateEFvRKNSt3__112basic_stringIcNS5_11char_traitsIcEENS5_9allocatorIcEEEEEJNS_7WeakPtrIS4_EESB_EEEFvvEE7RunOnceEPNS0_13BindStateBaseE #19 0x000004ac0d35 base::debug::TaskAnnotator::RunTask() #20 0x000004ac70c9 base::internal::IncomingTaskQueue::RunTask() #21 0x000004a10eab base::MessageLoop::RunTask() #22 0x000004a1123a base::MessageLoop::DeferOrRunPendingTask() #23 0x000004a11537 base::MessageLoop::DoWork() #24 0x000004abba79 base::MessagePumpLibevent::Run() #25 0x000004a10894 base::MessageLoop::Run() #26 0x000004a37239 base::RunLoop::Run() #27 0x000004978952 content::UtilityMain() #28 0x000004991f98 content::ContentMainRunnerImpl::Run() #29 0x000006a4818b service_manager::Main() #30 0x000004990334 content::ContentMain() #31 0x000005094e89 content::LaunchTests() #32 0x0000049ebb03 LaunchChromeTests() #33 0x0000049eb5de main #34 0x7f0fbdf01f45 __libc_start_main #35 0x0000005f98ba _start This is affecting the commit queue and causing random tests to fail. Marking P1.
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fe587230f593c4b67cc977807afdb9daa8f6c806 commit fe587230f593c4b67cc977807afdb9daa8f6c806 Author: Scott Violet <sky@chromium.org> Date: Fri Jul 13 20:20:03 2018 chromeos: removes NOTREACHED in client_image_registry Having a NOTREACHED here is problematic for two reasons: . A bad client could trigger the NOTREACHED by setting a random value. . Because the registry is a separate pipe then that to the WindowService it is entirely possible for the property to be set on the window before the property has been set in the registry. BUG= 863520 TEST=none TBR=estade@chromium.org Change-Id: I08b047e871c39d46cfcd548b078df6af9e334032 Reviewed-on: https://chromium-review.googlesource.com/1136937 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#575045} [modify] https://crrev.com/fe587230f593c4b67cc977807afdb9daa8f6c806/ash/client_image_registry.cc
,
Jul 13
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by sky@chromium.org
, Jul 13Status: Started (was: Untriaged)