Issue metadata
Sign in to add a comment
|
amd-generic-asan cryptohome unittest failing |
||||||||||||||||||||||||
Issue descriptionhttps://cros-goldeneye.corp.google.com/chromeos/healthmonitoring/buildDetails?buildbucketId=8941112536668307072 cryptohome-0.0.1-r2599: ../../../../../../../tmp/portage/chromeos-base/cryptohome-0.0.1-r2599/work/cryptohome-0.0.1/platform2/cryptohome/sign_in_hash_tree_unittest.cc:138: Failure cryptohome-0.0.1-r2599: Expected: false cryptohome-0.0.1-r2599: To be equal to: metadata_lost cryptohome-0.0.1-r2599: Which is: true cryptohome-0.0.1-r2599: terminating with uncaught exception of type testing::internal::GoogleTestFailureException: ../../../../../../../tmp/portage/chromeos-base/cryptohome-0.0.1-r2599/work/cryptohome-0.0.1/platform2/cryptohome/sign_in_hash_tree_unittest.cc:138: Failure cryptohome-0.0.1-r2599: Expected: false cryptohome-0.0.1-r2599: To be equal to: metadata_lost cryptohome-0.0.1-r2599: Which is: true cryptohome-0.0.1-r2599: Error: /var/cache/portage/chromeos-base/cryptohome/out/Default/cryptohome_testrunner: failed with signal SIGIOT|SIGABRT(6) cryptohome-0.0.1-r2599: * ERROR: chromeos-base/cryptohome-0.0.1-r2599::chromiumos failed (test phase):
,
Jul 19
I'm not sure why this is failing. the GetLabelData() call should not affect metadata_lost() since this isn't a leaf label. So it should return false (whatever it's original value is). How is this builder different from the other usual builders?
,
Jul 19
My guess (without other knowledge) is that metadata_lost is an automatic variable, and so it's left uninitialized, and this build initializes it to true, whereas the test assumes false. Is there any way I can run this locally to confirm a fix?
,
Jul 20
USE=asan FEATURES=test emerge-amd64-generic cryptohome should repro the problem.
,
Jul 23
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/d03ffebd80a49b1cfaf5d28fca513604259dd2ea commit d03ffebd80a49b1cfaf5d28fca513604259dd2ea Author: Prashant Malani <pmalani@google.com> Date: Tue Jul 24 04:05:02 2018 cryptohome: Fix ASAN error in SignInHashTree unit_tests. Running SignInHashTreeUnitTest with ASAN causes the uninitialized metadata_lost variable to be set to true, whereas the functions being tested don't touch it. So, explicitly set it to false, so that the subsequent EXPECT_EQ checks don't break. BUG= chromium:863517 TEST=USE=asan FEATURES=test emerge-amd64-generic cryptohome passes. Change-Id: I0f1b41acea111b0ce84b3bac92b5ff32639ead58 Reviewed-on: https://chromium-review.googlesource.com/1145783 Commit-Ready: Prashant Malani <pmalani@google.com> Tested-by: Prashant Malani <pmalani@google.com> Reviewed-by: Andrey Pronin <apronin@chromium.org> [modify] https://crrev.com/d03ffebd80a49b1cfaf5d28fca513604259dd2ea/cryptohome/sign_in_hash_tree_unittest.cc
,
Jul 24
|
|||||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||||
Comment 1 by apronin@chromium.org
, Jul 13