New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863516 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 14
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[test cleanup] touch_UpdateErrors fails with 'Touch firmware did not attempt update.' for several boards

Project Member Reported by ka...@chromium.org, Jul 13

Issue description

Failure dashboard view screenshot: https://screenshot.googleplex.com/Ge3fhCiTjAk
Per test type(pad,screen, stylus): https://screenshot.googleplex.com/A3dpSdX2AmA

The failure is at high fail rate, if not consistent.

Affected boards:
- eve
- pyro
- soraka
(few other with no official FW boards fail as expected)



 
Cc: kathrelk...@chromium.org pbath...@chromium.org
Labels: touch-cleanup
Labels: -Pri-3 Pri-2
Owner: ka...@chromium.org
Test failure is spread to many boards
corla - https://screenshot.googleplex.com/0sqHceaCZA2
eve - https://screenshot.googleplex.com/ADDonoKHW72

AI: Locate the issue and fix the failed attempt.
Labels: -Pri-2 Pri-1
Forgot to mention - failures affect now too many boards - atlas
coral
eve
eve-arcnext
grunt
nocturne
octopus
pyro
sentry
soraka

Changing to Pri-1
One more finding - it is not a flake, but consistent failure on all boards not passing the test.
Few reasons for failures observed:
1) Unreleased boards - touch-firmware-update do not execute yet
A way to solve this is to add test dependency 'phase:PVT' which is pretty much added after the board release. 

2) Some boards have different touch-firmware-update log output than the expected  match in regext 'Product[^a-z0-9]ID[^a-z0-9]*', e.g.

- eve, soraka, pyro - NOTICE chromeos-wacom-touch-firmware-update[1666]: Device product id detected as: 5143
A way to resolve this is to change the regexp in touch_UpdateErrors.py?l=100


3) Some boards error out with - "No touchpad found on this device!"
- touchpad - terra - host chromeos4-row8-rack7-host16. It apears there is no such event source per evtest, and should be checked out by lab team with  issue 863254 
- touchscreen - samus - host chromeos4-row12-rack5-host5 - no TS item in evtest output. Bad board or disconnected cable interface.





Project Member

Comment 7 by bugdroid1@chromium.org, Dec 12

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/65e0fb986e5dfc4fac1f310a084d294d6be29b04

commit 65e0fb986e5dfc4fac1f310a084d294d6be29b04
Author: Kalin Stoyanov <kalin@chromium.org>
Date: Wed Dec 12 21:55:50 2018

Relax the hw id match from FW updater log.

- move hw_id within match of updater string
- also changing test dependency to match only late provision boards

BUG= chromium:863516 
TEST=Ran the test on several boards in lab.

Change-Id: I9812da853013af6f9d435bd496d8aa8b0cef88b9
Reviewed-on: https://chromium-review.googlesource.com/1368492
Commit-Ready: Kalin Stoyanov <kalin@chromium.org>
Tested-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>

[modify] https://crrev.com/65e0fb986e5dfc4fac1f310a084d294d6be29b04/client/site_tests/touch_UpdateErrors/control.stylus
[modify] https://crrev.com/65e0fb986e5dfc4fac1f310a084d294d6be29b04/client/site_tests/touch_UpdateErrors/touch_UpdateErrors.py
[modify] https://crrev.com/65e0fb986e5dfc4fac1f310a084d294d6be29b04/client/site_tests/touch_UpdateErrors/control.touchscreen
[modify] https://crrev.com/65e0fb986e5dfc4fac1f310a084d294d6be29b04/client/site_tests/touch_UpdateErrors/control.touchpad

Labels: Merge-Request-72
Status: Fixed (was: Untriaged)
At least three boards have improved test results. Requesting merge to M72.
Project Member

Comment 9 by sheriffbot@chromium.org, Dec 14

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Cc: djmm@chromium.org
+tpm
Cc: bhthompson@chromium.org
Cc: -bhthompson@chromium.org dgagnon@chromium.org
Labels: -Hotlist-Merge-Review -Merge-Review-72 Merge-Approved-72
Project Member

Comment 14 by bugdroid1@chromium.org, Dec 19

Labels: merge-merged-release-R72-11316.B
The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/6ce0766b1fdf2f9bf675177850233cbfbf58b986

commit 6ce0766b1fdf2f9bf675177850233cbfbf58b986
Author: Kalin Stoyanov <kalin@chromium.org>
Date: Wed Dec 19 18:47:37 2018

Relax the hw id match from FW updater log.

- move hw_id within match of updater string
- also changing test dependency to match only late provision boards

BUG= chromium:863516 
TEST=Ran the test on several boards in lab.

Change-Id: I9812da853013af6f9d435bd496d8aa8b0cef88b9
Reviewed-on: https://chromium-review.googlesource.com/1368492
Commit-Ready: Kalin Stoyanov <kalin@chromium.org>
Tested-by: Kalin Stoyanov <kalin@chromium.org>
Reviewed-by: Katherine Threlkeld <kathrelkeld@chromium.org>
(cherry picked from commit 65e0fb986e5dfc4fac1f310a084d294d6be29b04)
Reviewed-on: https://chromium-review.googlesource.com/c/1382803
Commit-Queue: Kalin Stoyanov <kalin@chromium.org>

[modify] https://crrev.com/6ce0766b1fdf2f9bf675177850233cbfbf58b986/client/site_tests/touch_UpdateErrors/control.stylus
[modify] https://crrev.com/6ce0766b1fdf2f9bf675177850233cbfbf58b986/client/site_tests/touch_UpdateErrors/touch_UpdateErrors.py
[modify] https://crrev.com/6ce0766b1fdf2f9bf675177850233cbfbf58b986/client/site_tests/touch_UpdateErrors/control.touchscreen
[modify] https://crrev.com/6ce0766b1fdf2f9bf675177850233cbfbf58b986/client/site_tests/touch_UpdateErrors/control.touchpad

Project Member

Comment 15 by sheriffbot@chromium.org, Dec 24

Cc: dgagnon@google.com
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 16 by sheriffbot@chromium.org, Dec 28

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Sign in to add a comment