New issue
Advanced search Search tips

Issue 863513 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 28
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

SMB: Remount on reboot does not work for shares mounted by hostname

Project Member Reported by baileyberro@chromium.org, Jul 13

Issue description

When an SMB Share is mounted using a hostname rather than the IP address, it is not remounted when a user logs out and back in.
 
Labels: -Pri-3 Pri-1
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0564a5eed2fa1ea436fbfaee10fdfacec8aef057

commit 0564a5eed2fa1ea436fbfaee10fdfacec8aef057
Author: Bailey Berro <baileyberro@chromium.org>
Date: Tue Jul 17 20:18:52 2018

Fix SMB remount on reboot with hostname

This change fixes a bug where shares mounted with a hostname rather than
an ip address are not remounted when a user logs out and back in.

Previously, we were storing the unresolved share_path rather than the
resolved share path that is used to mount the share.

Bug:  863513 ,  757625 
Change-Id: I183200d9193c439f46a1609074706c5b2e2c0355
Reviewed-on: https://chromium-review.googlesource.com/1136863
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575753}
[modify] https://crrev.com/0564a5eed2fa1ea436fbfaee10fdfacec8aef057/chrome/browser/chromeos/smb_client/smb_service.cc

Labels: smb-native
This is fixed for now, but in order to more accurately remount the share, resolution should happen again when remounting rather than just using the resolved ip from the original mount attempt
Cc: weifangsun@chromium.org
Components: Platform>Apps>FileManager
Is this Files App related?
Labels: M-70
Labels: -Pri-1 Pri-2
Labels: -M-70 M-71
Moving this to M71

Sign in to add a comment