New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 863511 link

Starred by 1 user
Status: Fixed
Owner:
█ junov@chromium.org
Last visit > 30 days ago
Closed: Jul 19
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

Workers leak OffscreenCanvases and their contexts

Project Member Reported by junov@chromium.org, Jul 13 
WorkerAnimationFrameProvider keeps "Member" references that will keep alive offscreen canvases and contexts that would otherwise no longer be referenced.  This prevent OffscreenCanvases from ever being being garbage collected for the lifetime of the Worker.
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c7c29279deb33aaf6af2b970f4c82b7d837a9780

commit c7c29279deb33aaf6af2b970f4c82b7d837a9780
Author: Justin Novosad <junov@chromium.org>
Date: Thu Jul 19 18:51:28 2018

Fix OffscreenCanvases being leaked in Workers

This change removes the strong references to OffscreenCanvas objects
in WorkerAnimationFrameProvider, which was preventing OffscreenCancases
from being garbage collected for the lifetime of the Worker that owns
it.

BUG= 863511 

Change-Id: Ia70c98e7fc876906e9a25ad24be8e309d4884372
Reviewed-on: https://chromium-review.googlesource.com/1142444
Reviewed-by: Stephen White <senorblanco@chromium.org>
Commit-Queue: Justin Novosad <junov@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576581}
[modify] https://crrev.com/c7c29279deb33aaf6af2b970f4c82b7d837a9780/third_party/blink/renderer/core/workers/worker_animation_frame_provider.cc
[modify] https://crrev.com/c7c29279deb33aaf6af2b970f4c82b7d837a9780/third_party/blink/renderer/core/workers/worker_animation_frame_provider.h

Comment 2 by junov@chromium.org, Jul 19

Status: Fixed (was: Assigned)
►

Sign in to add a comment