PrivetTrafficDetector class (and some related code) is never being compiled. |
|||||
Issue descriptionPer https://codereview.chromium.org/2460653003/ the |#if defined(ENABLE_MDNS)| blocks should be migrated to |#if BUILDFLAG(ENABLE_MDNS)| blocks. However, two such blocks in privet_notifications.cc haven't been changed; the upshot of which is that none of the code in them (include all of the PrivetTrafficDetector class) have been being compiled or tested on any of the bots.
,
Jul 13
CC'ing some other printing OWNERs.
,
Jul 13
,
Jul 13
,
Jul 13
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/cfc948b7d02ec5b2317da2f4d0dfa982bc3ecc4d commit cfc948b7d02ec5b2317da2f4d0dfa982bc3ecc4d Author: Lily Houghton <lilyhoughton@chromium.org> Date: Fri Jul 13 20:45:53 2018 Change |#if defined| to |#if BUILDFLAG| in privet_notifications.cc Per https://codereview.chromium.org/2460653003/ ENABLE_MDSN has been migrated from a #define to a buildflag; however, there are two instances of it in PrivetNotificationService that have not been changed yet. This CL fixes those. Bug: 863508 Change-Id: I273afb99ced733012ce58dcfa061d18faa8508de Reviewed-on: https://chromium-review.googlesource.com/1136864 Reviewed-by: Lei Zhang <thestig@chromium.org> Commit-Queue: Lily Houghton <lilyhoughton@chromium.org> Cr-Commit-Position: refs/heads/master@{#575060} [modify] https://crrev.com/cfc948b7d02ec5b2317da2f4d0dfa982bc3ecc4d/chrome/browser/printing/cloud_print/privet_notifications.cc
,
Jul 13
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by lilyhoughton@chromium.org
, Jul 13