[PIP] Play/Pause button appears when video changes |
|||||
Issue descriptionRepro: - Open youtube playlist that autoplays to next video - Enter PiP - When video changes, play/pause button appears. Play/Pause button should only appear when the window is in focus.
,
Jul 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/636c518a9cb1df3d728e6a3c25d39d4393998eff commit 636c518a9cb1df3d728e6a3c25d39d4393998eff Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Jul 26 05:03:14 2018 Picture-in-Picture: playback state change shouldn't show icons. Updating the views visibility overrides the layer's visibility. This makes sure the layer is set back to the correct visibility when the views' one is updated in order to avoid the pause button to show up in cases such as a playlist. Bug: 863497 Change-Id: I0d9ce10b1219ea3af492269e228988f51c54b3e2 Reviewed-on: https://chromium-review.googlesource.com/1149507 Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/heads/master@{#578209} [modify] https://crrev.com/636c518a9cb1df3d728e6a3c25d39d4393998eff/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/636c518a9cb1df3d728e6a3c25d39d4393998eff/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/636c518a9cb1df3d728e6a3c25d39d4393998eff/chrome/browser/ui/views/overlay/overlay_window_views.h
,
Jul 26
,
Jul 27
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8fe1cda2e3d3ad548ae98d0528a3eb4ed206744 commit e8fe1cda2e3d3ad548ae98d0528a3eb4ed206744 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Fri Jul 27 15:23:09 2018 Picture-in-Picture: playback state change shouldn't show icons. Updating the views visibility overrides the layer's visibility. This makes sure the layer is set back to the correct visibility when the views' one is updated in order to avoid the pause button to show up in cases such as a playlist. Bug: 863497 Change-Id: I0d9ce10b1219ea3af492269e228988f51c54b3e2 Reviewed-on: https://chromium-review.googlesource.com/1149507 Reviewed-by: apacible <apacible@chromium.org> Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#578209}(cherry picked from commit 636c518a9cb1df3d728e6a3c25d39d4393998eff) Reviewed-on: https://chromium-review.googlesource.com/1152372 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#151} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/e8fe1cda2e3d3ad548ae98d0528a3eb4ed206744/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [modify] https://crrev.com/e8fe1cda2e3d3ad548ae98d0528a3eb4ed206744/chrome/browser/ui/views/overlay/overlay_window_views.cc [modify] https://crrev.com/e8fe1cda2e3d3ad548ae98d0528a3eb4ed206744/chrome/browser/ui/views/overlay/overlay_window_views.h
,
Jul 27
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by mlamouri@chromium.org
, Jul 25Owner: mlamouri@chromium.org