New issue
Advanced search Search tips

Issue 863487 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Nov 26
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 3
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Implement GetTrackedDeviceClass in fake_openvr_impl_api.cc, and test controllers

Project Member Reported by billorr@chromium.org, Jul 13

Issue description

We aren't testing controllers yet, but we call GetTrackedDeviceClass during tests, filling the log with notifications that it isn't implemented.

We should implement it, wired up so tests can control it, and test input.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Oct 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/52ef60acdd29e5a335362e1fa641d65e0e5e097d

commit 52ef60acdd29e5a335362e1fa641d65e0e5e097d
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Oct 05 19:58:53 2018

Add controller support to VR browser tests

Adds support for fake controller input when using OpenVR
in the VR browser tests. This is done by adding several
new functions and structs to the existing test hook and
Mojo interface so that controller data set by a test
is retrievable by the fake OpenVR implementation.

Bug:  863487 
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ib9da6756df51093126d641e69fbf96ec05f2270b
Reviewed-on: https://chromium-review.googlesource.com/c/1220806
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Bill Orr <billorr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#597258}
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/chrome/browser/vr/DEPS
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/chrome/browser/vr/test/mock_openvr_device_hook_base.cc
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/chrome/browser/vr/test/mock_openvr_device_hook_base.h
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/chrome/browser/vr/webxr_vr_input_browser_test.cc
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/chrome/services/isolated_xr_device/xr_test_hook_wrapper.cc
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/chrome/services/isolated_xr_device/xr_test_hook_wrapper.h
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/device/vr/openvr/test/fake_openvr_impl_api.cc
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/device/vr/openvr/test/test_helper.cc
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/device/vr/openvr/test/test_helper.h
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/device/vr/openvr/test/test_hook.h
[modify] https://crrev.com/52ef60acdd29e5a335362e1fa641d65e0e5e097d/device/vr/public/mojom/browser_test_interfaces.mojom

Cc: bsheedy@chromium.org
Status: Fixed (was: Assigned)

Sign in to add a comment