Disable bookmarks egtest on iOS12 |
|||||||
Issue descriptionA number of bookmarks egtests are failing on iOS12. For now just disable the entire suite.
,
Jul 14
FYI: these tests appear to be failing on the 11.4 simulator: https://ci.chromium.org/buildbot/chromium.fyi/ios11-beta-simulator/1925
,
Jul 23
,
Jul 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c51b558293f7efc331259a69e4f69b61dda91555 commit c51b558293f7efc331259a69e4f69b61dda91555 Author: Rohit Rao <rohitrao@chromium.org> Date: Tue Jul 24 19:57:01 2018 [ios] Search for abbreviated Back button labels in Bookmarks. When the previous view controller's title is too long, iOS may choose to label the navigation bar's back button with either the word "Back" or to omit the label entirely. Have EG tests search for the back button using all three potential labels. BUG= 863476 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7cae966be78e63b4a26f0e2d2a1f708b43a46d0 Reviewed-on: https://chromium-review.googlesource.com/1148466 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#577649} [modify] https://crrev.com/c51b558293f7efc331259a69e4f69b61dda91555/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm
,
Jul 25
I believe these tests are now passing on iOS12.
,
Jul 25
Requesting merge because this is a test fix and we should try to keep the official bots happy.
,
Jul 26
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jul 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/530c81e37ed4f03dba4f4207490173d8a53cd3fc commit 530c81e37ed4f03dba4f4207490173d8a53cd3fc Author: Rohit Rao <rohitrao@chromium.org> Date: Mon Jul 30 17:07:28 2018 [ios] Search for abbreviated Back button labels in Bookmarks. When the previous view controller's title is too long, iOS may choose to label the navigation bar's back button with either the word "Back" or to omit the label entirely. Have EG tests search for the back button using all three potential labels. BUG= 863476 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: Ic7cae966be78e63b4a26f0e2d2a1f708b43a46d0 Reviewed-on: https://chromium-review.googlesource.com/1148466 Commit-Queue: Rohit Rao <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by: Justin Cohen <justincohen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#577649}(cherry picked from commit c51b558293f7efc331259a69e4f69b61dda91555) Reviewed-on: https://chromium-review.googlesource.com/1155207 Reviewed-by: Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#213} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/530c81e37ed4f03dba4f4207490173d8a53cd3fc/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm |
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by bugdroid1@chromium.org
, Jul 13