New issue
Advanced search Search tips

Issue 863476 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 25
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug
Q2



Sign in to add a comment

Disable bookmarks egtest on iOS12

Project Member Reported by justincohen@chromium.org, Jul 13

Issue description

A number of bookmarks egtests are failing on iOS12.  For now just disable the entire suite.


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eac88a529ed3697a1be3a6dc369b7ee25c2a1a92

commit eac88a529ed3697a1be3a6dc369b7ee25c2a1a92
Author: Justin Cohen <justincohen@google.com>
Date: Fri Jul 13 18:12:13 2018

Disable bookmarks on iOS12.

Bug:  863476 
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I864b2c054563e3b49f7ef87c4d2e85423c04e338
Reviewed-on: https://chromium-review.googlesource.com/1136669
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#574978}
[modify] https://crrev.com/eac88a529ed3697a1be3a6dc369b7ee25c2a1a92/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Cc: linds...@chromium.org
FYI: these tests appear to be failing on the 11.4 simulator: https://ci.chromium.org/buildbot/chromium.fyi/ios11-beta-simulator/1925
Labels: Proj-UIRefresh Q2
Project Member

Comment 4 by bugdroid1@chromium.org, Jul 24

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c51b558293f7efc331259a69e4f69b61dda91555

commit c51b558293f7efc331259a69e4f69b61dda91555
Author: Rohit Rao <rohitrao@chromium.org>
Date: Tue Jul 24 19:57:01 2018

[ios] Search for abbreviated Back button labels in Bookmarks.

When the previous view controller's title is too long, iOS may choose to
label the navigation bar's back button with either the word "Back" or to
omit the label entirely. Have EG tests search for the back button using
all three potential labels.

BUG= 863476 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic7cae966be78e63b4a26f0e2d2a1f708b43a46d0
Reviewed-on: https://chromium-review.googlesource.com/1148466
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#577649}
[modify] https://crrev.com/c51b558293f7efc331259a69e4f69b61dda91555/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Status: Fixed (was: Assigned)
I believe these tests are now passing on iOS12.
Labels: Merge-Request-69
Requesting merge because this is a test fix and we should try to keep the official bots happy.
Project Member

Comment 7 by sheriffbot@chromium.org, Jul 26

Labels: -Merge-Request-69 Hotlist-Merge-Approved Merge-Approved-69
Your change meets the bar and is auto-approved for M69. Please go ahead and merge the CL to branch 3497 manually. Please contact milestone owner if you have questions.
Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 8 by sheriffbot@chromium.org, Jul 30

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 9 by bugdroid1@chromium.org, Jul 30

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/530c81e37ed4f03dba4f4207490173d8a53cd3fc

commit 530c81e37ed4f03dba4f4207490173d8a53cd3fc
Author: Rohit Rao <rohitrao@chromium.org>
Date: Mon Jul 30 17:07:28 2018

[ios] Search for abbreviated Back button labels in Bookmarks.

When the previous view controller's title is too long, iOS may choose to
label the navigation bar's back button with either the word "Back" or to
omit the label entirely. Have EG tests search for the back button using
all three potential labels.

BUG= 863476 

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ic7cae966be78e63b4a26f0e2d2a1f708b43a46d0
Reviewed-on: https://chromium-review.googlesource.com/1148466
Commit-Queue: Rohit Rao <rohitrao@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577649}(cherry picked from commit c51b558293f7efc331259a69e4f69b61dda91555)
Reviewed-on: https://chromium-review.googlesource.com/1155207
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#213}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/530c81e37ed4f03dba4f4207490173d8a53cd3fc/ios/chrome/browser/ui/bookmarks/bookmarks_egtest.mm

Sign in to add a comment