https://chromium.googlesource.com/chromium/tools/build/+/d0d7d18778e7c49c452cb19b802ff7818f2476f8/scripts/slave/recipe_modules/ios/api.py#811 It calls directly into src/tools/luci-go/mac64/isolate. As part of issue 851596, it's being moved to src/tools/luci-go/isolate. The isolate recipe module[1] wraps this. AI: - Stop calling directly into isolate and instead use the isolate.isolate_test() function[2]. [1] https://chromium.googlesource.com/chromium/tools/build/+/d0d7d18778e7c49c452cb19b802ff7818f2476f8/scripts/slave/recipe_modules/isolate/resources/isolate.py [2] https://chromium.googlesource.com/chromium/tools/build/+/d0d7d18778e7c49c452cb19b802ff7818f2476f8/scripts/slave/recipe_modules/isolate/api.py#99
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build/+/7b5dc4f194608b636ec72c40978651035c78f15f commit 7b5dc4f194608b636ec72c40978651035c78f15f Author: John Budorick <jbudorick@chromium.org> Date: Fri Jul 13 21:14:48 2018 ios: use isolate recipe module. Recipe-Nontrivial-Roll: build_limited_scripts_slave Bug: 863450 Change-Id: I350ca057705572229753964aaeb8e9d1ca72da37 Reviewed-on: https://chromium-review.googlesource.com/1136898 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by: Ben Pastene <bpastene@chromium.org> [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/timed_out.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/errors.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/expiration_test.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/expired.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/README.recipes.md [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/api.py [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/basic.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/no_exit_code.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipes/ios/try.expected/gn.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/test_failure.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/infra_failure.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipes/ios/try.expected/basic.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/xcode_build_version_luci.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/deprecate_xcode_version.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipes/ios/try.expected/parent.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipes/ios/unified_builder_tester.expected/basic.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/fyi.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/perf_test.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipes/webrtc/ios.expected/basic.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipes/ios/unified_builder_tester.expected/basic_experimental.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.expected/device_check_false.json [modify] https://crrev.com/7b5dc4f194608b636ec72c40978651035c78f15f/scripts/slave/recipe_modules/ios/examples/full.py
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/tools/build_limited/scripts/slave/+/f3051ae662dff469fd534594b00b88bcf3409898 commit f3051ae662dff469fd534594b00b88bcf3409898 Author: John Budorick <jbudorick@google.com> Date: Mon Jul 16 18:32:26 2018
Comment 1 by jbudorick@chromium.org
, Jul 13Owner: jbudorick@chromium.org
Status: Started (was: Available)