Add AdTracker tests for various resource types |
||
Issue descriptionRelated to issue 848916, we should test each type of resource to verify that if an ad script is on the stack when that type is loaded, that it's considered an ad resource. Until we have an async stack solution we'll miss resource loads that load asynchronously (e.g., images) but we need to test the ones that work and determine the ones that don't.
,
Aug 2
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd0a8309e4a39ddcd2598a617d99488cbb0e7998 commit fd0a8309e4a39ddcd2598a617d99488cbb0e7998 Author: Eric Robinson <ericrobinson@chromium.org> Date: Thu Aug 02 15:26:26 2018 AdTracker tests of resource marking for images, frames. This CL adds tests to the AdTracker to verify that resources loaded by an ad script are marked properly ad ads during loaded. This does not work properly for images currently due to crbug.com/848916. Bug: 848916, 863446 Change-Id: I6643ec24c16ec7dceb9c60fd150046b86cb008ac Reviewed-on: https://chromium-review.googlesource.com/1140196 Reviewed-by: Josh Karlin <jkarlin@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Eric Robinson <ericrobinson@chromium.org> Cr-Commit-Position: refs/heads/master@{#580192} [modify] https://crrev.com/fd0a8309e4a39ddcd2598a617d99488cbb0e7998/third_party/blink/renderer/core/frame/ad_tracker_test.cc
,
Jan 11
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this. |
||
►
Sign in to add a comment |
||
Comment 1 by ericrobinson@chromium.org
, Jul 30