Thank you for starting this initiative!
I agree that the files and directories under src/chromeos require some reorganization.
That said, I find it a bit difficult to understand what you want to achieve here.

If what you want to get is a subset of src/chromeos for mash, you can create a new component which includes selected subdirectories (e.g. src/chromeos/dbus and src/chromeos/cryptohome). This way, you just need to edit chromeos/BUILD.gn, and there is no need to move code.

If you want to make dependencies between .cc files under src/chromeos clear, I think it's better to add more subcomponents (e.g. src/chromeos/dbus, src/chromeos/dbus/fakes, src/chromeos/cryptohome) for better granularity.

My main concern here is that dividing src/chromeos into two components (i.e. src/chromeos/dbus and the others) can result in putting everything needed by mash into src/chromeos/dbus.

There are multiple motivations for this effort. To clarify:

1. src/chromeos/BUILD.gn is definitely too large and the directory needs to be better componentized, I think we can all agree to that. src/chromeos/dbus is fairly low hanging fruit and is the foundation layer for much of the code in src/chromeos. It is also the only piece of src/chromeos required by a few other components (e.g. src/device), so isolating it reduces those dependencies.

2. In out-of-process-ash (mash), currently both Chrome and Ash communicate with Shill over DBus using the NetworkHandler libraries. This leads to unpredictable behavior and needs to be fixed. My proposed solution (issue 862420) is to create a network configuration mojo service in src/chromeos/network. To do that I would prefer to also make src/chromeos/network a separate component with its own BUILD.gn, rather than adding additional complexity to the chromeos/BUILD.gn file. That requires src/chromeos/dbus to also be a component. (There are a couple of other smaller dependencies to work out, e.g. src/chromeos/login, but those should be much easier).


Other clarifications:

a) Making chromeos/dbus a component for "mash" (by which I assume you mean Ash in OopAsh mode), is a non goal. Rather the opposite; we would prefer to have Ash not depend on chromeos/dbus at all, or if there are dbus dependencies that make sense to live in Ash instead of Chrome, we will want to further subdivide chromeos/dbus so that Ash and Chrome can depend on just the dbus services they need. (DbusThreadmanager will require some further re-factoring for that).

b) Adding more code in general to src/chromeos/dbus is very much a non goal. A few files that really belong in src/chromeos/dbus (i.e. code that is co-dependent with src/chromeos/dbus) have been moved, but otherwise it should remain a library for chromeos dbus service implementations.

Thanks for the explanation.
So basically this componentization is not actually blocking any servicification work, but for preparation to divide chromeos/dbus into smaller pieces.
Is my understanding correct?

After this work is done, how will be chromeos/dbus divided?
Are you planning to create a new subdirectory/compoment chromeos/dbus/network which holds all shill-related clients?

Short term: We do need this so that we can componentize chromeos/network so that we can (sanely) add a mojo service there, so that we can remove the Ash dependencies on chromoes/network, which currently behaves badly in OopAsh (since two processes, Ash and Chrome, currently talk to Shill over DBus, which is not supported).

Long term: There is a lot of potential cleanup, including isolating, chromeos/dbus/network, but that is not actually required for OopAsh, which is my current priority.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11227062be0d6450a9ebac025fa48b92b34189fc

commit 11227062be0d6450a9ebac025fa48b92b34189fc
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jul 19 15:49:57 2018

Add DEPS and remove some simple dependencies from src/chromeos/dbus

This is a first step towards isolating src/chromeos/dbus and adding
its own BUILD.gn file.

For DEPS file includes, all of which are inherited from src/chromeos:
TBR=rsleevi@chromium.org, dcheng@chromium.org

For minor changes to tests in chrome/browser/chromeos/policy/:
TBR=emaxx@chromium.org

Bug:  863439 
Change-Id: I512a834039e7136915b30950648ab491b4c421d1
Reviewed-on: https://chromium-review.googlesource.com/1136715
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576509}
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chrome/browser/chromeos/policy/component_active_directory_policy_browsertest.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/BUILD.gn
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/chromeos_switches.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/chromeos_switches.h
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/cryptohome/tpm_util.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/cryptohome/tpm_util.h
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/DEPS
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/dbus_clients_common.cc
[add] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/dbus_switches.cc
[add] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/dbus_switches.h
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/fake_auth_policy_client_unittest.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/fake_shill_service_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/fake_sms_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/power_manager_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/session_manager_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/shill_client_unittest_base.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/shill_service_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/dbus/update_engine_client.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/login/auth/authpolicy_login_helper.cc
[modify] https://crrev.com/11227062be0d6450a9ebac025fa48b92b34189fc/chromeos/login/auth/authpolicy_login_helper.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc

commit 149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jul 19 17:33:36 2018

Move all D-Bus proto headers to src/chromeos/dbus

This fixes some dependency issues and makes the code more consistent.
Also alphebetized the protos and moved attestation_constants to
src/chromeos/dbus since they are used by CryptohomeClient.

For trivial header names in extensions and policy code:
TBR=tbarzic@chromium.org, emaxx@chromium.org

Bug:  863439 
Change-Id: I1e851eb4bcfd07ca700eba026cdb8a1b8e4f4ee0
Reviewed-on: https://chromium-review.googlesource.com/1136840
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576545}
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/browsing_data/chrome_browsing_data_remover_delegate.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/attestation/attestation_ca_client.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/attestation/attestation_policy_observer.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/attestation/enrollment_policy_observer.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/attestation/platform_verification_flow.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/attestation/platform_verification_flow.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/attestation/platform_verification_flow_unittest.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/login/supervised/supervised_user_authentication.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/extensions/api/enterprise_platform_keys/enterprise_platform_keys_api_unittest.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api_unittest.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/BUILD.gn
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/attestation/attestation_flow.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/cryptohome/async_method_caller.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/DEPS
[rename] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/attestation_constants.cc
[rename] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/attestation_constants.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/fake_cryptohome_client_unittest.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/fake_media_analytics_client.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/chromeos/dbus/media_analytics_client.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/extensions/browser/api/media_perception_private/conversion_utils.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/extensions/browser/api/media_perception_private/conversion_utils_unittest.cc
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/extensions/browser/api/media_perception_private/media_perception_api_manager.h
[modify] https://crrev.com/149a15b75fd2ee0bb4a7504a7c4a8c05883d42cc/extensions/browser/api/media_perception_private/media_perception_private_apitest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6

commit 642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jul 19 20:48:19 2018

Move chromeos/cryptohome/tpm_util -> chromeos/dbus/util

tpm_util depends exclusively on chromeos/dbus and therefore
belongs there (which also simplifies some dependencies in the
fake dbus implementations).

Bug:  863439 

For minor header changes to chrome/browser/chromeos/policy:
TBR=emaxx@chromium.org

Change-Id: Ie42326ed7e6c5de42571b01955e302fa68640f2c
Reviewed-on: https://chromium-review.googlesource.com/1136945
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576614}
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/login/active_directory_login_browsertest.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/login/existing_user_controller_browsertest.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/policy/component_active_directory_policy_browsertest.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chrome/browser/chromeos/settings/install_attributes_unittest.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chromeos/BUILD.gn
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chromeos/dbus/fake_auth_policy_client_unittest.cc
[rename] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chromeos/dbus/util/tpm_util.cc
[rename] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chromeos/dbus/util/tpm_util.h
[modify] https://crrev.com/642db78c13214a9bdd45d3c3a7d5cf0bc6e049c6/chromeos/login/auth/authpolicy_login_helper.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a4fe4f7cbdf319b3c1c835a138e465f3016248b7

commit a4fe4f7cbdf319b3c1c835a138e465f3016248b7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jul 19 20:54:34 2018

Move chromeos/system/version_loader -> chromeos/dbus/util

version_loader contains utility functions that only depend on
CryptohomeClient and base/. Since UpdateEngineClient depends on
version_loader, it makes sense to move the file to chromeos/dbus.

For file rename in c/b/chromeos/policy/:
TBR=pmarco@chromium.org

Bug:  863439 
Change-Id: Ic8b54af8de80cb705f23b82c3c803aff6568f1c0
Reviewed-on: https://chromium-review.googlesource.com/1142187
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Reviewed-by: Marton Hunyady <hunyadym@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#576617}
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/chromeos/chrome_browser_main_chromeos.h
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/chromeos/hats/hats_dialog.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/chromeos/login/version_info_updater.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/chromeos/login/version_info_updater.h
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/chromeos/policy/device_status_collector.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/chromeos/policy/device_status_collector.h
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/feedback/system_logs/log_sources/chrome_internal_log_source.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/ui/webui/settings/about_handler.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/ui/webui/settings/about_handler.h
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chrome/browser/ui/webui/version_handler_chromeos.h
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/BUILD.gn
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/dbus/DEPS
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/dbus/update_engine_client.cc
[rename] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/dbus/util/version_loader.cc
[rename] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/dbus/util/version_loader.h
[rename] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/dbus/util/version_loader_unittest.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/services/assistant/assistant_manager_service_impl.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/services/assistant/platform/system_provider_impl.cc
[modify] https://crrev.com/a4fe4f7cbdf319b3c1c835a138e465f3016248b7/chromeos/services/assistant/utils.cc

If your short term goal is to componentize chromeos/network, I think it's better to start by componentizing network-related D-Bus clients only, so that you don't need to deal with other D-Bus clients like CryptohomeClient.

IIUC there is no urgent need to componentize D-Bus clients not related to network.
I'm concerned about http://crrev.com/c/1136981 because it increases the codebase's complexity by introducing another ID class to componentize CryptohomeClient which has no urgent need to get componentized.

Our networking code uses DBusThreadManager::Get()->GetShillServiceClient(), etc.

The only way to componentize chromeos/network without first componentizing all of chromeos/dbus would be to extract the Shill dbus clients from DBusThreadManager. This would be labor intensive and dangerous from a thread safety perspective (that is why we have DBusThreadManager in the first place).

I don't fully understand the reluctance to fix the dependency cycle between src/chromeos/cryptohome and src/chromeos/dbus.

While this is no longer at the top of my priority list, I do hope to get back to it soon. I will go ahead and plan to write up a design doc to help untangle the cryptohome classes before I do.

Is threading a problem? I thought that DBusThreadManager had two responsibilities: managing the thread and just owning the various FooClient objects (which I think live on the main thread). We talked a long time ago about moving ownership of the FooClient objects elsewhere (like a bundle for ash, a bundle for browser, and a bundle for comment), then changing all the accessors to use FooClient::Get().

It's not so much a "problem" as a concern. It's important that the DBus calls themselves do not block the UI thread, and that the calls to the DBus thread only occur from a single (UI) thread. We don't necessarily need the clients to all be owned by DBusThreadManager, but we will want to be thoughtful and careful about any such extraction.

> The only way to componentize chromeos/network without first componentizing all of chromeos/dbus would be to extract the Shill dbus clients from DBusThreadManager. This would be labor intensive and dangerous from a thread safety perspective (that is why we have DBusThreadManager in the first place).

As James said in comment #12, switching to FooClient::Get() should make the code more multiprocess-friendly (issue 647367).

Another possible option is:
 1. Create a new class NetworkDBusThreadManager which owns all network-related D-Bus clients.
 2. Provide two ways to initialize NetworkDBusThreadManager: one which creates NetworkDBusThreadManager with its own Bus (this is for when running network service in its own process), and another which creates NetworkDBusThreadManager with Bus owned by DBusThreadManager (this is for the browser process).
 3. DBusThreadManager initializes NetworkDBusThreadManager as part of its initialization. DBusThreadManager::GetShill*Client methods become simple wrapper of NetworkDBusThreadManager.

This way, all D-Bus client objects share the same D-Bus thread and Bus, and existing code can continue using DBusThreadManager to access shill clients.
Code under chromeos/network can be componentized after being rewritten to use NetworkDBusThreadManager instead of DBusThreadManager.


> I don't fully understand the reluctance to fix the dependency cycle between src/chromeos/cryptohome and src/chromeos/dbus.

I see no problem in the said dependency cycle. OTOH your CL http://crrev.com/c/1136981 makes cryptohome-related code even more complicated.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5b05160734c8506b656e3ff835f131f7c0b52c90

commit 5b05160734c8506b656e3ff835f131f7c0b52c90
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Aug 08 17:22:19 2018

Remove chromeos/cryptohome DEPS from chromeos/dbus

This dependency is no longer required, this CL just cleans up some
includes and makes a minor change to
FakeAuthPolicyClient::RefreshUserPolicy to remove the cryptohome
dependency and support tests.

For minor fix to chrome/browser/chromeos/policy/ includes:
TBR=emaxx@chromium.org

Bug:  863439 
Change-Id: I519ea33d7e5ad9355c45bfc172f97a4cb51b8122
Reviewed-on: https://chromium-review.googlesource.com/1165491
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581611}
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chrome/browser/chromeos/app_mode/kiosk_crash_restore_browsertest.cc
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chrome/browser/chromeos/login/users/wallpaper_policy_browsertest.cc
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chrome/browser/chromeos/policy/component_active_directory_policy_browsertest.cc
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chromeos/dbus/DEPS
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chromeos/dbus/fake_auth_policy_client.cc
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chromeos/dbus/fake_cryptohome_client_unittest.cc
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/5b05160734c8506b656e3ff835f131f7c0b52c90/chromeos/dbus/session_manager_client.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/93db1a13a8e2a79ebcc6a84676f351ae335ced53

commit 93db1a13a8e2a79ebcc6a84676f351ae335ced53
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Dec 19 21:58:25 2018

Remove chromeos_features.h dep from cros_disks_client.cc

We want to make chromeos/dbus a separate component so we need to remove
src/chromeos dependencies.

Bug:  863439 
Change-Id: Ic4d5bd0115a95f56ef0d7b652d70151c2e04e576
Reviewed-on: https://chromium-review.googlesource.com/c/1383440
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617970}
[modify] https://crrev.com/93db1a13a8e2a79ebcc6a84676f351ae335ced53/chromeos/dbus/cros_disks_client.cc
[modify] https://crrev.com/93db1a13a8e2a79ebcc6a84676f351ae335ced53/chromeos/disks/disk_mount_manager.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aafa374eae82ec0448dda5a550645476c66b0f91

commit aafa374eae82ec0448dda5a550645476c66b0f91
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Dec 19 23:26:33 2018

Move features test from PowerPolicyController to PowerPrefs

We want to elimiminate chromeos_features.h from
chromeos/dbus/DEPS so that the dbus subdirectory can become
a separate component.

Bug:  863439 
Change-Id: Ief6474f8a24f74cf2416e83b47fc592e9d407436
Reviewed-on: https://chromium-review.googlesource.com/c/1383132
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618006}
[modify] https://crrev.com/aafa374eae82ec0448dda5a550645476c66b0f91/ash/system/power/power_prefs.cc
[modify] https://crrev.com/aafa374eae82ec0448dda5a550645476c66b0f91/chromeos/dbus/DEPS
[modify] https://crrev.com/aafa374eae82ec0448dda5a550645476c66b0f91/chromeos/dbus/power_policy_controller.cc
[modify] https://crrev.com/aafa374eae82ec0448dda5a550645476c66b0f91/chromeos/dbus/power_policy_controller.h
[modify] https://crrev.com/aafa374eae82ec0448dda5a550645476c66b0f91/chromeos/dbus/power_policy_controller_unittest.cc

Updated the Design Doc to reflect overall goals of this effort:

https://docs.google.com/document/d/1qDiZo7_Ho7TDe6XIz5YWVgMLFSB32O3udmFgadnCRc0/edit#heading=h.xrrylsoychhl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b6cedf0e8a9fcdf3e8263394a455ca61c691365f

commit b6cedf0e8a9fcdf3e8263394a455ca61c691365f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 07 17:01:23 2019

Create chromeos/dbus/constants

We are going to be adding 'dbus_paths' which along with 'dbus_switches'
need to be public deps of "dbus". To support that, this CL moves
'dbus_switches' to chromeos/dbus/constants and renames the GN target to
'dbus/constants'.

For trivial file move in media/audio:
TBR=tommi@chromium.org

Bug:  863439 
Change-Id: I9260e5f437d6dae41b7108efc19ce335eee13755
Reviewed-on: https://chromium-review.googlesource.com/c/1387553
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: A Olsen <olsen@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620358}
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chrome/browser/chromeos/login/demo_mode/demo_mode_detector.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chrome/browser/chromeos/login/demo_mode/demo_mode_detector_unittest.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chrome/browser/chromeos/login/enterprise_enrollment_browsertest.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chrome/browser/chromeos/login/wizard_controller_browsertest.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/BUILD.gn
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/constants/DEPS
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/constants/chromeos_switches.h
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/BUILD.gn
[rename] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/constants/dbus_switches.cc
[rename] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/constants/dbus_switches.h
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/cryptohome_client.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/dbus_clients_common.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/dbus_thread_manager.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/fake_debug_daemon_client.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/fake_oobe_configuration_client.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/fake_shill_manager_client.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/fake_sms_client.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/power_manager_client.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/chromeos/dbus/update_engine_client.cc
[modify] https://crrev.com/b6cedf0e8a9fcdf3e8263394a455ca61c691365f/media/audio/audio_manager_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/42d25072370bd95ef8fda8d8a3aa1717cc2c766c

commit 42d25072370bd95ef8fda8d8a3aa1717cc2c766c
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 07 17:55:08 2019

Extract dbus specific chromeos paths to src/chromeos/dbus/ file

One of the last remaining src/chromeos/ dependencies in
src/chromeos/dbus is chromeos_paths.h.

A few of these paths are specific to the session_manager and
cryptohome processes and are accessed directly in the fake
implementations of the respective clients. This CL moves those
to src/chromeos/dbus/util/dbus_paths.h.

This also removes some unnecessary dependencies in
chromeos/dbus/BUILD.gn.

For minor path/namespace changes to c/b/{chromeos/}policy:
TBR=emaxx@chromium.org

Bug:  863439 
Change-Id: Ibad2113a46ff7176f808a9b0b739df6e66ccf217
Reviewed-on: https://chromium-review.googlesource.com/c/1176292
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620369}
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/login/users/avatar/user_image_manager_browsertest.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/login/users/wallpaper_policy_browsertest.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/ownership/owner_settings_service_chromeos_factory.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/policy/affiliation_test_helper.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/policy/power_policy_browsertest.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/policy/pre_signin_policy_fetcher.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/policy/pre_signin_policy_fetcher_unittest.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chrome/browser/policy/cloud/cloud_policy_browsertest.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/constants/chromeos_paths.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/constants/chromeos_paths.h
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/dbus/BUILD.gn
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/dbus/DEPS
[add] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/dbus/constants/dbus_paths.cc
[add] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/dbus/constants/dbus_paths.h
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/dbus/fake_session_manager_client.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/settings/install_attributes.cc
[modify] https://crrev.com/42d25072370bd95ef8fda8d8a3aa1717cc2c766c/chromeos/settings/install_attributes_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab7b68eacaca115c9f33bc402043d5b4bc581858

commit ab7b68eacaca115c9f33bc402043d5b4bc581858
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 07 19:14:43 2019

Use COMPONENT_EXPORT(CHROMEOS_DBUS) in chromeos/dbus

This will allow us to remove the chromeos:chromeos_export dependency
in chromeos/dbus/BUILD.gn.

Bug:  863439 
Change-Id: I0ae00fccc3dbc8376987268aacd5636f7a733048
Reviewed-on: https://chromium-review.googlesource.com/c/1387908
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: A Olsen <olsen@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620414}
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/BUILD.gn
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/DEPS
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/arc_appfuse_provider_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/arc_midis_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/arc_obb_mounter_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/arc_oemcrypto_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/attestation_constants.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/audio_node.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/auth_policy_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/biod/biod_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/biod/fake_biod_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/blocking_method_caller.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/cec_service_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/cicerone_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/concierge_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/constants/dbus_paths.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/constants/dbus_switches.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/cras_audio_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/cros_disks_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/cryptohome_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/dbus_clients_browser.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/dbus_clients_common.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/dbus_method_call_status.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/dbus_thread_manager.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/debug_daemon_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/diagnosticsd_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/easy_unlock_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_arc_appfuse_provider_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_arc_midis_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_arc_obb_mounter_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_arc_oemcrypto_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_auth_policy_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_cec_service_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_cicerone_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_concierge_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_cras_audio_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_cros_disks_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_cryptohome_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_debug_daemon_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_diagnosticsd_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_easy_unlock_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_gsm_sms_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_hammerd_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_image_burner_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_image_loader_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_lorgnette_manager_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_media_analytics_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_modem_messaging_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_oobe_configuration_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_permission_broker_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_power_manager_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_runtime_probe_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_seneschal_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_shill_device_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_shill_ipconfig_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_shill_manager_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_shill_profile_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_shill_service_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_shill_third_party_vpn_driver_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_smb_provider_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_system_clock_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_upstart_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/fake_virtual_file_provider_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/gsm_sms_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/hammerd_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/image_burner_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/image_loader_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/lorgnette_manager_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/media_analytics_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/modem_messaging_client.cc
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/modem_messaging_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/oobe_configuration_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/permission_broker_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/pipe_reader.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/power_manager_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/power_policy_controller.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/runtime_probe_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/seneschal_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/services/cros_dbus_service.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/session_manager_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/shill_device_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/shill_ipconfig_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/shill_manager_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/shill_profile_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/shill_service_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/shill_third_party_vpn_driver_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/smb_provider_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/sms_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/system_clock_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/update_engine_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/upstart_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/util/account_identifier_operators.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/util/tpm_util.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/util/version_loader.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/virtual_file_provider_client.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/dbus/volume_state.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/settings/install_attributes.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/settings/system_settings_provider.h
[modify] https://crrev.com/ab7b68eacaca115c9f33bc402043d5b4bc581858/chromeos/timezone/timezone_provider.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41

commit a0eb0c2d54c89d917285c2253c5159cdbd2b5f41
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 07 20:39:02 2019

Move dbus protos to dbus BUILD.gn

For simple component renames:
TBR=jamescook@chromium.org, hidehiko@chromium.org,
    rdevlin.cronin@chromium.org, blundell@chromium.org

Bug:  863439 
Change-Id: I176db7fccf540ee838b34c203afc8f762f9ae451
Reviewed-on: https://chromium-review.googlesource.com/c/1387687
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: A Olsen <olsen@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620456}
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/ash/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/ash/public/cpp/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/chromeos/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/chromeos/cryptohome/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/chromeos/dbus/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/chromeos/login/auth/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/chromeos/settings/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/components/arc/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/content/browser/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/extensions/browser/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/services/device/battery/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/services/device/wake_lock/power_save_blocker/BUILD.gn
[modify] https://crrev.com/a0eb0c2d54c89d917285c2253c5159cdbd2b5f41/ui/chromeos/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7

commit 0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Mon Jan 07 21:38:39 2019

Extract chromeos/dbus/services

For explicit DEPS extraction:
TBR=rsleevi@chromium.org

Bug:  863439 
Change-Id: I31c0eb6dd72bb8f881f50bcff2aabcb1800e2cae
Reviewed-on: https://chromium-review.googlesource.com/c/1170194
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Dan Erat <derat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620481}
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/ash/BUILD.gn
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/ash/DEPS
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/ash/dbus/DEPS
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/ash/dbus/ash_dbus_services.cc
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chromeos/BUILD.gn
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chromeos/dbus/BUILD.gn
[add] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chromeos/dbus/services/BUILD.gn
[add] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chromeos/dbus/services/DEPS
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chromeos/dbus/services/cros_dbus_service.cc
[modify] https://crrev.com/0b493ad5d2a2bdae8b9b1d2ef0e6bec175a8e8d7/chromeos/dbus/services/cros_dbus_service.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94c48063a22242f257d0b90d05b996256d94fd12

commit 94c48063a22242f257d0b90d05b996256d94fd12
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Tue Jan 08 20:12:09 2019

Make //chromeos/tpm a component

//chromeos/tpm has DBus dependencies which means it needs to be
a separate component in order to remove DBus dependencies form
//chromeos.

For extracting explicit DEPS file:
TBR=sky@chromium.org

Bug:  863439 
Change-Id: I40838f9d62a6aef329375ed782a1c22a6e7708d8
Reviewed-on: https://chromium-review.googlesource.com/c/1399305
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620853}
[modify] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chrome/browser/ui/webui/chromeos/login/eula_screen_handler.h
[modify] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chromeos/BUILD.gn
[add] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chromeos/tpm/BUILD.gn
[add] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chromeos/tpm/DEPS
[modify] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chromeos/tpm/tpm_password_fetcher.h
[modify] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chromeos/tpm/tpm_token_info_getter.h
[modify] https://crrev.com/94c48063a22242f257d0b90d05b996256d94fd12/chromeos/tpm/tpm_token_loader.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fbcd25f1d9a037e648e951e04fe7f8c4515620d7

commit fbcd25f1d9a037e648e951e04fe7f8c4515620d7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 09 17:22:09 2019

Make //chromeos/audio a separate component

src/chromeos/audio has dbus dependencies so needs to be a separate
component.

For explicit DEPS extraction:
TBR=sky@chromoium.org

Bug:  863439 
Change-Id: Ib8cab32db34bb6e1c66fe495adbb81cee4fe1b18
Reviewed-on: https://chromium-review.googlesource.com/c/1399299
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621197}
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/ash/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/BUILD.gn
[add] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/BUILD.gn
[add] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/DEPS
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/audio_device.h
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/audio_devices_pref_handler.h
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/audio_devices_pref_handler_impl.h
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/audio_devices_pref_handler_stub.h
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/audio_pref_observer.h
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/chromeos/audio/cras_audio_handler.h
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/components/arc/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/content/browser/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/content/test/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/extensions/browser/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/extensions/browser/api/audio/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/extensions/shell/BUILD.gn
[modify] https://crrev.com/fbcd25f1d9a037e648e951e04fe7f8c4515620d7/media/audio/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ac8639ca26c539366bd76c2cf5931b7ab705df0

commit 0ac8639ca26c539366bd76c2cf5931b7ab705df0
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 09 19:05:51 2019

Make //chromeos/disks a component

//chromeos/disks has DBus dependencies which means it needs to be
a separate component in order to remove DBus dependencies from
//chromeos.

For explicit DEPS extraction:
TBR=sky@chromium.org

For components/arc (change is consistent with reviewed
//components/audio change):
TBR=hidehiko@chromium.org

Bug:  863439 
Change-Id: I06886beec4c616e829aad8d57f502fff11800fcd
Reviewed-on: https://chromium-review.googlesource.com/c/1401383
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621250}
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chromeos/BUILD.gn
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chromeos/components/drivefs/BUILD.gn
[add] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chromeos/disks/BUILD.gn
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chromeos/disks/DEPS
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chromeos/disks/disk.h
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chromeos/disks/disk_mount_manager.h
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/chromeos/disks/suspend_unmount_manager.h
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/components/arc/BUILD.gn
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/components/storage_monitor/BUILD.gn
[modify] https://crrev.com/0ac8639ca26c539366bd76c2cf5931b7ab705df0/extensions/shell/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c5f1081380cc418d4798fe981f251e2255c9f9d7

commit c5f1081380cc418d4798fe981f251e2255c9f9d7
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 09 20:20:34 2019

Make //chromeos/attestation a component

//chromeos/attestation has DBus dependencies which means it needs to be
a separate component in order to remove DBus dependencies from
//chromeos.

For explicit DEPS extraction:
TBR=sky@chromium.org

Bug:  863439 
Change-Id: I5f07e3baae676214c7ad178f0b6c44ce707fe3ec
Reviewed-on: https://chromium-review.googlesource.com/c/1401227
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621288}
[modify] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chromeos/BUILD.gn
[add] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chromeos/attestation/BUILD.gn
[add] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chromeos/attestation/DEPS
[modify] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chromeos/attestation/attestation_flow.cc
[modify] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chromeos/attestation/attestation_flow.h
[modify] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chromeos/attestation/attestation_flow_unittest.cc
[modify] https://crrev.com/c5f1081380cc418d4798fe981f251e2255c9f9d7/chromeos/cryptohome/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b9e54bfbe066e986efe150e1596112dbaab6652

commit 1b9e54bfbe066e986efe150e1596112dbaab6652
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Wed Jan 09 23:09:37 2019

Move install_attributes to chromeos/tpm

install_attributes.cc has DBus dependencies (cryptohome_client). Since
no other files in //chromeos/settings have DBus dependencies, and since
install_attributes.cc has no chromeos/settings dependencies, we should
move install_attributes.cc from //chromeos/settings to a component
with similar dependencies.

For chrome/browser/chromeos/policy include moves:
TBR=mnissler@chromium.org
For DEPS extraction:
TBR=sky@chromium.org

Bug:  863439 
Change-Id: Ie4d42ce60b5ffb1c141e36c8aaa01e38eee96474
Reviewed-on: https://chromium-review.googlesource.com/c/1401369
Reviewed-by: A Olsen <olsen@chromium.org>
Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621359}
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/app_mode/kiosk_app_manager.h
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/arc/auth/arc_active_directory_enrollment_token_fetcher.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/chrome_browser_main_chromeos.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/dbus/dbus_helper.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/login/demo_mode/demo_session.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/login/demo_mode/demo_setup_controller.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/login/demo_mode/demo_setup_test_utils.h
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/login/session/user_session_manager.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/ownership/fake_owner_settings_service.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/ownership/owner_settings_service_chromeos.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/blocking_login_browsertest.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/browser_policy_connector_chromeos.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/device_cloud_policy_initializer.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/device_cloud_policy_manager_chromeos_unittest.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/device_cloud_policy_store_chromeos_unittest.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/device_policy_cros_browser_test.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/enrollment_handler_chromeos.h
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/enrollment_status_chromeos.h
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/policy/user_policy_manager_factory_chromeos.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/settings/device_settings_provider.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/settings/stub_install_attributes.h
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/system/device_disabling_manager.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/chromeos/system/timezone_util.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/extensions/api/enterprise_platform_keys_private/enterprise_platform_keys_private_api.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chrome/browser/ui/webui/policy_ui_handler.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/DEPS
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/dbus/fake_cryptohome_client.cc
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/settings/BUILD.gn
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/tpm/BUILD.gn
[modify] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/tpm/DEPS
[rename] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/tpm/install_attributes.cc
[rename] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/tpm/install_attributes.h
[rename] https://crrev.com/1b9e54bfbe066e986efe150e1596112dbaab6652/chromeos/tpm/install_attributes_unittest.cc

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/39046b31a7915602e6c435125823c7a521d6813b

commit 39046b31a7915602e6c435125823c7a521d6813b
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 10 17:15:16 2019

Make //chromeos/cryptohome and //chromeos/login/* components

A component or target should not include a source_set that is also
included by another component or target. This could cause unexpected
behavior in component builds with duplicate globals:
https://chromium.googlesource.com/chromium/src/+/HEAD/docs/component_build.md#the-chrome-component-build

This was violated with some recent refactoring of:
//chromeos/cryptohome
//chromeos/login/auth
//chromeos/login/login_state

These only affect component builds, which are not used for any
non-informational Chrome OS builders.

Since these changes landed recently and are part of a complex chain
(or are long existing) rather than attempt a series of reverts, this
CL addresses the majority of these by removing these source_sets from
//chromeos and making them separate components (something we want to
do anyway).

For redundant deps removal and extraction:
TBR=sky@chromium.org, jamescook@chromium.org, hidehiko@chromium.org

Bug:  863439 
Change-Id: I2174e25345ea7415a676fc2b9e6e62a0398428b0
Reviewed-on: https://chromium-review.googlesource.com/c/1399458
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621618}
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/ash/BUILD.gn
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chrome/browser/apps/platform_apps/api/BUILD.gn
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/BUILD.gn
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/BUILD.gn
[add] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/DEPS
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/async_method_caller.h
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/cryptohome_parameters.h
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/cryptohome_util.h
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/homedir_methods.h
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/mock_homedir_methods.h
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/cryptohome/system_salt_getter.h
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/login/auth/BUILD.gn
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/login/login_state/BUILD.gn
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/chromeos/tpm/BUILD.gn
[modify] https://crrev.com/39046b31a7915602e6c435125823c7a521d6813b/components/arc/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58e161953ee0d80cb6a39efc19f87bd327a7ec88

commit 58e161953ee0d80cb6a39efc19f87bd327a7ec88
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Thu Jan 10 20:36:03 2019

Make //chromeos/dbus a separate component.

This makes //chomroes/dbus a separate component and removes it from
//chromeos. Components that depend on //chromeos/dbus must now depend
on it explicitly. All DBus dependencies have been removed from
//chromeos.

Bug:  863439 
Change-Id: Ie6bb0dfe8f9baf17ea6db85c058c3d4fd3e6fe23
Reviewed-on: https://chromium-review.googlesource.com/c/1398782
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Reviewed-by: Mike West <mkwst@chromium.org>
Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621730}
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/ash/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chrome/test/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/attestation/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/audio/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/components/drivefs/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/components/multidevice/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/cryptohome/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/dbus/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/dbus/fake_update_engine_client.h
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/disks/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/login/auth/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/network/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/services/assistant/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/services/machine_learning/public/cpp/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/chromeos/tpm/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/components/arc/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/components/metrics/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/content/browser/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/content/shell/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/device/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/device/bluetooth/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/device/usb/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/device/usb/mojo/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/extensions/browser/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/extensions/shell/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/media/audio/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/media/capture/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/rlz/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/services/device/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/services/device/battery/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/services/device/fingerprint/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/services/device/hid/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/services/device/media_transfer_protocol/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/services/device/serial/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/services/device/wake_lock/power_save_blocker/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/ui/base/BUILD.gn
[modify] https://crrev.com/58e161953ee0d80cb6a39efc19f87bd327a7ec88/ui/chromeos/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7b929636d96110e827f98abd78cc2070d1711f66

commit 7b929636d96110e827f98abd78cc2070d1711f66
Author: Findit <findit-for-me@appspot.gserviceaccount.com>
Date: Thu Jan 10 21:20:26 2019

Revert "Make //chromeos/dbus a separate component."

This reverts commit 58e161953ee0d80cb6a39efc19f87bd327a7ec88.

Reason for revert:

Findit (https://goo.gl/kROfz5) identified CL at revision 621730 as the
culprit for failures in the build cycles as shown on:
https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtLzU4ZTE2MTk1M2VlMGQ4MGNiNmEzOWVmYzE5Zjg3YmQzMjdhN2VjODgM

Sample Failed Build: https://ci.chromium.org/buildbot/chromium/linux-rel/15186

Sample Failed Step: compile

Original change's description:
> Make //chromeos/dbus a separate component.
> 
> This makes //chomroes/dbus a separate component and removes it from
> //chromeos. Components that depend on //chromeos/dbus must now depend
> on it explicitly. All DBus dependencies have been removed from
> //chromeos.
> 
> Bug:  863439 
> Change-Id: Ie6bb0dfe8f9baf17ea6db85c058c3d4fd3e6fe23
> Reviewed-on: https://chromium-review.googlesource.com/c/1398782
> Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
> Reviewed-by: Ilya Sherman <isherman@chromium.org>
> Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
> Reviewed-by: Mike West <mkwst@chromium.org>
> Reviewed-by: Hidehiko Abe <hidehiko@chromium.org>
> Reviewed-by: Reilly Grant <reillyg@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#621730}

Change-Id: I90590a5705a04a83800c967bf9d115dfb24793c2
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  863439 
Reviewed-on: https://chromium-review.googlesource.com/c/1406071
Cr-Commit-Position: refs/heads/master@{#621738}
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/ash/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chrome/test/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/attestation/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/audio/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/components/drivefs/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/components/multidevice/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/cryptohome/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/dbus/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/dbus/fake_update_engine_client.h
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/disks/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/login/auth/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/network/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/services/assistant/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/services/machine_learning/public/cpp/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/chromeos/tpm/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/components/arc/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/components/metrics/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/content/browser/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/content/shell/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/device/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/device/bluetooth/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/device/usb/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/device/usb/mojo/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/extensions/browser/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/extensions/shell/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/media/audio/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/media/capture/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/rlz/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/services/device/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/services/device/battery/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/services/device/fingerprint/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/services/device/hid/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/services/device/media_transfer_protocol/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/services/device/serial/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/services/device/wake_lock/power_save_blocker/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/ui/base/BUILD.gn
[modify] https://crrev.com/7b929636d96110e827f98abd78cc2070d1711f66/ui/chromeos/BUILD.gn

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a992e436e7c9a0e5b5d95935faf134826c84e93f

commit a992e436e7c9a0e5b5d95935faf134826c84e93f
Author: Steven Bennetts <stevenjb@chromium.org>
Date: Fri Jan 11 00:21:12 2019

Make //chromeos/dbus a separate component. (Take 2)

Original CL: https://chromium-review.googlesource.com/c/1398782

Fix: Only include chromeos/assistant/buildflags.h inside OS_CHROMEOS

This makes //chomroes/dbus a separate component and removes it from
//chromeos. Components that depend on //chromeos/dbus must now depend
on it explicitly. All DBus dependencies have been removed from
//chromeos.

TBR=thakis@chromium.org,xhwang@chromium.org,isherman@chromium.org,
    hashimoto@chromium.org,mkwst@chromium.org, hidehiko@chromium.org
    reillyg@chromium.org

Bug:  863439 
Change-Id: Iae6c109859ec2629fa003940dec181f7913a5fec
Reviewed-on: https://chromium-review.googlesource.com/c/1405445
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621819}
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/ash/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chrome/browser/extensions/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chrome/browser/metrics/chrome_metrics_service_client.cc
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chrome/test/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/attestation/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/audio/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/components/drivefs/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/components/multidevice/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/components/proximity_auth/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/components/tether/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/cryptohome/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/dbus/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/dbus/fake_session_manager_client.h
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/dbus/fake_update_engine_client.h
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/disks/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/login/auth/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/network/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/services/assistant/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/services/device_sync/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/services/machine_learning/public/cpp/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/chromeos/tpm/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/components/arc/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/components/metrics/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/content/browser/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/content/shell/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/device/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/device/bluetooth/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/device/usb/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/device/usb/mojo/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/extensions/browser/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/extensions/browser/api/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/extensions/shell/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/media/audio/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/media/capture/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/rlz/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/services/device/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/services/device/battery/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/services/device/fingerprint/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/services/device/hid/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/services/device/media_transfer_protocol/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/services/device/serial/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/services/device/wake_lock/power_save_blocker/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/ui/base/BUILD.gn
[modify] https://crrev.com/a992e436e7c9a0e5b5d95935faf134826c84e93f/ui/chromeos/BUILD.gn