When audio is globally muted, audio playing in a website should not spawn a notification or interrupt
Reported by
tigerhaw...@gmail.com,
Jul 13
|
||||
Issue descriptionExample URL: http://www.newsweek.com/speeding-arizona-congressman-claims-immunity-when-pulled-over-brags-cop-he-1022154 Steps to reproduce the problem: 1. Have audio globally muted in site settings, because ads are obnoxious (my video is also click to play, but that doesn't seem to block these videos) 2. Have music playing on your device 3. Visit a page with an obnoxious video or video ad What is the expected behavior? Nothing. Audio is muted and video shouldn't play without my interaction What went wrong? The media "plays", muted. This interrupts my music. Did this work before? N/A Is it a problem with Flash or HTML5? HTML5 Does this work in other browsers? N/A Chrome version: 67.0.3396.87 Channel: stable OS Version: Flash Version: Contents of chrome://gpu: Also, why doesn't click to play work? It seems to have stopped really working recently.
,
Jul 15
Seems to be related to the internal media session: we should probably not take audio focus when the frame's origin isn't allowed to produce sound. It will lead to some edge cases where unmuting will not take audio focus but would handle the default case just well. CCing beccahughes@ in case of you want to look into this.
,
Jul 16
,
Jul 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/8617ff7583076c0622dc3ca1d443d2665f247661 commit 8617ff7583076c0622dc3ca1d443d2665f247661 Author: Becca Hughes <beccahughes@chromium.org> Date: Tue Jul 31 17:36:08 2018 [Media Session] Listen to WebContents muted state Listen to the WebContents muted state in MediaSession. If the WebContents is muted then we should act as if the player has no audio. This stops muted tabs from getting audio focus. BUG= 863438 Change-Id: I8218f225cd79d8490a805d46ad4606829742dd5e Reviewed-on: https://chromium-review.googlesource.com/1141144 Reviewed-by: Dale Curtis <dalecurtis@chromium.org> Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#579459} [modify] https://crrev.com/8617ff7583076c0622dc3ca1d443d2665f247661/content/browser/media/media_web_contents_observer.cc [modify] https://crrev.com/8617ff7583076c0622dc3ca1d443d2665f247661/content/browser/media/media_web_contents_observer.h [modify] https://crrev.com/8617ff7583076c0622dc3ca1d443d2665f247661/content/browser/media/session/media_session_browsertest.cc [modify] https://crrev.com/8617ff7583076c0622dc3ca1d443d2665f247661/content/browser/media/session/media_session_controller.cc [modify] https://crrev.com/8617ff7583076c0622dc3ca1d443d2665f247661/content/browser/media/session/media_session_controller.h [modify] https://crrev.com/8617ff7583076c0622dc3ca1d443d2665f247661/content/browser/media/session/media_session_controllers_manager.cc [modify] https://crrev.com/8617ff7583076c0622dc3ca1d443d2665f247661/content/browser/media/session/media_session_controllers_manager.h
,
Jul 31
,
Jul 31
This should be fixed in the next canary build (newer than 70.0.3507.0). |
||||
►
Sign in to add a comment |
||||
Comment 1 by dalecur...@chromium.org
, Jul 13