New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 863430 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
please use my google.com address
Closed: Jul 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: IPCChannelMojoTest.VerifyGlobalPid



Sign in to add a comment

IPCChannelMojoTest.VerifyGlobalPid is Flaky

Project Member Reported by Findit, Jul 13

Issue description

Cc: w...@chromium.org
Labels: M-69
Owner: roc...@chromium.org
Status: Started (was: Available)
rockot is on the case. :)
Project Member

Comment 5 by bugdroid1@chromium.org, Jul 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/138153b186554c2077e867efbeb71e0342b70159

commit 138153b186554c2077e867efbeb71e0342b70159
Author: Ken Rockot <rockot@chromium.org>
Date: Fri Jul 13 23:31:57 2018

IPC: Avoid closing Channel endpoints on error

We never want to explicitly close a Channel endpoint until after the
corresponding child process is dead. This prevents that from happening
in some cases where it's still possible today.

TBR=dcheng@chromium.org

Bug:  859386 ,861607, 863430 
Change-Id: I2858b6e011e06a000ae976c1e6ae96595cf67a85
Reviewed-on: https://chromium-review.googlesource.com/1135712
Commit-Queue: Ken Rockot <rockot@chromium.org>
Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575115}
[modify] https://crrev.com/138153b186554c2077e867efbeb71e0342b70159/ipc/DEPS
[modify] https://crrev.com/138153b186554c2077e867efbeb71e0342b70159/ipc/ipc_channel_mojo_unittest.cc
[modify] https://crrev.com/138153b186554c2077e867efbeb71e0342b70159/ipc/ipc_mojo_bootstrap.cc
[modify] https://crrev.com/138153b186554c2077e867efbeb71e0342b70159/ipc/ipc_test.mojom

Cc: stale-flakes-reports@google.com
Reporting to stale-flakes-reports@google.com to investigate why this issue is not being processed despite being in an appropriate queue for 7 days or more.
Status: Fixed (was: Started)
Looks fixed, closing to remove from sheriff queue

Sign in to add a comment