New issue
Advanced search Search tips

Issue 863426 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jul 17
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

InputDeviceInfo returns incorrect video-format capabilities

Project Member Reported by guidou@chromium.org, Jul 13

Issue description

The reason is that it is using the hashed device ID from the renderer process when requesting the video input formats.
It has to use real device ID to get the formats.
 
The consequence of this bug is that the real video formats supported by the device are not used for getCapabilities() but the fallback list of video formats.
Components: Blink>GetUserMedia
Project Member

Comment 3 by bugdroid1@chromium.org, Jul 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4273437267c208d21f3a5dba963673501cc72c95

commit 4273437267c208d21f3a5dba963673501cc72c95
Author: Guido Urdaneta <guidou@chromium.org>
Date: Tue Jul 17 18:59:51 2018

Fix InputDeviceInfo.getCapabilities() for video devices.

This CL fixes a bug where the hashed device ID instead of the real
device ID is used to get video input formats for
InputDeviceInfo.getCapabilities().
This bug caused the capabilities to be computed with the fallback list
of video formats instead of the real list.

Bug:  863426 

logging

Change-Id: I46b3eb6c22fe43548206d81efaf7a15b99c54456
Reviewed-on: https://chromium-review.googlesource.com/1138154
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Reviewed-by: Henrik Boström <hbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#575740}
[modify] https://crrev.com/4273437267c208d21f3a5dba963673501cc72c95/content/browser/renderer_host/media/media_devices_manager.cc
[modify] https://crrev.com/4273437267c208d21f3a5dba963673501cc72c95/content/browser/renderer_host/media/media_devices_manager.h
[modify] https://crrev.com/4273437267c208d21f3a5dba963673501cc72c95/content/browser/renderer_host/media/media_devices_manager_unittest.cc

Status: Fixed (was: Assigned)
Labels: M-69

Sign in to add a comment